[Bug 16235] New: Making borrower account actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Bug ID: 16235 Summary: Making borrower account actions buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50102&action=edit Bug 16235: Making borrower account actions buttons To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50102|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 50137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50137&action=edit Bug 16235: Making borrower account actions buttons To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Testing highlighted issues with 'Reverse' not caused by this patched. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50139&action=edit screenshot Hi Aleisha, buttons seem to wrap quite early - can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50137|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50247&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron@veron.ch --- Comment #6 from Marc Véron <veron@veron.ch> --- Sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt FAIL forbidden patterns forbidden pattern: tab char (line 114) forbidden pattern: tab char (line 112) forbidden pattern: tab char (line 122) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50247|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50300&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50300|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 50305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50305&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, If reverse_col is not set, the th will have a colspan of 1 and the targets (-1, -2) will be wrong. The right way is to use a class (NoSort), see acqui/newordersubscription.tt for an example. Why don't you put the 2 buttons into the same cell? To keep the alignment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50305|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50545&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EIDT: Moving the buttons into one column To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- This latest version triggers a JavaScript error because the count of table cells in the footer is off. I also notice on line 72 " " without a ; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50545|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50684&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Marc Véron <veron@veron.ch> --- Sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt FAIL forbidden patterns forbidden pattern: tab char (line 118) forbidden pattern: tab char (line 120) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50684|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50770&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error EDIT: removing tabs To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50770|0 |1 is obsolete| | --- Comment #15 from Marc Véron <veron@veron.ch> --- Created attachment 50793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50793&action=edit Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error EDIT: removing tabs To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Followed test plan. White spaces OK. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- HTML validator has a few complaints about the page, but none seem related to the patch - maybe something to look into for another day and bug report :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50793|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50794&action=edit [PASSED QA] Bug 16235: Making borrower account actions buttons EDIT: Fixing some indenting and adding actions class to the cells so the buttons don't wrap EDIT: Comment 6 EDIT: Moving the buttons into one column EDIT: Fixing typo and js error EDIT: removing tabs To test: 1) Go to a borrower's account page who has paid fines before a) Confirm column heading is now 'Actions' and covers both Reverse column and Print column b) Confirm Reverse and Print show as buttons and work as expected 2) Go to a borrower's account page who has never paid fines (or create a new borrower) a) Create a manual credit (just to put something in their account) b) Go back to their account page c) Confirm the Reverse column does not show as the column heading for Print is (since there is only one action in this column and it's written on every button) d) Confirm Print shows as a button and works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Followed test plan. White spaces OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16235 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master. Should be in the May 2016 release! Toda Aleisha! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org