[Bug 39522] New: Add hooks to allow 'Valuebuilder' plugins to be installable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Bug ID: 39522 Summary: Add hooks to allow 'Valuebuilder' plugins to be installable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: jacob.omara@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org We should allow the cataloguing or 'valuebuilder' plugins to be installable with the standard plugin architecture. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jacob.omara@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #1 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 180283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180283&action=edit Bug 39522: Allow Valuebuilders to be installable as plugins Unit tests to follow Test plan: 1. Install the example plugin from https://github.com/Jacobomara901/koha-plugin-value-builder and enable it 2. See that the framework plugin ‘custom_date’ as available to add to a subfield while the installed plugin is enabled and disappears when it is not. 3. Assign custom_date to your preferred Marc subfield (I use 650 subfield 2 ) and navigate to that field on a record of your choice 4. Ensure you are on the correct bib framework. See that the value builder appears while the plugin is enabled and disappears from that field while disabled. 5. Check uninstalling the plugin works correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #2 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 180284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180284&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180283|0 |1 is obsolete| | --- Comment #3 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 180301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180301&action=edit Mark Hofstetter will be following up with unit tests as we worked on this together. Test plan: 1. Install the example plugin from https://github.com/Jacobomara901/koha-plugin-value-builder and enable it 2. See that the framework plugin ‘custom_date’ is available to add to a subfield while the installed plugin is enabled and disappears when it is not. 3. Assign custom_date to your preferred Marc subfield (I use 650 subfield 2 ) and navigate to that field on a record of your choice 4. Ensure you are on the correct bib framework. See that the value builder appears while the plugin is enabled and disappears from that field while disabled. 5. Check uninstalling the plugin works correctly Bug 39522: Allow Valuebuilders to be installable as plugins Co-authored-by: Mark Hofstetter <koha@trust-box.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180284|0 |1 is obsolete| | --- Comment #4 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 180302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180302&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders Co-authored-by: Mark Hofstetter <koha@trust-box.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 180337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180337&action=edit Mark Hofstetter will be following up with unit tests as we worked on this together. Test plan: 1. Install the example plugin from https://github.com/Jacobomara901/koha-plugin-value-builder and enable it 2. See that the framework plugin ‘custom_date’ is available to add to a subfield while the installed plugin is enabled and disappears when it is not. 3. Assign custom_date to your preferred Marc subfield (I use 650 subfield 2 ) and navigate to that field on a record of your choice 4. Ensure you are on the correct bib framework. See that the value builder appears while the plugin is enabled and disappears from that field while disabled. 5. Check uninstalling the plugin works correctly Bug 39522: Allow Valuebuilders to be installable as plugins Co-authored-by: Mark Hofstetter <mark@hofstetter.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180302|0 |1 is obsolete| | --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 180338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180338&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders Co-authored-by: Mark Hofstetter <mark@hofstetter.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183467&action=edit Bug 39522: Allow Valuebuilders to be installable as plugins This patch adds hooks to allow 'Valuebuilder' plugins to be installable using the standard plugin architecture for Koha. This enables cataloguing plugins to be dynamically installed, enabled, and disabled through the plugin system rather than being hardcoded framework components. Test plan: 1. Install the example valuebuilder plugin from GitHub (https://github.com/Jacobomara901/koha-plugin-value-builder) 2. Go to Administration > Plugins 3. Verify the valuebuilder plugin appears in the plugins list 4. Enable/disable the plugin and confirm the custom valuebuilder appears/disappears in the framework configuration 5. Assign the custom valuebuilder to a MARC subfield in the bibliographic framework 6. Create/edit a bibliographic record and verify the valuebuilder button appears next to the configured subfield 7. Click the valuebuilder button and confirm it functions correctly 8. Disable the plugin and verify the valuebuilder button disappears 9. Re-enable the plugin and confirm functionality is restored 10. Uninstall the plugin and verify it's completely removed Co-authored-by: Mark Hofstetter <koha@trust-box.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180338|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183468&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders This patch adds filtering functionality to the plugin home page to allow valuebuilder plugins to be displayed alongside other plugins. This ensures that valuebuilder plugins are properly integrated into the plugin management interface and can be easily identified and managed by administrators. Test plan: 1. Install a valuebuilder plugin (following the test plan from the previous patch) 2. Go to Administration > Plugins 3. Verify that the valuebuilder plugin appears in the plugins list 4. Confirm that the plugin shows the correct type/category information 5. Use any available filtering options to verify valuebuilder plugins can be filtered appropriately 6. Verify that valuebuilder plugins display the same management options (enable/disable/configure) as other plugin types 7. Test that plugin status changes are reflected correctly in the filtered view Co-authored-by: Mark Hofstetter <mark@hofstetter.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183469&action=edit Bug 39522: Add unit tests for valuebuilder plugin hooks This patch adds comprehensive unit tests for the new valuebuilder plugin functionality. The tests verify that plugins can provide valuebuilders through the get_valuebuilder() method and that FrameworkPlugin can correctly load and integrate with plugin-based valuebuilders. The tests use a dedicated TestValuebuilder plugin to ensure realistic testing scenarios without relying on mocks, following the pattern established in other plugin hook tests. Test plan: 1. Run the new test file: prove t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t 2. Verify all tests pass (9 tests total) 3. Run all plugin tests to ensure no regressions: prove t/db_dependent/Koha/Plugins/ 4. Verify all plugin tests still pass (113 tests across 19 files) 5. Test the specific functionality: - Verify plugins without get_valuebuilder() method are not found as valuebuilders - Verify plugins with get_valuebuilder() method are correctly discovered - Verify FrameworkPlugin can load plugin-based valuebuilders - Verify JavaScript generation works with plugin valuebuilders - Verify plugin enable/disable affects valuebuilder availability 6. Confirm FrameworkPlugin integration tests still pass: prove t/db_dependent/FrameworkPlugin.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180301|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- We've now got this running in production on our sites at OpenFifth. The Homosaurus plugin is a great example of using it. * https://github.com/openfifth/koha-plugin-homosaurus-value-builder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- This looks like it's working correctly but the QA script has lots of complaints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183467|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184030&action=edit Bug 39522: Allow Valuebuilders to be installable as plugins This patch adds hooks to allow 'Valuebuilder' plugins to be installable using the standard plugin architecture for Koha. This enables cataloguing plugins to be dynamically installed, enabled, and disabled through the plugin system rather than being hardcoded framework components. Test plan: 1. Install the example valuebuilder plugin from GitHub (https://github.com/Jacobomara901/koha-plugin-value-builder) 2. Go to Administration > Plugins 3. Verify the valuebuilder plugin appears in the plugins list 4. Enable/disable the plugin and confirm the custom valuebuilder appears/disappears in the framework configuration 5. Assign the custom valuebuilder to a MARC subfield in the bibliographic framework 6. Create/edit a bibliographic record and verify the valuebuilder button appears next to the configured subfield 7. Click the valuebuilder button and confirm it functions correctly 8. Disable the plugin and verify the valuebuilder button disappears 9. Re-enable the plugin and confirm functionality is restored 10. Uninstall the plugin and verify it's completely removed Sponsored-by: Open Fifth <https://openfifth.co.uk> Co-authored-by: Mark Hofstetter <koha@trust-box.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183468|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184031&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders This patch adds filtering functionality to the plugin home page to allow valuebuilder plugins to be displayed alongside other plugins. This ensures that valuebuilder plugins are properly integrated into the plugin management interface and can be easily identified and managed by administrators. Test plan: 1. Install a valuebuilder plugin (following the test plan from the previous patch) 2. Go to Administration > Plugins 3. Verify that the valuebuilder plugin appears in the plugins list 4. Confirm that the plugin shows the correct type/category information 5. Use any available filtering options to verify valuebuilder plugins can be filtered appropriately 6. Verify that valuebuilder plugins display the same management options (enable/disable/configure) as other plugin types 7. Test that plugin status changes are reflected correctly in the filtered view Co-authored-by: Mark Hofstetter <mark@hofstetter.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183469|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184032&action=edit Bug 39522: Add unit tests for valuebuilder plugin hooks This patch adds comprehensive unit tests for the new valuebuilder plugin functionality. The tests verify that plugins can provide valuebuilders through the get_valuebuilder() method and that FrameworkPlugin can correctly load and integrate with plugin-based valuebuilders. The tests use a dedicated TestValuebuilder plugin to ensure realistic testing scenarios without relying on mocks, following the pattern established in other plugin hook tests. Test plan: 1. Run the new test file: prove t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t 2. Verify all tests pass (9 tests total) 3. Run all plugin tests to ensure no regressions: prove t/db_dependent/Koha/Plugins/ 4. Verify all plugin tests still pass (113 tests across 19 files) 5. Test the specific functionality: - Verify plugins without get_valuebuilder() method are not found as valuebuilders - Verify plugins with get_valuebuilder() method are correctly discovered - Verify FrameworkPlugin can load plugin-based valuebuilders - Verify JavaScript generation works with plugin valuebuilders - Verify plugin enable/disable affects valuebuilder availability 6. Confirm FrameworkPlugin integration tests still pass: prove t/db_dependent/FrameworkPlugin.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184033&action=edit Bug 39522: (follow-up) Remove debugging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184034&action=edit Bug 39522: (follow-up) Remove closing </html> to allow tidy I don't understand this.. for the tidy script to run and the qa script to be happy I had to remove the closing html tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184034|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184071&action=edit Bug 39522: Ignore closing html tag to correctly tidy The prettier plugin for TT has been adjusted to correctly parse our TT files: most of them does not have an opening head but have a closing head, then have an opening body but no closing body. To avoid the parser to fail we are commenting those lines in a pre-process step in the plugin, then uncomment them in the tidy script. https://gitlab.com/koha-community/prettier-plugin-template-toolkit/-/blob/ma... export const preprocess: Parser<Node>["preprocess"] = (text) => { return text .replace("</head>", "<!--</head>-->") .replace(/<body(.*)/, "<!--<body$1-->") .replace("</body>", "<!--</body>-->"); }; https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/deve... # Revert the substitutions done by the prettier plugin my $content = read_file($file); $content =~ s#<!--</head>-->#</head>#g; $content =~ s#<!--<body(.*)-->#<body$1#g; $content =~ s#<!--</body>-->#</body>#g; (yes it's a bit messy, but our templates are messy) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184071|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184072&action=edit Bug 39522: Ignore the whole file for tidy The prettier plugin for TT has been adjusted to correctly parse our TT files: most of them does not have an opening head but have a closing head, then have an opening body but no closing body. To avoid the parser to fail we are commenting those lines in a pre-process step in the plugin, then uncomment them in the tidy script. Which means we actually cannot parse correctly formatted HTML files. https://gitlab.com/koha-community/prettier-plugin-template-toolkit/-/blob/ma... export const preprocess: Parser<Node>["preprocess"] = (text) => { return text .replace("</head>", "<!--</head>-->") .replace(/<body(.*)/, "<!--<body$1-->") .replace("</body>", "<!--</body>-->"); }; https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/deve... # Revert the substitutions done by the prettier plugin my $content = read_file($file); $content =~ s#<!--</head>-->#</head>#g; $content =~ s#<!--<body(.*)-->#<body$1#g; $content =~ s#<!--</body>-->#</body>#g; (yes it's a bit messy, but our templates are messy) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm confused, where are we at with this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40993 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184030|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189536&action=edit Bug 39522: Allow Valuebuilders to be installable as plugins This patch adds hooks to allow 'Valuebuilder' plugins to be installable using the standard plugin architecture for Koha. This enables cataloguing plugins to be dynamically installed, enabled, and disabled through the plugin system rather than being hardcoded framework components. Test plan: 1. Install the example valuebuilder plugin from GitHub (https://github.com/Jacobomara901/koha-plugin-value-builder) 2. Go to Administration > Plugins 3. Verify the valuebuilder plugin appears in the plugins list 4. Enable/disable the plugin and confirm the custom valuebuilder appears/disappears in the framework configuration 5. Assign the custom valuebuilder to a MARC subfield in the bibliographic framework 6. Create/edit a bibliographic record and verify the valuebuilder button appears next to the configured subfield 7. Click the valuebuilder button and confirm it functions correctly 8. Disable the plugin and verify the valuebuilder button disappears 9. Re-enable the plugin and confirm functionality is restored 10. Uninstall the plugin and verify it's completely removed Sponsored-by: Open Fifth <https://openfifth.co.uk> Co-authored-by: Mark Hofstetter <koha@trust-box.at> Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184031|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189537&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders This patch adds filtering functionality to the plugin home page to allow valuebuilder plugins to be displayed alongside other plugins. This ensures that valuebuilder plugins are properly integrated into the plugin management interface and can be easily identified and managed by administrators. Test plan: 1. Install a valuebuilder plugin (following the test plan from the previous patch) 2. Go to Administration > Plugins 3. Verify that the valuebuilder plugin appears in the plugins list 4. Confirm that the plugin shows the correct type/category information 5. Use any available filtering options to verify valuebuilder plugins can be filtered appropriately 6. Verify that valuebuilder plugins display the same management options (enable/disable/configure) as other plugin types 7. Test that plugin status changes are reflected correctly in the filtered view Co-authored-by: Mark Hofstetter <mark@hofstetter.at> Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184032|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189538&action=edit Bug 39522: Add unit tests for valuebuilder plugin hooks This patch adds comprehensive unit tests for the new valuebuilder plugin functionality. The tests verify that plugins can provide valuebuilders through the get_valuebuilder() method and that FrameworkPlugin can correctly load and integrate with plugin-based valuebuilders. The tests use a dedicated TestValuebuilder plugin to ensure realistic testing scenarios without relying on mocks, following the pattern established in other plugin hook tests. Test plan: 1. Run the new test file: prove t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t 2. Verify all tests pass (9 tests total) 3. Run all plugin tests to ensure no regressions: prove t/db_dependent/Koha/Plugins/ 4. Verify all plugin tests still pass (113 tests across 19 files) 5. Test the specific functionality: - Verify plugins without get_valuebuilder() method are not found as valuebuilders - Verify plugins with get_valuebuilder() method are correctly discovered - Verify FrameworkPlugin can load plugin-based valuebuilders - Verify JavaScript generation works with plugin valuebuilders - Verify plugin enable/disable affects valuebuilder availability 6. Confirm FrameworkPlugin integration tests still pass: prove t/db_dependent/FrameworkPlugin.t Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184033|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189539&action=edit Bug 39522: (follow-up) Remove debugging Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184072|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189540&action=edit Bug 39522: Ignore the whole file for tidy The prettier plugin for TT has been adjusted to correctly parse our TT files: most of them does not have an opening head but have a closing head, then have an opening body but no closing body. To avoid the parser to fail we are commenting those lines in a pre-process step in the plugin, then uncomment them in the tidy script. Which means we actually cannot parse correctly formatted HTML files. https://gitlab.com/koha-community/prettier-plugin-template-toolkit/-/blob/ma... export const preprocess: Parser<Node>["preprocess"] = (text) => { return text .replace("</head>", "<!--</head>-->") .replace(/<body(.*)/, "<!--<body$1-->") .replace("</body>", "<!--</body>-->"); }; https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/deve... # Revert the substitutions done by the prettier plugin my $content = read_file($file); $content =~ s#<!--</head>-->#</head>#g; $content =~ s#<!--<body(.*)-->#<body$1#g; $content =~ s#<!--</body>-->#</body>#g; (yes it's a bit messy, but our templates are messy) Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189536|0 |1 is obsolete| | --- Comment #25 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189544&action=edit Bug 39522: Allow Valuebuilders to be installable as plugins This patch adds hooks to allow 'Valuebuilder' plugins to be installable using the standard plugin architecture for Koha. This enables cataloguing plugins to be dynamically installed, enabled, and disabled through the plugin system rather than being hardcoded framework components. Test plan: 1. Install the example valuebuilder plugin from GitHub (https://github.com/Jacobomara901/koha-plugin-value-builder) 2. Go to Administration > Plugins 3. Verify the valuebuilder plugin appears in the plugins list 4. Enable/disable the plugin and confirm the custom valuebuilder appears/disappears in the framework configuration 5. Assign the custom valuebuilder to a MARC subfield in the bibliographic framework 6. Create/edit a bibliographic record and verify the valuebuilder button appears next to the configured subfield 7. Click the valuebuilder button and confirm it functions correctly 8. Disable the plugin and verify the valuebuilder button disappears 9. Re-enable the plugin and confirm functionality is restored 10. Uninstall the plugin and verify it's completely removed Sponsored-by: Open Fifth <https://openfifth.co.uk> Co-authored-by: Mark Hofstetter <koha@trust-box.at> Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189537|0 |1 is obsolete| | --- Comment #26 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189545&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders This patch adds filtering functionality to the plugin home page to allow valuebuilder plugins to be displayed alongside other plugins. This ensures that valuebuilder plugins are properly integrated into the plugin management interface and can be easily identified and managed by administrators. Test plan: 1. Install a valuebuilder plugin (following the test plan from the previous patch) 2. Go to Administration > Plugins 3. Verify that the valuebuilder plugin appears in the plugins list 4. Confirm that the plugin shows the correct type/category information 5. Use any available filtering options to verify valuebuilder plugins can be filtered appropriately 6. Verify that valuebuilder plugins display the same management options (enable/disable/configure) as other plugin types 7. Test that plugin status changes are reflected correctly in the filtered view Co-authored-by: Mark Hofstetter <mark@hofstetter.at> Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189538|0 |1 is obsolete| | --- Comment #27 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189546&action=edit Bug 39522: Add unit tests for valuebuilder plugin hooks This patch adds comprehensive unit tests for the new valuebuilder plugin functionality. The tests verify that plugins can provide valuebuilders through the get_valuebuilder() method and that FrameworkPlugin can correctly load and integrate with plugin-based valuebuilders. The tests use a dedicated TestValuebuilder plugin to ensure realistic testing scenarios without relying on mocks, following the pattern established in other plugin hook tests. Test plan: 1. Run the new test file: prove t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t 2. Verify all tests pass (9 tests total) 3. Run all plugin tests to ensure no regressions: prove t/db_dependent/Koha/Plugins/ 4. Verify all plugin tests still pass (113 tests across 19 files) 5. Test the specific functionality: - Verify plugins without get_valuebuilder() method are not found as valuebuilders - Verify plugins with get_valuebuilder() method are correctly discovered - Verify FrameworkPlugin can load plugin-based valuebuilders - Verify JavaScript generation works with plugin valuebuilders - Verify plugin enable/disable affects valuebuilder availability 6. Confirm FrameworkPlugin integration tests still pass: prove t/db_dependent/FrameworkPlugin.t Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189539|0 |1 is obsolete| | --- Comment #28 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189547&action=edit Bug 39522: (follow-up) Remove debugging Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189540|0 |1 is obsolete| | --- Comment #29 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189548&action=edit Bug 39522: Ignore the whole file for tidy The prettier plugin for TT has been adjusted to correctly parse our TT files: most of them does not have an opening head but have a closing head, then have an opening body but no closing body. To avoid the parser to fail we are commenting those lines in a pre-process step in the plugin, then uncomment them in the tidy script. Which means we actually cannot parse correctly formatted HTML files. https://gitlab.com/koha-community/prettier-plugin-template-toolkit/-/blob/ma... export const preprocess: Parser<Node>["preprocess"] = (text) => { return text .replace("</head>", "<!--</head>-->") .replace(/<body(.*)/, "<!--<body$1-->") .replace("</body>", "<!--</body>-->"); }; https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/deve... # Revert the substitutions done by the prettier plugin my $content = read_file($file); $content =~ s#<!--</head>-->#</head>#g; $content =~ s#<!--<body(.*)-->#<body$1#g; $content =~ s#<!--</body>-->#</body>#g; (yes it's a bit messy, but our templates are messy) Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #30 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189549&action=edit Bug 39522: (follow up) Add defensive checking before instantiating plugins object Previously this could have caused issues if enable_plugins was disabled in koha-conf as we were not checking enabled status before instantiating an instance of the plugins object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #31 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Added a quick follow up to add defensive checks to FrameworkPlugin.pm as previously, this would fail if enable_plugins was disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Shouldn't we have it documented in the KitchenSink plugin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #33 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Definitely! I'll get a PR pushed over to the KitchenSink repo shortly. I was only waiting as I didn't want to add documentation for a "usable" hook that didn't actually exist yet! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #34 from Jacob O'Mara <jacob.omara@openfifth.co.uk> ---
From a QA standpoint, does that mean we're happy with the above as it currently stands?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189842&action=edit Bug 39522: Allow Valuebuilders to be installable as plugins This patch adds hooks to allow 'Valuebuilder' plugins to be installable using the standard plugin architecture for Koha. This enables cataloguing plugins to be dynamically installed, enabled, and disabled through the plugin system rather than being hardcoded framework components. Test plan: 1. Install the example valuebuilder plugin from GitHub (https://github.com/Jacobomara901/koha-plugin-value-builder) 2. Go to Administration > Plugins 3. Verify the valuebuilder plugin appears in the plugins list 4. Enable/disable the plugin and confirm the custom valuebuilder appears/disappears in the framework configuration 5. Assign the custom valuebuilder to a MARC subfield in the bibliographic framework 6. Create/edit a bibliographic record and verify the valuebuilder button appears next to the configured subfield 7. Click the valuebuilder button and confirm it functions correctly 8. Disable the plugin and verify the valuebuilder button disappears 9. Re-enable the plugin and confirm functionality is restored 10. Uninstall the plugin and verify it's completely removed Sponsored-by: Open Fifth <https://openfifth.co.uk> Co-authored-by: Mark Hofstetter <koha@trust-box.at> Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189843&action=edit Bug 39522: Add filtering to the plugin home page for valuebuilders This patch adds filtering functionality to the plugin home page to allow valuebuilder plugins to be displayed alongside other plugins. This ensures that valuebuilder plugins are properly integrated into the plugin management interface and can be easily identified and managed by administrators. Test plan: 1. Install a valuebuilder plugin (following the test plan from the previous patch) 2. Go to Administration > Plugins 3. Verify that the valuebuilder plugin appears in the plugins list 4. Confirm that the plugin shows the correct type/category information 5. Use any available filtering options to verify valuebuilder plugins can be filtered appropriately 6. Verify that valuebuilder plugins display the same management options (enable/disable/configure) as other plugin types 7. Test that plugin status changes are reflected correctly in the filtered view Co-authored-by: Mark Hofstetter <mark@hofstetter.at> Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189844&action=edit Bug 39522: Add unit tests for valuebuilder plugin hooks This patch adds comprehensive unit tests for the new valuebuilder plugin functionality. The tests verify that plugins can provide valuebuilders through the get_valuebuilder() method and that FrameworkPlugin can correctly load and integrate with plugin-based valuebuilders. The tests use a dedicated TestValuebuilder plugin to ensure realistic testing scenarios without relying on mocks, following the pattern established in other plugin hook tests. Test plan: 1. Run the new test file: prove t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t 2. Verify all tests pass (9 tests total) 3. Run all plugin tests to ensure no regressions: prove t/db_dependent/Koha/Plugins/ 4. Verify all plugin tests still pass (113 tests across 19 files) 5. Test the specific functionality: - Verify plugins without get_valuebuilder() method are not found as valuebuilders - Verify plugins with get_valuebuilder() method are correctly discovered - Verify FrameworkPlugin can load plugin-based valuebuilders - Verify JavaScript generation works with plugin valuebuilders - Verify plugin enable/disable affects valuebuilder availability 6. Confirm FrameworkPlugin integration tests still pass: prove t/db_dependent/FrameworkPlugin.t Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189845&action=edit Bug 39522: (follow-up) Remove debugging Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189846&action=edit Bug 39522: Ignore the whole file for tidy The prettier plugin for TT has been adjusted to correctly parse our TT files: most of them does not have an opening head but have a closing head, then have an opening body but no closing body. To avoid the parser to fail we are commenting those lines in a pre-process step in the plugin, then uncomment them in the tidy script. Which means we actually cannot parse correctly formatted HTML files. https://gitlab.com/koha-community/prettier-plugin-template-toolkit/-/blob/ma... export const preprocess: Parser<Node>["preprocess"] = (text) => { return text .replace("</head>", "<!--</head>-->") .replace(/<body(.*)/, "<!--<body$1-->") .replace("</body>", "<!--</body>-->"); }; https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/deve... # Revert the substitutions done by the prettier plugin my $content = read_file($file); $content =~ s#<!--</head>-->#</head>#g; $content =~ s#<!--<body(.*)-->#<body$1#g; $content =~ s#<!--</body>-->#</body>#g; (yes it's a bit messy, but our templates are messy) Signed-off-by: Catherine Small <c.small@rcs.ac.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189847&action=edit Bug 39522: (follow up) Add defensive checking before instantiating plugins object Previously this could have caused issues if enable_plugins was disabled in koha-conf as we were not checking enabled status before instantiating an instance of the plugins object. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189544|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #43 from Fridolin Somers <fridolin.somers@biblibre.com> --- Please add to https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38384 [Bug 38384] General fix for plugins breaking database transactions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39522 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org