[Bug 23259] New: Remove reset-fonts-grids.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Bug ID: 23259 Summary: Remove reset-fonts-grids.css Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The staff client's global CSS file imports a CSS file called "reset-fonts-grids.css," a set of defaults and grid definitions from the YUI library. We can remove this now that we have Bootstrap grids on all staff client pages. Some of our CSS will require some minor updates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91334&action=edit Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) <input> and <button> tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91334|0 |1 is obsolete| | --- Comment #2 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91336&action=edit Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) <input> and <button> tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nadine.pierre@InLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91336|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91388&action=edit Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) <input> and <button> tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373 [Bug 24373] Correct basic cataloging editor CSS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org