http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 --- Comment #1 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 23616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23616&action=edit Bug-11411-ENH-Bootstrap-theme-enhancement-for right to left This patch will make a small change on the bootstrap-rtl.min.css file to make the welcome statement and the logout link located to the left of the screen. Test plan : 1-apply the patch 2-translate install ar-Arab . and that's it . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 --- Comment #2 from Karam Qubsi <karamqubsi@gmail.com> --- Created attachment 23617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23617&action=edit After the patch The results must be as the attached image . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23616|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23883&action=edit Bug 11411 [ENH] Bootstrap theme (enhancement) for (right to left) This patch will make a small change on the bootstrap-rtl.min.css file to make the welcome statement and the logout link located to the left of the screen. Test plan : 1-apply the patch 2-translate install ar-Arab 3-check the login/logut is on the left and that's it. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |oleonard@myacpl.org --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works nicely, but not sure if it touches the necessary files. I see there is also /koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.css. Adding Owen in cc as he will know and I hope for some hints :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you maybe provide a patch here? I am not sure anyone else understands how this works right now (including me) :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23883|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24903&action=edit Bug 11411 - Bootstrap theme (enhancement) for (right to left) This patch improves Koha's layout when a right-to-left language is being displayed by correcting a float set by the right-to-left version of Bootstrap CSS. The patch modifies the right-to-left Less file and includes a now-minified version of the compiled CSS. To test, install a right-to-left language like ar-Arab. Apply the patch and view the OPAC under the Bootstrap theme. When logged in, the aligned to the left. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24903|0 |1 is obsolete| | --- Comment #8 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 25090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25090&action=edit Bug 11411 - Bootstrap theme (enhancement) for (right to left) This patch improves Koha's layout when a right-to-left language is being displayed by correcting a float set by the right-to-left version of Bootstrap CSS. The patch modifies the right-to-left Less file and includes a now-minified version of the compiled CSS. To test, install a right-to-left language like ar-Arab. Apply the patch and view the OPAC under the Bootstrap theme. When logged in, the aligned to the left. Signed-off-by: Holger Meißner <h.meissner.82@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25090|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25131&action=edit Bug 11411 - Bootstrap theme (enhancement) for (right to left) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- I have pushed Owen's original patch, but I'm declining to push the follow-ups supplied by Kyle because they defeat the (network performance) purpose of the minification. Also, in this case I don't think we want the compiled CSS to be readable, since one /should/ be editing the LESS files. That said, I'm not setting this decision in concrete, as only time will tell whether the benefits of minifying the CSS file outweigh the stumbling blocks for folks using a browser CSS debugger. However, I will point out that Chrome, at least, includes a pretty-print function in its debugger. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.