[Bug 35498] New: SQL auto-complete should not prevent use of tab for spacing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Bug ID: 35498 Summary: SQL auto-complete should not prevent use of tab for spacing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org Depends on: 32613 With the new auto-complete feature for SQL, the tab key *always* opens the auto-complete suggestions popup, even when the cursor is at the start of a new line or immediately after a whitespace. This makes tab unusable for spacing/formatting, which is difficult functionality to use. In a code editor, I expect tab to auto-complete if I've started a word/string, but to insert a whitespace if I'm at the start of a line or otherwise between words. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 [Bug 32613] Add auto-completion to our SQL reports editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I don't think the tab ever worked there for adding whitespace/tab, so maybe not a regression and tab for auto-complete seems common? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm deeply accustomed to tab-indenting new lines when writing reports in Koha and am certain this is a change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #2)
I'm deeply accustomed to tab-indenting new lines when writing reports in Koha and am certain this is a change.
Hm OK, I might have never tried, but seem to remember getting annoyed by it not working in the system preferences (*UserJS etc). Maybe some changes happened over time. Usually a normal HTML input field doesn't allow it (like here in bugzilla), as the tab is used in form fields to jump to the next field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I can confirm Andrew's report, and I agree that it is frustrating. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I notice that the "tab" is in a list of exclusions in guided_reports_start.tt at https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32613&attachment=147715 However, it looks like it is triggering the autocomplete anyway. I imagine PTFS-Europe as the folk who introduced the change might have an idea on how to fix it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159622&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159622|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159623&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159623|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159625&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159625|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159626&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks for the quick fix, Matt. Works great, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- You're a legend, Matt. Thanks for hopping on this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org