[Bug 17487] New: Improper placement of select/clear all in Z39.50/ SRU search dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Bug ID: 17487 Summary: Improper placement of select/clear all in Z39.50/SRU search dialog Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt@gmail.com Reporter: rbit@rbit.cz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Links allowing to select/clear all Z39.50 servers have icons next to the text. These links are improperly placed in the case the localized caption is a bit longer than English version, see picture: http://prntscr.com/cy0bey In addition, these links are placed in an <h2> header, but it's not semantically correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 56735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56735&action=edit Links to "select/clear all" moved below the header tag Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Radek, we probably can omit the whole style attribute in span, as the span is no more in h2 tag, the style attribute isn't necessary. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- I've tried to remove it, but it looks better with the left padding. On the other hand, display:inline is useless, you're right. So? Should we remove the outer span at all, or just display:inline? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #3)
I've tried to remove it, but it looks better with the left padding. On the other hand, display:inline is useless, you're right. So? Should we remove the outer span at all, or just display:inline?
What looks better is on everyone opinion, so I'm OK with removing only display:inline thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 56736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56736&action=edit Styling moved from style attribute into staff-global.css Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header 4) [Optionally] Set some style in IntranetUserCSS for class z3950checks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56735|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56737&action=edit [SIGNED-OFF] Bug 17487: Links to "select/clear all" moved below the header tag Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56736|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56738&action=edit [SIGNED-OFF] Bug 17487: Styling moved from style attribute into staff-global.css Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header 4) [Optionally] Set some style in IntranetUserCSS for class z3950checks https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56737|0 |1 is obsolete| | Attachment #56738|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56834&action=edit Bug 17487: Links to "select/clear all" moved below the header tag Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56835&action=edit Bug 17487: Styling moved from style attribute into staff-global.css Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header 4) [Optionally] Set some style in IntranetUserCSS for class z3950checks https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This applies to 16.05, but also to 16.11 or master. Version is set to 16.05. What should be done? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Kyle: should be for master too, as confirmed by Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Radek! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Contains strings - holding this back for possible inclusion in 16.11.3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #16 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org