[Bug 16903] New: Multiple class attributes on catalog search tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Bug ID: 16903 Summary: Multiple class attributes on catalog search tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org cat-search.inc contains an element with two class attributes, which is invalid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53305&action=edit Bug 16903 - Multiple class attributes on catalog search tab cat-search.inc contains an element with two class attributes, which is invalid. This patch corrects it. To test, apply the patch and view any page which uses the cat-search include file to display the header search boxes. For instance, the bibliographic detail page. In the header, the "Search the catalog" box should be selected, and any text you type in the box should be carried over when you switch to different search tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53305|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 53337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53337&action=edit Bug 16903 - Multiple class attributes on catalog search tab cat-search.inc contains an element with two class attributes, which is invalid. This patch corrects it. To test, apply the patch and view any page which uses the cat-search include file to display the header search boxes. For instance, the bibliographic detail page. In the header, the "Search the catalog" box should be selected, and any text you type in the box should be carried over when you switch to different search tabs. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53337|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53349&action=edit [PASSED QA] Bug 16903 - Multiple class attributes on catalog search tab cat-search.inc contains an element with two class attributes, which is invalid. This patch corrects it. To test, apply the patch and view any page which uses the cat-search include file to display the header search boxes. For instance, the bibliographic detail page. In the header, the "Search the catalog" box should be selected, and any text you type in the box should be carried over when you switch to different search tabs. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Was this really pushed (with thx to mtompset) ?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #5)
Was this really pushed (with thx to mtompset) ??
My bad! Pushed to master for real this time! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16549 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.hemme@thulb.uni-jena. | |de --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 17275 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16903 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org