http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 16262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16262&action=edit Bug 9833: Refine shelves permissions. - This patch adds two new permissions for shelves: - manage_shelves: allows to manage shelves - merge_from_shelves: allows to merge records from shelves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16345&action=edit Bug 9833: Refine shelves permissions. - This patch adds two new permissions for shelves: - manage_shelves: allows to manage shelves - merge_from_shelves: allows to merge records from shelves Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16345|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|New shelves permissions |New virtual shelves/lists | |permissions QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I like this patch since we really need some permissions for shelves!! But I think that we must not add manage shelves under editcatalogue. Managing shelves should have its own permission (if we allow it in the first place). If this patch adds an entry for shelves/lists, I would also have the idea of adding/allowing Change ownership for instance. Note also the privacy issue here as noted in related reports (should a staff user be able to view these lists at all?). So, you could remove manage_shelves from this patch or add a root entry like lists and start a discussion on how we should view the underlying manage. What we do need e.g. is a permission to manage shelves that do no longer have an owner (after deleting user). Merge from shelves is another story: this indeed fits better under edit_catalogue. A technical detail: To know member->userid you use GetMemberDetails: Isn't that quite overkill? Also please watch operator priority in $user && $shelf->{owner}==$user) || C4::Auth::haspermission... Place parentheses? A test plan should be added too. Thanks for your attention. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16360|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18247&action=edit Bug 9833: Refine shelves permissions. - This patch adds two new permissions for shelves: - manage_shelves: allows to manage shelves - merge_from_shelves: allows to merge records from shelves Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Liz Rea from comment #8)

Marcel,

I'm confused by the status of this patch - there's a signed off patch but it's failed QA?

I came up against this today, it would be super cool to get this little nagger fixed.

Liz

I hope that Matthias as author of the patch (or someone else from Biblibre?) adjusts this patch to make it pass qa. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- The lists owned by NULL happens when the borrower that created the list is deleted. That's probably a different bug than this. Matthias, any chance of getting this fixed up? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 -- You are receiving this mail because: You are watching all bug changes.