[Bug 15175] New: IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Bug ID: 15175 Summary: IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty: the link on cover images in search.pl result page goes always to detail.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14259 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|IntranetDefaultView syspref |IntranetBiblioDefaultView |is not respected when |syspref is not respected |XSLTResultsDisplay is empty |when XSLTResultsDisplay is | |empty -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44777&action=edit Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44777|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44809&action=edit [SIGNED-OFF]Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Link to right display according with IntranetBiblioDefaultView is fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have formally deprecated the non-XSLT views a while ago: DEPR1: non-XSLT search results and bib display templates deprecated As of 2014-07-02, use of the XSLT search results and bib details display templates for the staff interface and public catalog is now the preferred option. Consequently, the non-XSLT option is now deprecated and it will not be maintained. Template files used by the non-XSLT bib and results displays need not be touched in future staff interface and public catalog enhancements; it is necessary only to update XSLT. --- As this is more of a bug fix, I have tested it. Leaving the final decision to our RM ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44809|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44886&action=edit [PASSED QA] Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Link to right display according with IntranetBiblioDefaultView is fixed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=14175 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org