http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-02-07 09:48:29 UTC --- Is there any reason to use tabs here ? The content is the same for each tab. Couldn't we make just one form, with a radiobutton to select the type of search? Something like: o Search Authorities o Search Main Heading o Search All Headings -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19731&action=edit Bug 7484 - Keeping typed values when searching for authorities See commit message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Page "Home › Authorities" 1) I'm on the "Search authorities" tab. I select an authority type, then change the active tab. The type change is lost. The type seemes to be lost only if the "second" tab is empty, as it initially is. If a selection would have been previously made for that "second" tab, it would not be lost. Now a user can make a selection for a tab, and a different selection for a another tab, and they would be both kept. All the 4 parts (name/term, verb, data, sort) of a condition set in one of the 3 tab ("main headings" or "all headings" or "keyword" search) are kept exactly the same after moving from this tab to another one, and then coming back to the first tab. If the user would choose different selections in the 3 tabs, the patch would loose this information. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-30 last check this| | --- Comment #6 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

no radiobutton appears. There are still tabs. Using radiobuttons was an idea of Adrien SAURAT, but the patch does not use

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Paola Rossi from comment #7) them. See test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23034|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23068&action=edit Bug 7484 - Keeping typed values when searching for authorities 1) I'm on the "Search authorities" tab. I select an authority type, then change the active tab. The type change is lost. 2) I'm on a tab and type a search pattern, then change tab, the string is lost. This behaviour is logical, given the fact that we're using tabs, but it would be more practical to keep the typed informations when the user changes the search mode. This patch add a few JQuery code to synchronise inputs between all tabbed authorities search forms. Test plan : - Go to Authorities home page : cgi-bin/koha/authorities/authorities-home.pl - In toolbar, "Search main heading" is selected - Change all inputs : authotity type, operator, term, and sort order - Click on "Search all headings" tab => Inputs are the same has previous tab - Click on "Keyword search" tab => Inputs are the same has previous tab Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Explicitly declare 2 new variables used. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23068|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23118&action=edit [PASSED QA] Bug 7484 - Keeping typed values when searching for authorities 1) I'm on the "Search authorities" tab. I select an authority type, then change the active tab. The type change is lost. 2) I'm on a tab and type a search pattern, then change tab, the string is lost. This behaviour is logical, given the fact that we're using tabs, but it would be more practical to keep the typed informations when the user changes the search mode. This patch add a few JQuery code to synchronise inputs between all tabbed authorities search forms. Test plan : - Go to Authorities home page : cgi-bin/koha/authorities/authorities-home.pl - In toolbar, "Search main heading" is selected - Change all inputs : authotity type, operator, term, and sort order - Click on "Search all headings" tab => Inputs are the same has previous tab - Click on "Keyword search" tab => Inputs are the same has previous tab Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Explicitly declare 2 new variables used. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described, Firebug doesn't show any problems with the Javascript. Could be useful for other tabbed searches like the start page as well. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.