[Bug 29815] New: Pre-populate 'Date acquired' field when receiving serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Bug ID: 29815 Summary: Pre-populate 'Date acquired' field when receiving serial Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org When receiving serial issues the 952$d (Date acquired) field should be pre-populated with the current date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 129126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129126&action=edit Bug 29815: Pre-fill 952$d (Date acquired) when receiving serial items Test plan: 1. Create a subscription - Select the 'Create an item record when receiving this serial' 2. Receive the serial 3. After changing the status from 'Expected' to 'Arrived' notice that the 'd - Date acquired' is not set until you click on that field 4. Apply patch and restart services 5. Receive the serial again and notice this time today's date is pre-populated in 'd - Date acquired' Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Ready for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 129127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129127&action=edit Bug 29815: Pre-fill 952$d (Date acquired) when receiving serial items Test plan: 1. Create a subscription - Select the 'Create an item record when receiving this serial' 2. Receive the serial 3. After changing the status from 'Expected' to 'Arrived' notice that the 'd - Date acquired' is not set until you click on that field 4. Apply patch and restart services 5. Receive the serial again and notice this time today's date is pre-populated in 'd - Date acquired' Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129127|0 |1 is obsolete| | --- Comment #4 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- Created attachment 129204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129204&action=edit Bug 29815: Pre-fill 952$d (Date acquired) when receiving serial items Test plan: 1. Create a subscription - Select the 'Create an item record when receiving this serial' 2. Receive the serial 3. After changing the status from 'Expected' to 'Arrived' notice that the 'd - Date acquired' is not set until you click on that field 4. Apply patch and restart services 5. Receive the serial again and notice this time today's date is pre-populated in 'd - Date acquired' Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about this one as it changes the behavior of one item form making it inconsistent with the others in cataloguing and acq. Also, if you leave the date accessioned empty, it is automatically set to today's date without any interaction needed. It's here: https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/It... On the other hand that's not obvious to the user. Maybe we should change the behavior of the other forms as well? Add a hint? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 129237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129237&action=edit Bug 29815: Pre-populate 'Date acquired' field when adding/editing items This patch pre-fills the 952$d (Date acquired) item subfield on page load. Users can still click on the field to fill this subfield. Test plan: 1. Visit a biblio. Add an item, observe on page load the 'Date acquired' subfield is empty 2. Visit a subscription. Receive a serial, observe after setting the serial status to 'Arrived' the item form loads with an empty 'Date acquired' subfield 3. Apply patch and restart services 4. Repeat step 1 and confirm now on page load the 'Date acquired' subfield populates with today's date 5. Delete the populated 'Date acquired' subfield value. Click in the field and confirm the field is populated and the calendar input displays 6. Delete the 'Date acquired' subfield value again. Confirm that tabbing from a different field into the date acquired field behaves the same as click 7. Repeat step 2. This time confirm on page load the 'Date acquired' subfield contains the current date 8. Delete the populated 'Date acquired' subfield value. Click in the field and confirm it is populated 9. Delete the populated 'Date acquired' subfield value. Tab to the field from another field and confirm it behaves the same as click 10. Visit a biblio. Edit an item with a date acquired value in the past. Confirm the date acquired value is unchanged after saving. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Samu and Katrin, Thank you for your testing and QA. Katrin, I have gone with your suggestion of changing the other forms to work the same as the serial edit one. To do this I have edited the dateaccessioned plugin itself. I think this one is ready to test again now. Thanks! Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pre-populate 'Date |Pre-populate 'Date |acquired' field when |acquired' field when |receiving serial |adding/editing items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- This patchset still applies cleanly to master and is ready for testing if someone is available :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129237|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133221&action=edit Bug 29815: Pre-populate 'Date acquired' field when adding/editing items This patch pre-fills the 952$d (Date acquired) item subfield on page load. Users can still click on the field to fill this subfield. Test plan: 1. Visit a biblio. Add an item, observe on page load the 'Date acquired' subfield is empty 2. Visit a subscription. Receive a serial, observe after setting the serial status to 'Arrived' the item form loads with an empty 'Date acquired' subfield 3. Apply patch and restart services 4. Repeat step 1 and confirm now on page load the 'Date acquired' subfield populates with today's date 5. Delete the populated 'Date acquired' subfield value. Click in the field and confirm the field is populated and the calendar input displays 6. Delete the 'Date acquired' subfield value again. Confirm that tabbing from a different field into the date acquired field behaves the same as click 7. Repeat step 2. This time confirm on page load the 'Date acquired' subfield contains the current date 8. Delete the populated 'Date acquired' subfield value. Click in the field and confirm it is populated 9. Delete the populated 'Date acquired' subfield value. Tab to the field from another field and confirm it behaves the same as click 10. Visit a biblio. Edit an item with a date acquired value in the past. Confirm the date acquired value is unchanged after saving. Sponsored-By: Brimbank Library, Australia Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks for testing Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133221|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133343&action=edit Bug 29815: Pre-populate 'Date acquired' field when adding/editing items This patch pre-fills the 952$d (Date acquired) item subfield on page load. Users can still click on the field to fill this subfield. Test plan: 1. Visit a biblio. Add an item, observe on page load the 'Date acquired' subfield is empty 2. Visit a subscription. Receive a serial, observe after setting the serial status to 'Arrived' the item form loads with an empty 'Date acquired' subfield 3. Apply patch and restart services 4. Repeat step 1 and confirm now on page load the 'Date acquired' subfield populates with today's date 5. Delete the populated 'Date acquired' subfield value. Click in the field and confirm the field is populated and the calendar input displays 6. Delete the 'Date acquired' subfield value again. Confirm that tabbing from a different field into the date acquired field behaves the same as click 7. Repeat step 2. This time confirm on page load the 'Date acquired' subfield contains the current date 8. Delete the populated 'Date acquired' subfield value. Click in the field and confirm it is populated 9. Delete the populated 'Date acquired' subfield value. Tab to the field from another field and confirm it behaves the same as click 10. Visit a biblio. Edit an item with a date acquired value in the past. Confirm the date acquired value is unchanged after saving. Sponsored-By: Brimbank Library, Australia Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Makes sens. For a total free input, one must not use this value builder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27768 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29958 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27768 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thank you all for your testing and QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 [Bug 29963] date picker automatically fills todays date on cataloging screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #15 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Jumping in here regarding Bug 29963, but I think prepopulating date acquired when editing items is an undesirable behavior. It would need to be cleared more often than it would be useful. Makes sense when receiving serials or adding new items, but modification and batch modification it's just an annoyance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Benjamin Daeuber from comment #15)
Jumping in here regarding Bug 29963, but I think prepopulating date acquired when editing items is an undesirable behavior. It would need to be cleared more often than it would be useful. Makes sense when receiving serials or adding new items, but modification and batch modification it's just an annoyance.
How easy is it to have the plugin know in which context it works? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29963 Depends on|29963 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 [Bug 29963] date picker automatically fills todays date on cataloging screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #17 from Andrew Nugged <nugged@gmail.com> --- "Pre-populate 'Date acquired'" was the target, but not the plugin in general. So because of this it covers much more, and those extras are not expected nor desirable: 1. this code in the ticket prepopulates ANY field to which the plugin added. Wrong behavior. This plugin is not aimed to be ONLY for the 'Date acquired' field. 2. It also silenltly prepopulates the field in edit mode when it is expected to be empty by the wish of the librarian. 3. It also prepopulates fields for item batch edit form, which is even more undesired to be so. These ticket changes need to be reverted. Maybe re-thought for the solution needed later, but now it makes problems. For example, I released a quick patch for all productions which went to Koha 22.05 because of the above 3 bad effects. Later - this might be, but the more complicated solution, as Marcel de Rooy said: the plugin should be aware in which context it is executed, but even with this, this requires to be with some preferences at least: after checking on production libraries most said this is not their wish to have this autofill, they ok to press "..." (three dots on the right to call plugin's 'today date fill' feature). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think the original patch attached here is the better approach.. the one that changes PrepareItemForDisplay in C4::Items -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org