[Bug 40942] New: Vendor's contacts not displayed nicely on the vendor detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Bug ID: 40942 Summary: Vendor's contacts not displayed nicely on the vendor detail view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 38201 The table is too wide, or not positioned correctly. https://snipboard.io/eUNGQ1.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #1 from Michaela Sieber <michaela.sieber@kit.edu> --- I suggest to Change position of Ordering information with Contact. Then the contacts Table could have the full width of the screen And ordering information should be on top of the page because they are required, as contacts are optional. Then this would be the order of the sections: Details (left column) Order Ordering information (right column) Aliases (left column) Interfaces (right column) Contacts Contracts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk | |, | |caroline.cyr-la-rose@inlibr | |o.com, | |jonathan.field@openfifth.co | |.uk, | |katrin.fischer@bsz-bw.de, | |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188360&action=edit Bug 40942: Improve the display of vendor contracts Test plan: 1) Apply patch and yarn js:build 2) Navigate to a vendor and add some contacts 3) View the vendor record 4) The contacts table should now be at the bottom of the page and the full width of the screen 5) The Ordering information section should be at the top right of the screen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188367&action=edit Bug 40942: Account for the order of split panes in split screen view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188360|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188368&action=edit Bug 40942: Improve the display of vendor contracts Test plan: 1) Apply patch and yarn js:build 2) Navigate to a vendor and add some contacts 3) View the vendor record 4) The contacts table should now be at the bottom of the page and the full width of the screen 5) The Ordering information section should be at the top right of the screen Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188367|0 |1 is obsolete| | --- Comment #5 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188369&action=edit Bug 40942: Account for the order of split panes in split screen view Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188368|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 188663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188663&action=edit Bug 40942: Improve the display of vendor contracts Test plan: 1) Apply patch and yarn js:build 2) Navigate to a vendor and add some contacts 3) View the vendor record 4) The contacts table should now be at the bottom of the page and the full width of the screen 5) The Ordering information section should be at the top right of the screen Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188369|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 188664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188664&action=edit Bug 40942: Account for the order of split panes in split screen view Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- This broke VueFramework_spec.ts AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Contracts' within the element: <fieldset.rows> but never did. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189534&action=edit Bug 40942: Hide the 'Contacts' block if nothing to display If there is no contact we should hide the "Contacts" block on the "show" view. Fixes VueFramework_spec.ts AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Contracts' within the element: <fieldset.rows> but never did. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- I think this patch correctly fixes the failing test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- The display of contacts and contracts is inconsistent however: https://snipboard.io/47EDBj.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|additional_work_needed | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Bug 40942 depends on bug 38201, which changed state. Bug 38201 Summary: VueJS architecture rethink https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40942 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43121 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org