[Bug 26289] New: Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Bug ID: 26289 Summary: Deleting biblio in labeled MARC view doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl How to reproduce: 1) Create a new biblio with no items 2) Enable syspref viewLabeledMARC, 4) Go to Labeled MARC tab in biblio details page 5) Click Edit -> Delete record and notice nothing happens. Then check with developer tools the Javascript errors and notice "Uncaught ReferenceError: searchid is not defined" Expected result: deletion should work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109027&action=edit Bug 26289: Add missing variable definition to templates This patch adds definition of the missing "searchid" variable to three bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the ISBD view and the MARC view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109027|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109130&action=edit Bug 26289: Add missing variable definition to templates This patch puts definition of the missing "searchid" variable into an include file to be used by various bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the detail view, ISBD view, MARC view, and items view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109130|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 109187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109187&action=edit Bug 26289: Add missing variable definition to templates To test Apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. ------------ Worked perfectly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109187|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109190&action=edit Bug 26289: Add missing variable definition to templates This patch puts definition of the missing "searchid" variable into an include file to be used by various bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the detail view, ISBD view, MARC view, and items view. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt apply clean to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org