[Bug 30099] New: Error when accessing circulation.pl without patron parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Bug ID: 30099 Summary: Error when accessing circulation.pl without patron parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart+koha@gmail.com, kyle.m.hall@gmail.com Depends on: 29230 If I access circulation.pl directly, with no patron cardnumber or borrowernumber submitted, I get an error: Can't call method "messages" on an undefined value at /kohadevbox/koha/circ/circulation.pl line 525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 [Bug 29230] Patron's messages not accessible from template notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah bad, some librarians use this to on purpose to get out of patron circ page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 130571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130571&action=edit Bug 30099: Fix error when accessing circulation.pl without patron parameter If I access circulation.pl directly, with no patron cardnumber or borrowernumber submitted, I get an error: Can't call method "messages" on an undefined value at /kohadevbox/koha/circ/circulation.pl line 525 This is caused by Bug 29230 which calls $patron outside a "if ($aptron)". Test plan : 1) In staff interface, click in 'check out' search box 2) Hit enter (without a search text) => Without patch you get an error => With patch you see a blank page /cgi-bin/koha/circ/circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130571|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130573&action=edit Bug 30099: Fix error when accessing circulation.pl without patron parameter If I access circulation.pl directly, with no patron cardnumber or borrowernumber submitted, I get an error: Can't call method "messages" on an undefined value at /kohadevbox/koha/circ/circulation.pl line 525 This is caused by Bug 29230 which calls $patron outside a "if ($aptron)". Test plan : 1) In staff interface, click in 'check out' search box 2) Hit enter (without a search text) => Without patch you get an error => With patch you see a blank page /cgi-bin/koha/circ/circulation.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Current patch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130573|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130591&action=edit Bug 30099: Fix error when accessing circulation.pl without patron parameter If I access circulation.pl directly, with no patron cardnumber or borrowernumber submitted, I get an error: Can't call method "messages" on an undefined value at /kohadevbox/koha/circ/circulation.pl line 525 This is caused by Bug 29230 which calls $patron outside a "if ($aptron)". Test plan : 1) In staff interface, click in 'check out' search box 2) Hit enter (without a search text) => Without patch you get an error => With patch you see a blank page /cgi-bin/koha/circ/circulation.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org