[Bug 27940] New: KohaAdminEmailAddress is missing from OpacMaintenance page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Bug ID: 27940 Summary: KohaAdminEmailAddress is missing from OpacMaintenance page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator. "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. I think the problem is here: <p>The [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the <a href="mailto:[% KohaAdminEmailAddress | uri %]">site administrator</a></p> Specifically, [% KohaAdminEmailAddress | uri %] does not actually get the value from KohaAdminEmailAddress. Patch coming! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|KohaAdminEmailAddress is |Fix missing email in |missing from |OpacMaintenance page |OpacMaintenance page | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 118184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118184&action=edit Bug 27940 - Fix missing email in OpacMaintenance page To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: "Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator." "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. To test: - Apply the patch - Reload the maintenance page - Click on the "site administrator" link and verify it contains the address from KohaAdminEmailAddress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118184|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118337&action=edit Bug 27940: Fix missing email in OpacMaintenance page To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: "Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator." "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. To test: - Apply the patch - Reload the maintenance page - Click on the "site administrator" link and verify it contains the address from KohaAdminEmailAddress Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118337|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118812&action=edit Bug 27940: Fix missing email in OpacMaintenance page To reproduce: KohaAdminEmailAddress = Some valid email address OpacMaintenance = Show OPAC/cgi-bin/koha/maintenance.pl shows this text: "Koha online catalog is offline for system maintenance. We'll be back soon! If you have any questions, please contact the site administrator." "site administrator" is a link, but it only links to "mailto:", the actual email address from KohaAdminEmailAddress is missing. To test: - Apply the patch - Reload the maintenance page - Click on the "site administrator" link and verify it contains the address from KohaAdminEmailAddress Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd like to open a new bug here - could we agree to display the address from ReplytoDefault when set instead of KohaAdminEmailAdress? In some setups the KohaAdminEmailAdress nees to be set to noreply (same known issue as always with some mail servers being very strict about possible spam) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086 [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #7)
Good call Katrin.
I filed bug 28086 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | CC| |andrew@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes no email address release notes| |being shown on the OPAC | |maintenance page for "site | |administrator" link (when | |OpacMaintenance is set). | |Before this the link was | |showing as an empty | |"mailto:" instead of the | |value of | |KohaAdminEmailAddress CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org