http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 --- Comment #1 from Genevieve Plantin <genevieve.plantin@inlibro.com> --- Created attachment 42396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42396&action=edit CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42396|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 42460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42460&action=edit CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them Both patches tested together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42459|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 42461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42461&action=edit CAM 2146 - Bug 13781 - Fix missing heading columns for relative's checkouts table in check out patron page Theres was two missing heading columns Location and Fines in the Check out section of a Patron Tested both patches together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are also 2 other small things to keep an eye on next time: 1) Please start your commit messages with Bug xxxxx: - that will help our release scripts and other tools pick them up correctly. 2) Please be careful - Koha standardized to using 4 spaces and no tabs. The QA tool pointed out some issues there that I have fixed when reviewing your patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL forbidden patterns forbidden pattern: tab char (line 896) forbidden pattern: tab char (line 900) OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL forbidden patterns forbidden pattern: tab char (line 451) forbidden pattern: tab char (line 447) forbidden pattern: tab char (line 456) OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42460|0 |1 is obsolete| | Attachment #42461|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42501&action=edit [PASSED QA] Bug 13781: Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them Both patches tested together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for fixing this :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Summary|Relative's checkouts |Relative's checkouts table |tableis missing one column |is missing one column |heading |heading -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.