[Bug 24482] New: Purchase Items broken by costs containing a comma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Bug ID: 24482 Summary: Purchase Items broken by costs containing a comma Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To test: - enable cash registers and point of sale - create a purchase item with a cost of $1000 - go to Point of Sale and attempt to sell one of your item - Note that Koha inserts a comma into the price and breaks its own math in calculating the amount due -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice catch, I never tested with such a large figure I must admit. I'll start digging into it asap. Thanks for testing this feature so thoroughly Andrew, it's great to be catching these things before live release. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97983&action=edit Bug 24482: Fix for formatted price issue with value over 1000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan, see first comment of bug. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
Point of sale > click 'Add' next to the item to purchase)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97983|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 98058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98058&action=edit Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' - check that the change calculation is correct 11) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I identified two other possible issues testing this bug: 1. If you press enter in the 'Collected from patron' field it adds the first item listed under the 'Items for purchase' section to 'This sale'. 2. If the amount you enter in 'Collected from patron' is less than the total amount owed and you press confirm it is accepted. For a cash payment maybe there should be a warning or error, or not let the transaction be accepted or completed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98058|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98107&action=edit Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home > Point of sale > click 'Add' next to the item to purchase) 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' check that the change calculation is correct. 11) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for testing, and that's a wonderfully detailed test plan, thankyou! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #5)
I identified two other possible issues testing this bug:
1. If you press enter in the 'Collected from patron' field it adds the first item listed under the 'Items for purchase' section to 'This sale'.
Oh, weird.. I'll open a new bug for that.
2. If the amount you enter in 'Collected from patron' is less than the total amount owed and you press confirm it is accepted. For a cash payment maybe there should be a warning or error, or not let the transaction be accepted or completed.
I'll be submitting a fix for this one in bug 24519 ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 24540 opened for the weird enter behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98107|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98582&action=edit Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home > Point of sale > click 'Add' next to the item to purchase) 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' check that the change calculation is correct. 11) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- not pushed to 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org