[Bug 28108] New: LetterLog/Acquistions/Claims: Logging filters are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Bug ID: 28108 Summary: LetterLog/Acquistions/Claims: Logging filters are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org We stripped out the fix for claims/acquisitions/letter logging filtering from bug 14233. I'll attach a copy of the code here for prosperity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 [Bug 14233] Add logging support to notices and slips management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119295&action=edit Bug 28108: Fix filtering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #2 from David Nind <david@davidnind.com> --- For the history of this bug see comments 34 (item 6), 46, 89, 90, 91, 92, 93 and 94 from bug 14233 for the details. My notes from the comments: - The module name Letters in Tools > Logs was confusing after logging of notices was added in bug 14233. - The name of the module in Tools > Logs was changed from 'Letter' to 'Claims', as this reflects what is being logged: it was intended to log acquisition claims emails. - The preference name for enabling logging was changed from LetterLog to ClaimsLog. - The filters were updated so it shows log entries for 'CLAIMS', as it was discovered that there was a bug and it was actually showing logs for the Acquisitions module, so was not really showing what was intended "..actually logs aquisitions related notices being sent.. mostly 'Claims'". Draft test plan: 1. Before applying the patch . Enable LetterLog system preference . Generate log entries for claims letters in acquisitions [not sure how to do this - https://koha-community.org/manual/20.11/en/html/acquisitions.html#claims-and...] . Notice that log entries are not showing for letters 2. Apply the patch 3. Update the database: databaseupdate 4. With just the Claims module selected in the log viewer it should now show the expected log entries [may need to perform actions to generate the required log entries] 5. Run tests, these should pass: . prove t/db_dependent/Letters.t . prove t/db_dependent/UsageStats.t 6. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #3 from David Nind <david@davidnind.com> --- Hope I got this mostly right!Feel free to correct.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119295|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 119548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119548&action=edit Bug 28108: Fix filtering Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Thanks David ! The patch works fine for both superadmin and staff user with 'view_system_logs' permission. As a tiny precision for the test plan, the patch renames the 'LetterLog' syspref to 'ClaimsLog', so you have to activate it before claiming orders and then search the logs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer@bsz-bw.de |martin.renvoize@ptfs-europe | |.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kelly@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do we have something better to suggest or do we go with "Claims" as a "module" for action logs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #7 from David Nind <david@davidnind.com> --- If claims is a subset of the acquisitions module, then how about "Acquisitions - Claims"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (bug 23971 is adding AcquisitionLog) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #7)
If claims is a subset of the acquisitions module, then how about "Acquisitions - Claims"?
This is actually not only about acq claims - it also covers serial issue claims and acq orders: WHERE module = 'ACQUISITIONS' AND ( action = 'SERIAL CLAIM' OR action = 'ACQUISITION ORDER' OR action = 'ACQUISITION CLAIM') Ultimately, that's a bit of a weird mix, especially since orders are not claims... we might want to split them up at some point. But let's fix this bug first :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119548|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120747&action=edit Bug 28108: Fix filtering Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120748&action=edit Bug 28108: (QA follow-up) Make the system preference description more precise There has been some confusion on what the pref really covers, so I hope this helps to resolve. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120749&action=edit Bug 28108: (QA follow-up) Add actions to log viewer The following actions were missing from the template, so the code showed instead of a translatable description: * ACQUISITION CLAIM * ACQUISITION ORDER * SERIAL ORDER -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120763&action=edit Bug 28108: Replace one remaining occurrence -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why do we move 'ACQUISITION ORDER' to claims? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #14)
Why do we move 'ACQUISITION ORDER' to claims?
I think it's already been there since we introduced the message to SendAlerts - so it's not actually a change in behaviour. I noted it in my comments - I think moving it out again would be good for a separate enhancement bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120781&action=edit Bug 28108: (QA follow-up) Move 'ORDER' back into 'ACQUITISIONS' With the re-introduction of 'AQUISITIONS' as a logging module in Koha, it makes sence to move the ORDER notice logging back into that module whilst leaving the other 'CLAIMS' notices under their own logging module code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120781|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120782&action=edit Bug 28108: (QA follow-up) Move 'ORDER' back into 'ACQUITISIONS' With the re-introduction of 'AQUISITIONS' as a logging module in Koha, it makes sence to move the ORDER notice logging back into that module whilst leaving the other 'CLAIMS' notices under their own logging module code. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Severity|normal |enhancement Summary|LetterLog/Acquistions/Claim |Move action logs 'SERIAL |s: Logging filters are |CLAIM' and 'ACQUISITION |broken |CLAIM' to a new 'CLAIMS' | |module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120791&action=edit Bug 28108: (QA follow-up) Fix syspref text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement changes release notes| |the logging system | |preferences and the log | |viewer tool so that: | | | |- | |ClaimsLog: logs when an | |acquisitions claim or a | |serials claim notice is | |sent (Claims module in the | |log viewer) | |- | |AcquisitionLog: logs all | |other changes for | |acquisition actions | |(Acquisitions module in the | |log viewer). | | | |Previously | |ClaimsLog was called | |LettersLog, but the name | |was considered confusing | |after support for logging | |changes to notices and | |slips was added in Koha | |21.05 (bug 14233). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Bug 28108 depends on bug 14233, which changed state. Bug 14233 Summary: Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36389 [Bug 36389] Acquisition order logging does not depend on AcquisitionLog system preference -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org