[Bug 5477] New: Test cases requiring database access fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 Summary: Test cases requiring database access fail Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Test Suite AssignedTo: gmcharlt@gmail.com ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 In the 3.2.1 release there are a number of test cases that fail because they 'use' modules that immediately attempt to access the database. As most machines won't have MySQL set up to contain the user/password and database required, these fail. My suggestions for fixing this are: * Move these tests into a 'db_dependent' directory so that they aren't run by default. Perhaps add a 'make test_all' rule that includes them. * Have the packages move the iffy ones out of the way (although they will still fail for anyone running 'make test' without the database set up.) * Introduce an environment variable that is set during testing that tells C4::Context (or whatever it is making the DB connection) that failures are OK. This may reduce test coverage however, which we don't want. The tests I've noticed with this problem are: 00-load.t External_BakerTaylor.t Reports_Guided.t Service.t Tags.t UploadedFile.t VirtualShelves_Page.t -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |robin@catalyst.net.nz --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2010-12-08 05:58:13 UTC --- I plan to make a patch that solves this the first way, until a better idea comes along. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2010-12-09 01:07:12 UTC --- Created attachment 2821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2821 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-04 10:25:14 UTC --- This bug is mentioned in: Bug 5477 - Fix test cases that require database access http://lists.koha-community.org/pipermail/koha-patches/2010-December/013209.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u Version|rel_3_2 |rel_3_4 Patch Status|Needs Signoff |Signed Off Severity|normal |major --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-01-28 19:06:49 UTC --- More tests which fail in this manner: t/Auth.t t/Auth_with_cas.t t/BackgroundJob.t t/Record.t t/Serials.t I'm fixing-up and signing off on the Robin's original patch. I'm also changing this to 3.4 and will backport the fix when pushed there. Note: There is already a Serials test in the db_dependent subdir, so I'm renaming Serials.t to Serials_2.t and moving it there as well. The two tests should probably be combined at some point. Also changing severity to major as this is causing a lot of noise from people worried about failed tests. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed Resolution| |FIXED --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-29 18:54:34 UTC --- Pushed, works locally and hudson confirms, marking resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5477 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> 2011-02-08 00:27:39 UTC --- In order to build the 3.2.3 packages, I cherry picked the commit from master across on top of the v3.02.03 tag, and it worked fine. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org