https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- My observations from testing. General: - General alignment: . in the old form, text seems centre aligned (label, text after the input field) . in the updated form it looks aligned to the top, with possibly some unintended effects . Examples: . Edit the patron attribute type code for SHOW_BCODE . All the 'Required' elements after the input bix - Colour of the text for input fields: in the old forms it was black, in the new ones it is a lighter grey, reducing the colour contrast (haven't checked in a colour contrast checker) Patron categories: - Enrollment period input fields x2: previously right aligned with input boxes, maybe more room should be allowed so can be on the same line (in English anyway), now with "weird" indentation - Block expired patron OPAC actions: dropdown list and tick bocks misaligned Patron attribute type: - Labels from 'Repeatable' to 'Display in patron's brief information' are to the right of the tick box, with the tick boxes aligned under the input field for 'Description' - looks really weird -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Felicie <felicie.thiery@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicie.thiery@biblibre.com --- Comment #4 from Felicie <felicie.thiery@biblibre.com> --- Hi, the patch apply failed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- The patch applied okay for me using git-bz in KTD, but I've re-attached it for luck. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu --- Comment #8 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I tested this in a sandbox and overall things look good! There are a couple of small tweaks I think it still needs before a sign off. In Patron Categories: - In "Block expired patron OPAC actions" there is still the issue of the checkboxes obscuring the first letter of the text that follows as David had noted. The box literally sits over the text, regardless of any window resizing. - The explanatory texts for the entries from "Checkout charge limit" through the bottom of the page seem to prematurely word-wrap. This might be because these elements have shorter boxes? But the text could definitely run further to the right and take up fewer lines if that is technically possible. - In the New Category form there is a piece of explanatory text missing. Pre-patch the following text was visible above "Self-renewal failure message": "Information to be displayed to the patron at the start of the renewal process. This will be displayed as a Yes/No question and you can add multiple questions - an answer of 'Yes' proceeds to the next question, 'No' exits the process and displays the Self-renewal failure message." This text is missing after patch. I think the text actually goes with the "Self-renewal information message" field that is present in the Edit form but not in the pre- or post-patch New form? In that case I'm okay with removing the text from the updated New form. But it seems odd this field isn't on the New form in the first place! In Patron Attribute Types: - The "Library limitation" text has changed from "Limits the use of this attribute to the selected libraries." pre-patch to "Select "All libraries" if this attribute type should always be displayed. Otherwise select libraries you want to associate with this value." post-patch. I see that this is the language in the screenshot in the manual so there is precedent in some version, but there is no "All libraries" option in the dropdown. Also, I think a dropdown arrow would be helpful for this box. For box text and dropdown arrow (whatever is decided), this should match the Library limitation box in Patron Categories. In Patron Restriction Types: - This is outside the new and edit forms, but I notice the restrictions table grid (restrictions.pl) has lost the arrows for sorting on column post-patch. I like where things have ended with the Patron attribute check box layout (check box next to bold text label above plain text descriptions). I find this really easy to read and use and prefer it to the original. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Gretchen Maxeiner from comment #8)

- In the New Category form there is a piece of explanatory text missing.

This is bug 42810

- This is outside the new and edit forms, but I notice the restrictions table grid (restrictions.pl) has lost the arrows for sorting on column post-patch.

I don't see this problem! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 --- Comment #11 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I have attached a screenshot from the sandbox if this helps -- in addition to the sort arrows on the columns, it is also missing the standard table navigation, such as how many entries to show, search, and export. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200187&action=edit Bug 41841: Update some patron admin templates to use grid layout for forms This patch updates patron-related administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Patron categories - Test the "Clear" and "New" links next to the "Self-renewal information message" input. - Patron attribute types - Patron restriction types Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203192&action=edit Bug 41841: Update some patron admin templates to use grid layout for forms This patch updates patron-related administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Patron categories - Test the "Clear" and "New" links next to the "Self-renewal information message" input. - Patron attribute types - Patron restriction types Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203204&action=edit Bug 41841: Update some patron admin templates to use grid layout for forms This patch updates patron-related administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Patron categories - Test the "Clear" and "New" links next to the "Self-renewal information message" input. - Patron attribute types - Patron restriction types Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.