[Bug 22696] New: Simplify visibility opac-ISBD.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug ID: 22696 Summary: Simplify visibility opac-ISBD.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Take advantage of bug 22694 to simplify the logic in it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify visibility |Simplify visibility |opac-ISBD.pl |opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify visibility |Simplify visibility logic |opac-ISBDdetail.pl |in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22700 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 87932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87932&action=edit Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl This patch removes many DB queries and uses state-of-the-art Koha code to accomplish the same things it did before. To test: - Apply this patch - Open opac-ISBDdetail.pl for a known record => SUCCESS: No behaviour change. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87932|0 |1 is obsolete| | --- Comment #2 from Bin <bin.wen@inlibro.com> --- Created attachment 87938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87938&action=edit Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl This patch removes many DB queries and uses state-of-the-art Koha code to accomplish the same things it did before. To test: - Apply this patch - Open opac-ISBDdetail.pl for a known record => SUCCESS: No behaviour change. - Sign off :-D Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bin.wen@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88356&action=edit Bug 22696: (follow-up) Use new relationship for prefetching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701 [Bug 22701] Make items prefetchable from Koha::Biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88376&action=edit Bug 22696: Prefetch items too Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87938|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88515&action=edit Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl This patch removes many DB queries and uses state-of-the-art Koha code to accomplish the same things it did before. To test: - Apply this patch - Open opac-ISBDdetail.pl for a known record => SUCCESS: No behaviour change. - Sign off :-D Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88356|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88516&action=edit Bug 22696: (follow-up) Use new relationship for prefetching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88376|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88517&action=edit Bug 22696: Prefetch items too Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice simplification of the logic, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug 22696 depends on bug 22700, which changed state. Bug 22700 Summary: Make biblio_metadata prefetchable from Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug 22696 depends on bug 22694, which changed state. Bug 22694 Summary: Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug 22696 depends on bug 22701, which changed state. Bug 22701 Summary: Make items prefetchable from Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225 [Bug 23225] OPAC ISBD view returns 404 when no item attached -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-*detail.pl [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23247 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 [Bug 26223] The OPAC ISBD view does not display item information -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org