https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16389 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50978&action=edit Bug 16389: Reports row limit should change upon option selection To test: 1) Run a report 2) Confirm there is no 'Update' button next to the 'Rows per page:' dropdown 3) Change the limit (i.e. to 10) 4) Confirm the page updates itself Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16389 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50978|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 50991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50991&action=edit Bug 16389: Reports row limit should change upon option selection To test: 1) Run a report 2) Confirm there is no 'Update' button next to the 'Rows per page:' dropdown 3) Change the limit (i.e. to 10) 4) Confirm the page updates itself Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, The patch works as advertise, but I would prefer to see more descriptive/useful name for the ids. For instance, the id on the select is not needed. I'd say we could change the jQuery selector instead to $('select.limit'). On the same way, we could search for the form using the parents() selector, but I think it's better to select the form by id. But 'limitselect' is not a correct description for the form element. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50991|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51021&action=edit Bug 16389: Reports row limit should change upon option selection To test: 1) Run a report 2) Confirm there is no 'Update' button next to the 'Rows per page:' dropdown 3) Change the limit (i.e. to 10) 4) Confirm the page updates itself Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16389 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release! Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.