http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard@myacpl.org |bgkriegel@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27927|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30270&action=edit Bug 12176 - Remove HTML from additem.pl This patch removes HTML code from additem.pl To test: 1. Chech no regressions on Add/Edit/Save items 2. Update translation files for a language, check new string "Tag editor" on staff PO file 3. Check it pass xt/tt_valid.t Rebased -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30270|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30975&action=edit Bug 12176 - Remove HTML from additem.pl This patch removes HTML code from additem.pl To test: 1. Chech no regressions on Add/Edit/Save items 2. Update translation files for a language, check new string "Tag editor" on staff PO file 3. Check it pass xt/tt_valid.t Rebased Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Depends on| |11944 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #4)

When the description contains a diacritic, the option is empty.

Marked as Failed QA.

Right, it's true, encoding problems. But this is one of the problems fixed by Bug 11944. Tested on top of that and it works :) Can you test it that way? I'm adding 11944 as a dependency. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30975|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31138&action=edit Bug 12176 - Remove HTML from additem.pl This patch removes HTML code from additem.pl To test: 1. Chech no regressions on Add/Edit/Save items 2. Update translation files for a language, check new string "Tag editor" on staff PO file 3. Check it pass xt/tt_valid.t Rebased Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan, thanks for pointing this out. I have reverted this patch, and will push it when the UTF-8 work hits master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13239 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13239 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Make sure that bug 7673 is not regressed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39303|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39345&action=edit Bug 12176: [QA Follow-up] Small additem adjustments Adjusting a few small things and making qa tools happy: [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) [2] A closer look revealed that mv.avalue is useless too. An input element does not contain any content. Putting it after the hidden element in a non-visible context has no meaning. [3] Change handling of select attributes readonly and disabled. [4] Remove unused variable $attributes_no_value_textarea [5] Removed a comment with TODO referring to this report. [6] Moving a duplicated TT variable (mv.javascript) outside IF statement. [7] And finally could not resist this one: Moving strings Tag editor and No popup from script to template. Plugins++ NOTE: Most item plugins redirect click to focus. In that case there is no popup, but unfortunately the text Tag editor comes up. When you remove or rename function Click, No popup comes up. So it works. Sorry that this small list kept growing :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39347&action=edit Bug 12176: [QA Follow-up] Small additem adjustments Adjusting a few small things and making qa tools happy: [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) [2] A closer look revealed that mv.avalue is useless too. An input element does not contain any content. Putting it after the hidden element in a non-visible context has no meaning. [3] Change handling of select attributes readonly and disabled. [4] Remove unused variable $attributes_no_value_textarea [5] Removed a comment with TODO referring to this report. [6] Moving a duplicated TT variable (mv.javascript) outside IF statement. [7] And finally could not resist this one: Moving strings Tag editor and No popup from script to template. Plugins++ NOTE: Most item plugins redirect click to focus. In that case there is no popup, but unfortunately the text Tag editor comes up. When you remove or rename function Click, No popup comes up. So it works. Sorry that this small list kept growing :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39348&action=edit Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour While cleaning up, still found this super tiny string typo :) Yes, Tag Editor should now be Tag editor. Test plan :) Git grep on Tag editor and Tag Editor Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Bernardo Gonzalez Kriegel from comment #22)

...

[3] Change handling of select attributes readonly and disabled.

I was worried about this, since i think select can't have readonly attribute, only disabled. But if disabled, it's content is not sent back to GET/POST, so perhaps a hidden attribute with same name and old value is needed. Or may be now select can have readonly, but then we need to remove disabled. I left both to not change old behavior

Seems good to me. I recall seeing some code in the template that removes the disabled status when submitting the form .. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #24)

On editing an item, I get

Form not submitted because of the following problem(s) ----------------------------------------------------------------------------- -------

- 4 mandatory fields empty (highlighted)

Which is wrong, my 4 mandatory fields are filled.

Good catch. I see that something else is wrong not related to mandatory fields but indirectly causing this issue.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39442&action=edit Bug 12176: Fix for missing field_value in select As Jonathan Druart discovered, we were still missing an important attribute in the selects. Var mv.name was not filled, so the name was empty with nice side-effects :) While fixing this, it was also possible to delete some unused vars that Bernardo already mentioned before: $attributes and $attributes_no_value. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39347|0 |1 is obsolete| | --- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39450&action=edit Bug 12176: [QA Follow-up] Small additem adjustments Adjusting a few small things and making qa tools happy: [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) [2] A closer look revealed that mv.avalue is useless too. An input element does not contain any content. Putting it after the hidden element in a non-visible context has no meaning. [3] Change handling of select attributes readonly and disabled. [4] Remove unused variable $attributes_no_value_textarea [5] Removed a comment with TODO referring to this report. [6] Moving a duplicated TT variable (mv.javascript) outside IF statement. [7] And finally could not resist this one: Moving strings Tag editor and No popup from script to template. Plugins++ NOTE: Most item plugins redirect click to focus. In that case there is no popup, but unfortunately the text Tag editor comes up. When you remove or rename function Click, No popup comes up. So it works. Sorry that this small list kept growing :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39442|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39452&action=edit [SIGNED-OFF] Bug 12176: Fix for missing field_value in select As Jonathan Druart discovered, we were still missing an important attribute in the selects. Var mv.name was not filled, so the name was empty with nice side-effects :) While fixing this, it was also possible to delete some unused vars that Bernardo already mentioned before: $attributes and $attributes_no_value. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> For me the simptom was different, when saving an edited item fields were mangled beyond repear :( No alert for empty mandatory fields. But this last patch fix the problem. Tested add/edit items Cleaner pl file :) No errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry but I have found something else. Before this patch, the item line which is currently edited was highlighted in yellow. After this patch, it does not anymore. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #33)

(In reply to Jonathan Druart from comment #32)

...

Sorry but I have found something else. Before this patch, the item line which is currently edited was highlighted in yellow. After this patch, it does not anymore.

Jonathan: I also remember the yellow line. But when I am testing in current clean master now, I do not see it anymore ! I am looking where it is triggered in the template/js ?

Found somethings else. See bug 14267. But it seems that we did not have a yellow background in the input field. Note that the item currently edited is still yellow in the table. Checked on older version too. Please provide a screen shot from current master to convince me if I am not correct. Back to Signed off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39503&action=edit Edit item highlight yellow -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #37)

And I confirm that it does not work with this patch set.

Hey, it works... half of the time :) Only highlights even items, odd ones remains un-highligthed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #37)

And I confirm that it does not work with this patch set.

I have the strong impression that it "does not work" without this patch set too :) It only works on the even items. So imo this should not interfere with this report. But let me add a small followup for changing behavior (it should go on another report). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #41)

Created attachment 39513 [details] [review] Highlight

Would this resolve your highlight problem, Jonathan? No clean patch btw.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39513|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39516&action=edit [SIGNED-OFF] Bug 12176: Highlight edited item http://bugs.koha-community.org/show_bug.cgi?id=12176 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Now edited item is correctly highlighted No errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39346|0 |1 is obsolete| | Attachment #39450|0 |1 is obsolete| | Attachment #39451|0 |1 is obsolete| | Attachment #39452|0 |1 is obsolete| | Attachment #39516|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39517&action=edit Bug 12176: Remove HTML from additem.pl This patch removes HTML code from additem.pl. To test: 1. Check no regressions on Add/Edit/Save items 2. Update translation files for a language, check new strings "Tag editor" & "No popup" on staff PO file 3. Check it passes xt/tt_valid.t Patch partially rebased, part rewritten. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39519&action=edit Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour While cleaning up, still found this super tiny string typo :) Yes, Tag Editor should now be Tag editor. Test plan :) Git grep on Tag editor and Tag Editor Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marcel de Rooy from comment #40)

(In reply to Jonathan Druart from comment #37)

...

And I confirm that it does not work with this patch set.

I have the strong impression that it "does not work" without this patch set too :) It only works on the even items. So imo this should not interfere with this report. But let me add a small followup for changing behavior (it should go on another report).

Yes you are right, it does not work as expected on master. So let's move it to its own bug report. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #50 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bug 12176 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.