[Bug 6460] New: No log generated if Action set to All or Modify or Delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Bug #: 6460 Summary: No log generated if Action set to All or Modify or Delete Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Transaction logs AssignedTo: paul.poulain@biblibre.com ReportedBy: januszop@gmail.com QAContact: koha-bugs@lists.koha-community.org In "Browse system logs" dialogue, if Action is set to All or Modify or Delete, no logs are generated, despite of other settings. This is due to modifications introduced to sub C4::GetLogs and to tools::viewlog by the patch to Bug 6014. 1) Actions are logged as MODIFY, DELETE etc., whereas template viewlog.t* uses mod, del and passes it to viewlog.pl. That is why, consequently, wildcards (%) was used in GetLogs for action (prior to patch 6014). This has to be restored. 2) Also, @action is, after changes made by 6014, a one element list, even if the first and only element is an empty string ("") for All (actions). That is why, in GetLogs, one has to check if the first element of the list is not "" instead of checking the length of the list (which is always 1). A patch will follow. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |januszop@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> 2011-06-04 23:21:23 UTC --- Created attachment 4359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4359 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> 2011-06-04 23:26:24 UTC --- BTW, the patch applies to 3.2.9 too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-06-15 11:01:16 UTC --- Before applying the patch, no results are shown when Action is set to All, Modify or Delete in Tools > Log Viewer. After applying the patch results are shown for all of the Actions, including the ones mentioned above. Signing off! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4359|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@enger.priv.no> 2011-06-15 11:01:59 UTC --- Created attachment 4478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4478 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-11 10:36:30 UTC --- QA comment I think this patch should be rejected: the diagnostic is correct (Actions are logged as MODIFY, DELETE etc., whereas template viewlog.t* uses mod, del and passes it to viewlog.pl) so, why not fix the template to pass MODIFY, DELETE,... It would be a better solution than using LIKE. Also note that your patch prevent to change the select to have a "MULTIPLE", that would be a handy feature. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-09-22 20:22:46 UTC --- Created attachment 5546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5546 Bug 6460: alternative fix, updating template and script instead of C4::Log - a bit rushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@ttllp.co.uk Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6911 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5546|0 |1 is obsolete| | --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-09-23 11:22:14 UTC --- Created attachment 5560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5560 Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #8 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-09-23 16:01:29 UTC --- (In reply to comment #7)
Created attachment 5560 [details] Bug 6460: alternative fix, updating template and script instead of C4::Log
Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer.
And fixing that bug also seems to have fixed the fix. Please hold off for now while I recode it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5560|0 |1 is obsolete| | --- Comment #9 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-09-23 16:29:39 UTC --- Created attachment 5569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5569 Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 --- Comment #10 from Liz Rea <wizzyrea@gmail.com> 2011-09-23 17:25:34 UTC --- Created attachment 5570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5570 [Signed Off] Bug 6460: alternative fix, updating template and script instead of C4::Log Add some test cases and fix a bug in C4::Log found by in review. Thanks-to: Katrin Fischer. Signed-off-by: Liz Rea <lrea@nekls.org> Passes test, interface works as expected. Signed-off-by: Liz Rea <lrea@nekls.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5569|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4478|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Needs Signoff |Passed QA --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-23 17:33:14 UTC --- Changes template instead of script. Also adds a test case, which is double-plus good. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-23 22:03:22 UTC --- Pushed, I agree, bonus points for the test case -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org