[Bug 31987] New: Update plugin unimarc_field_110.pl fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Bug ID: 31987 Summary: Update plugin unimarc_field_110.pl fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Actually some fields are missing in plugin unimarc_field_110 it could be great to update it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 142669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142669&action=edit Bug 31987: Update plugin unimarc_field_110 fields According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf Test plan: 1) Be sure to manage unimarc 110 field in your bibliographic framework 2) Edit a record and click on plugin unimarc_110_field input to see new select values Current status: NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142669|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142698&action=edit Bug 31987: Update plugin unimarc_field_110 fields According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf Test plan: 1) Be sure to manage unimarc 110 field in your bibliographic framework 2) Edit a record and click on plugin unimarc_110_field input to see new select values Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to fill in the Assignee! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Thibaud, please make sure to run the QA tools on your patches and to set your editor to use 4 spaces for indentation instead of tabs: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_110.tt FAIL forbidden patterns forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 45) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 53) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 59) forbidden pattern: tab char (line 60) forbidden pattern: tab char (line 62) forbidden pattern: tab char (line 63) forbidden pattern: tab char (line 64) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 67) forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 69) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 72) forbidden pattern: tab char (line 73) forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 75) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 79) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 184) forbidden pattern: tab char (line 185) forbidden pattern: tab char (line 186) forbidden pattern: tab char (line 187) Will fix in a follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142698|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143029&action=edit Bug 31987: Update plugin unimarc_field_110 fields According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf Test plan: 1) Be sure to manage unimarc 110 field in your bibliographic framework 2) Edit a record and click on plugin unimarc_110_field input to see new select values Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143030&action=edit Bug 31987: (QA follow-up) Fix indentation and remove trailing spaces Fix tabs for 4 spaces in file. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 --- Comment #7 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Hi Thibaud,
please make sure to run the QA tools on your patches and to set your editor to use 4 spaces for indentation instead of tabs:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/ unimarc_field_110.tt FAIL forbidden patterns forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 45) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 53) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 59) forbidden pattern: tab char (line 60) forbidden pattern: tab char (line 62) forbidden pattern: tab char (line 63) forbidden pattern: tab char (line 64) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 67) forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 69) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 72) forbidden pattern: tab char (line 73) forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 75) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 79) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 184) forbidden pattern: tab char (line 185) forbidden pattern: tab char (line 186) forbidden pattern: tab char (line 187)
Will fix in a follow-up!
Oh sorry, it's my bad I forgot it... thanks to you and I will remember next time :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org