[Bug 21529] New: Print notices no longer outputs html notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Bug ID: 21529 Summary: Print notices no longer outputs html notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: stefan.berndtsson@ub.gu.se QA Contact: testopia@bugs.koha-community.org When a print notice letter (for example HOLD) is marked as "HTML message" it is expected for gather_print_notices.pl (with --html) to accept the message content and not escape the html. Since Bug 13618 this is no longer true. batch/print-notices.tt explicitly adds "| html" before inserting the content regardless of the "HTML message" flag. circ/printslip.tt on the other hand, checks the flag and escapes only if plain output is used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80992&action=edit Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21679 CC| |andrew.isherwood@ptfs-europ | |e.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21679 [Bug 21679] Software error when placing a hold on an item with a charge associated with it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I'm trying to sign this one off, but after I apply the patch I receive the following error when running gather_print_notices.pl: Template process failed: undef error - : filter not found at /home/koha/kohaclone/C4/Templates.pm line 122. I'm mystified as to what could be causing it since I can't see anything wrong with your patch. Any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81503&action=edit Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80992|0 |1 is obsolete| | --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81505&action=edit Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81503|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81545&action=edit Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81505|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81546&action=edit Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81545|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81885&action=edit Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81546|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81886&action=edit Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Nick, You are holding this patch for some reason. Perhaps because of the suggested dependency on bug 21679. Please check that: I do not see why they are dependent. Am I missing something ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Depends on|21679 | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the dependency is false - I've remove it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21679 [Bug 21679] Software error when placing a hold on an item with a charge associated with it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Print notices no longer |Fix display of HTML tags in |outputs html notices |print notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Bug 21529 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05 for 18.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lucas Gass from comment #12)
backported to 18.05 for 18.05.07
Why? Did you see the bug on 18.05? Bug 13618 is not in this version so I do not think the bug exists (I did not check). Jenkins is complaining about that one anyway: koha_1 | # Failed test '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt' koha_1 | # at xt/author/valid-templates.t line 141. koha_1 | # plugin error - raw: plugin not found Patch using the raw plugin ([% var | $raw %]) should not be backported as the plugin does not exist in 18.05 (which you may want to consider at some point). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- reverted from 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org