[Bug 44097] New: Patron search "starting with" and "containing" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Bug ID: 44097 Summary: Patron search "starting with" and "containing" untranslatable Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, f.demians@tamil.fr, jonathan.druart@gmail.com, julian.maurice@biblibre.com Target Milestone: --- When you do a patron search that returns more than one result, there is a h3 with "Patrons found for: Standard starting with 'term'". Can also be "... containing 'term'" The "starting with" or "containing" is not translatable. To recreate: 1. Add a language to your Koha (sorry if the commands are not the correct ones, I never remember from one time to another) koha-translate --install fr-CA --dev kohadev And activate the language in system preferences 2. Change the language of the interface 3. Go to Patrons (Utilisateur) 4. Make a search for 'mar' for example --> "starting with" is not translated "Utilisateurs trouvés pour : Standard starting with 'mar'" 5. Check the .po files cd misc/translator/po git grep "starting with" fr-CA* --> There is an unrelated one in messages.po (and many unrelated ones in pref.po) and a commented one in staff-prog.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 211546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211546&action=edit Bug 44097: Patron search "starting with" and "containing" untranslatable In the patron search results heading, the phrases "starting with" and "containing" were not translatable. This patch makes them translatable. To test: Before applying the patch 1. Add a language to your Koha (sorry if the commands are not the correct ones, I never remember from one time to another) koha-translate --install fr-CA --dev kohadev And activate the language in system preferences 2. Change the language of the interface 3. Go to Patrons (Utilisateur) 4. Make a search for 'mar' for example --> "starting with" is not translated "Utilisateurs trouvés pour : Standard starting with 'mar'" 5. Check the .po files cd misc/translator/po git grep "starting with" fr-CA* --> There is an unrelated one in messages.po (and many unrelated ones in pref.po) and a commented one in staff-prog.po 6. APPLY PATCH 7. Update the translation strings gulp po:update --lang fr-CA 8. Search the .po files for the strings cd misc/translator/po git grep "starting with" fr-CA* git grep "containing" fr-CA* --> They both should now be in staff-prog.po uncommented with the %s around them 9. Translate the strings, make sure to remove the fuzzy line 10. Apply the new strings ktd --root --shell koha-translate --update fr-CA --dev kohadev 11. Redo steps 3-4 --> Strings should be translated!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 211583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211583&action=edit Bug 44097: Patron search "starting with" and "containing" untranslatable In the patron search results heading, the phrases "starting with" and "containing" were not translatable. This patch makes them translatable. To test: Before applying the patch 1. Add a language to your Koha (sorry if the commands are not the correct ones, I never remember from one time to another) koha-translate --install fr-CA --dev kohadev And activate the language in system preferences 2. Change the language of the interface 3. Go to Patrons (Utilisateur) 4. Make a search for 'mar' for example --> "starting with" is not translated "Utilisateurs trouvés pour : Standard starting with 'mar'" 5. Check the .po files cd misc/translator/po git grep "starting with" fr-CA* --> There is an unrelated one in messages.po (and many unrelated ones in pref.po) and a commented one in staff-prog.po 6. APPLY PATCH 7. Update the translation strings gulp po:update --lang fr-CA 8. Search the .po files for the strings cd misc/translator/po git grep "starting with" fr-CA* git grep "containing" fr-CA* --> They both should now be in staff-prog.po uncommented with the %s around them 9. Translate the strings, make sure to remove the fuzzy line 10. Apply the new strings ktd --root --shell koha-translate --update fr-CA --dev kohadev 11. Redo steps 3-4 --> Strings should be translated!! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. This is the end result after updating the translation and removing the fuzzy line (in fr-CA-staff-prog.po): 14776 #. SCRIPT 14777 #: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:377 14778 msgid "%s containing '%s'" 14779 msgstr "%s contient '%s'" 14780 14781 #. SCRIPT 14782 #: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:377 14783 msgid "%s starting with '%s'" 14784 msgstr "%s commence par '%s'" 2. Note: If I didn't add the %s and '%s' in the translations (msgstr), I got this warning: koha-translate --update fr-CA --dev kohadev tmpl_process3.pl: Warning: inconsistent %s count: (2/0): line: 14776 msgid: "%s containing '%s'" msgstr: "contient " tmpl_process3.pl: Warning: inconsistent %s count: (2/0): line: 14781 msgid: "%s starting with '%s'" msgstr: "commence par " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44108 [Bug 44108] Ensure no new incorrect format calls will be pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 211611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211611&action=edit Bug 44097: Patron search "starting with" and "containing" untranslatable In the patron search results heading, the phrases "starting with" and "containing" were not translatable. This patch makes them translatable. To test: Before applying the patch 1. Add a language to your Koha (sorry if the commands are not the correct ones, I never remember from one time to another) koha-translate --install fr-CA --dev kohadev And activate the language in system preferences 2. Change the language of the interface 3. Go to Patrons (Utilisateur) 4. Make a search for 'mar' for example --> "starting with" is not translated "Utilisateurs trouvés pour : Standard starting with 'mar'" 5. Check the .po files cd misc/translator/po git grep "starting with" fr-CA* --> There is an unrelated one in messages.po (and many unrelated ones in pref.po) and a commented one in staff-prog.po 6. APPLY PATCH 7. Update the translation strings gulp po:update --lang fr-CA 8. Search the .po files for the strings cd misc/translator/po git grep "starting with" fr-CA* git grep "containing" fr-CA* --> They both should now be in staff-prog.po uncommented with the %s around them 9. Translate the strings, make sure to remove the fuzzy line 10. Apply the new strings ktd --root --shell koha-translate --update fr-CA --dev kohadev 11. Redo steps 3-4 --> Strings should be translated!! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44097 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org