[Bug 25777] New: Datatables on z3950_search.pl show incorrect number of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Bug ID: 25777 Summary: Datatables on z3950_search.pl show incorrect number of entries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Datatables on z3950_search.pl will say "Showing 1 to 20 of 20 entries", which makes you think that there are only 20 search results. However, if you scroll to the bottom of the page, you'll often see it saying something like "Showing page 1 of 501". We should hide the "Showing 1 to 20 of 20 entries" datatables information if we're not going to implement a JSON sourced table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 105933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105933&action=edit Bug 25777: Disable misleading datatables table information display z3950 This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search for "test" against Library of Congress 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Apply the patch and restart Plack 5) Repeat Step #2 6) Note the bottom of the page now only says "Showing page 1 of 501" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should be fixed on other Z3950 search pages as well. I would also remove the search box as it only filter on the first page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #2)
Should be fixed on other Z3950 search pages as well.
I would also remove the search box as it only filter on the first page.
Mmm I was wondering about that. Fixed this one a bit too hastily. I'll re-visit it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liav@wgc.school.nz Assignee|dcook@prosentient.com.au |liav@wgc.school.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Ava, did you mean to take over as Assignee? (I hope you will as I haven't had time for this one.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #5 from Ava <liav@wgc.school.nz> --- (In reply to David Cook from comment #4)
Ava, did you mean to take over as Assignee?
(I hope you will as I haven't had time for this one.)
Yes I did! I was planning on working on it yesterday but I think the Library of Congress was down. If it's up today I will work on it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105933|0 |1 is obsolete| | --- Comment #6 from Ava <liav@wgc.school.nz> --- Created attachment 115626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115626&action=edit Bug 25777: Disable misleading datatables table information display z3950 This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search for "test" against Library of Congress 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Apply the patch and restart Plack 5) Repeat Step #2 6) Note the bottom of the page now only says "Showing page 1 of 501" 7) Note the search bar is gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115626|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115787&action=edit Bug 25777: Disable misleading datatables table information display z3950 This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search for "test" against Library of Congress 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Apply the patch and restart Plack 5) Repeat Step #2 6) Note the bottom of the page now only says "Showing page 1 of 501" 7) Note the search bar is gone Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115788&action=edit Bug 25777: (follow-up) Make the same configuration change to Z39.50 search in Acquisitions To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From external source. Perform a Z39.50 search and check that the DataTable of results doesn't have a search filter or number of results information at the top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115787|0 |1 is obsolete| | Attachment #115788|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116269&action=edit Bug 25777: Disable misleading datatables table information display z3950 This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search for "test" against Library of Congress 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Apply the patch and restart Plack 5) Repeat Step #2 6) Note the bottom of the page now only says "Showing page 1 of 501" 7) Note the search bar is gone Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116270&action=edit Bug 25777: (follow-up) Make the same configuration change to Z39.50 search in Acquisitions To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From external source. Perform a Z39.50 search and check that the DataTable of results doesn't have a search filter or number of results information at the top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116269|0 |1 is obsolete| | --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 116306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116306&action=edit Bug 25777: Disable misleading datatables table information display z3950 This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search for "test" against Library of Congress 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Apply the patch and restart Plack 5) Repeat Step #2 6) Note the bottom of the page now only says "Showing page 1 of 501" 7) Note the search bar is gone Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116270|0 |1 is obsolete| | --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 116307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116307&action=edit Bug 25777: (follow-up) Make the same configuration change to Z39.50 search in Acquisitions To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From external source. Perform a Z39.50 search and check that the DataTable of results doesn't have a search filter or number of results information at the top. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from David Cook <dcook@prosentient.com.au> --- 2020 lasted so long that I forgot that I wrote that first patch... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep -E "bPaginate.*true" koha-tmpl/intranet-tmpl/lib/datatables/datatables.js: "bPaginate": true, koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt: "bPaginate" : true, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - "bPaginate": false + "bPaginate": false, - "bPaginate": false + "paginate": false, Two very small patches. But not the same ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not sure if this is a bug btw or just reading the documentation or so ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|liav@wgc.school.nz |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116391&action=edit Bug 25777: (QA follow-up) Correct option: paging The correct upgrade from the old "bPaginate" option is "paging" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for asking again, but should not both spots be changed to use "paging" now? +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt @@ -246,7 +246,9 @@ { "aTargets": [ 1 ], "sType": "nsb-nse" }, ], "aaSorting": [[ 1, "asc" ]], - "bPaginate": false + "bPaginate": false, + "searching": false, + "bInfo":false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #18)
Sorry for asking again, but should not both spots be changed to use "paging" now?
Both are valid at this time. This may change later in a future DataTables upgrade. I chose to change it in my patch because I was touching that part of the template anyway. Without an established rule that these options should be updated I don't think it should be a QA failure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #19)
Without an established rule that these options should be updated I don't think it should be a QA failure.
When patches of even two lines are inconsistent.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - "bPaginate": false + "paging": false, + "searching": false, + "info":false - "bPaginate": false + "bPaginate": false, + "searching": false, + "bInfo":false Come on, what are we doing here? Please squash and be consistent :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116306|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117367&action=edit Bug 25777: Disable misleading datatables table information display z3950 This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search from cataloguing for "test" against Library of Congress. 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Do a Z39.50 search from Acquisitions for "test" against Library of Congress (Acquisitions -> Vendor -> Basket -> Add to basket -> From external source). 5) Apply the patch and restart Plack 6) Repeat Step #2 7) Note the bottom of the page now only says "Showing page 1 of 501" 8) Note the search bar is gone 9) Repeat step #4 10) Note the bottom of the page now only says "Showing page 1 of 501" 11) Note the search bar is gone Squashed and mixed authorship added below Co-authored-by: Owen Leonard <oleonard@myacpl.org> Co-authored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #116391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patches squashed, syntax updated to be consistent between the two files, QA scripts passing, tests passing, manual testing proves it works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in| | CC| |andrew@bywatersolutions.com --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org