[Bug 7848] New: Issues data missing from circulation notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Priority: P5 - low Change sponsored?: --- Bug ID: 7848 Assignee: henridamien@koha-fr.org Summary: Issues data missing from circulation notices QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Notices Product: Koha For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8694&action=edit Bug 7848 - Issues data missing from circulation notices For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. This is caused not passing in the issues table as part of the 'table' hash used by C4::Letters::GetPreparedLetter. Simple fix, add the issues table to the 'tables' hash passed in to GetPreparedLetter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien@koha-fr.org |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, this is marked 3.6 - is this patch only relevant for 3.6 or also for master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested this on current master and see some problems in the generated messages. My CHECKOUT notice looks like this: ------------------------------------------------------------------- Die folgenden Medien wurden entliehen: <<biblio.title>> <<issues.date_due>> Vielen Dank für Ihren Besuch in <<branches.branchname>>. ------------------------------------------------------------------- The output after checking out 2 items is: ------------------------------------------------------------------- Die folgenden Medien wurden entliehen: Die Kultur der Gegenwart 2012-04-15 23:59:00 Vielen Dank für Ihren Besuch in Midway.Die folgenden Medien wurden entliehen: Die Kultur der Gegenwart 2012-04-15 23:59:00 Vielen Dank für Ihren Besuch in Midway. ------------------------------------------------------------------- Note: This is one message, for 2 different items of the same title. Part of the message gets repeated - I think this should not happen and I am not sure why it does. My CHECKIN notice looks like this: ------------------------------------------------------------------- Die folgenden Medien wurden zurückgegeben: ---- <<biblio.title>> <<issues.itemnumber>><<issues.date_due>> ---- Vielen Dank. ------------------------------------------------------------------- Checking in the same items as before, gives me following output: ------------------------------------------------------------------- Die folgenden Medien wurden zurückgegeben: Die Kultur der Gegenwart Die Kultur der Gegenwart Vielen Dank. ------------------------------------------------------------------- Note: This time the list is ok, as no other parts of the message are repeated, but the information from the issues table does not show up. I think instead of the issues table or in addition to it we should make the items table available, so that barcode and callnumber can be added to the notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8694|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8778&action=edit Bug 7848 - Issues data missing from circulation notices For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. This is caused not passing in the issues table as part of the 'table' hash used by C4::Letters::GetPreparedLetter. Simple fix, add the issues and items tables to the 'tables' hash passed in to GetPreparedLetter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #4) It may be that you have your repetition lines in the wrong places. For example, take this notice: The following items have been checked out: ---- <<biblio.title>> DUE ON: <<issues.date_due>> ---- Thank you for visiting <<branches.branchname>>. Anything between the dashes will be repeated. I should also not that repetition in various notices is done in different ways. Some notices use tags like <items>Repeated Content</items> instead. This should really be standardized throughout the notice system. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, thx for this hint! I didn't know about the 'repetition lines' and I agree that it would be nice to standardize the syntax for repeating parts of the notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea@gmail.com --- Comment #7 from Liz Rea <wizzyrea@gmail.com> --- I confirm Katrin's issue with the checkin notice - the data from the issues table does not appear in the generated notices. Failing QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8778|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9704&action=edit Bug 7848 - Issues data missing from circulation notices For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. For CHECKOUT, this is caused not passing in the issues table as part of the 'table' hash used by C4::Letters::GetPreparedLetter. For CHECKIN notices, we need the old_issues table instead, as the item has already been returned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9704|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9863&action=edit [Signed Off] Bug 7848 - Issues data missing from circulation notices For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. For CHECKOUT, this is caused not passing in the issues table as part of the 'table' hash used by C4::Letters::GetPreparedLetter. For CHECKIN notices, we need the old_issues table instead, as the item has already been returned. Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes tests, correct information shows in notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Unconditional WARNs need to be removed. Once that's done, this can do to Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9863|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10599&action=edit Bug 7848 - Issues data missing from circulation notices For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. For CHECKOUT, this is caused not passing in the issues table as part of the 'table' hash used by C4::Letters::GetPreparedLetter. For CHECKIN notices, we need the old_issues table instead, as the item has already been returned. Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes tests, correct information shows in notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * Ian comment 10 (conditional warn) fixed * C4 files modified did not pass perlcritic before, they still don't (most of the errors are ["return" statement with explicit "undef" ...] and [Subroutine prototypes used] * No other comment, code integrates smoothly with existing code passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Seems to work well, pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- If this is intended to apply to 3.6.x, please provide a patch rebased against 3.6-testing. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org