[Bug 26908] New: EDI vendor accounts edit no longer allows plugins to be selected for an account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Bug ID: 26908 Summary: EDI vendor accounts edit no longer allows plugins to be selected for an account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I believe the removal of the syspref caused the plugins pulldown to no longer show on the edi vendor accounts editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112919&action=edit Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112919|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112969&action=edit Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes - step 1: 1. Download one of the EDI plugins from https://github.com/bywatersolutions/koha-plugin-edifact-enhanced/releases (it doesn't matter which one). 2. Install the plugin (Koha administration > Plugins > Manage plugins > Upload plugin > browse for the plugin you downloaded in step 1 > click upload - the plugin will then show in the list of plugins). Note: Plugins need to be enabled for your development environment - make sure your plugin directory is set (KTD = <pluginsdir>/var/lib/koha/kohadev/plugins</pluginsdir>) and it is enabled (<enable_plugins>1</enable_plugins>) in the koha-conf.xml file for your instance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I feel like instead of introducing a further call to set plugins_enabled and passing it to the template we should just check for the presence of the 'plugins' variable directly in the template instead. Thoughts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112969|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113096&action=edit Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113097&action=edit Bug 26908: (follow-up) Alter template check This alters the template check to use the presence of the plugins arrayref rather than requiring a second call to check for plugins_enabled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor tidy up followup added.. Works well, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I'm sure this depends on something but I don't know what. What syspref was removed? Is this needed for 19.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if it's needed, but the pref was UsePlugins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20415 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks Katrin, I believe this probably depends on Bug 20415 then, so this patch isn't needed in 19.11.x. Not backported Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 [Bug 20415] Remove UseKohaPlugins system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Bug 26908 depends on bug 20415, which changed state. Bug 20415 Summary: Remove UseKohaPlugins system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org