[Bug 17715] New: Remove itemtype-related t/db_dependent/Holds/ RevertWaitingStatus.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Bug ID: 17715 Summary: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57937&action=edit Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57937|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 57940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57940&action=edit [SIGNED-OFF] Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57940|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57959&action=edit Bug 17715: Remove itemtype-related t/db_dependent/Holds/RevertWaitingStatus.t warnings This patch makes t/db_dependent/Holds/RevertWaitingStatus.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Holds/RevertWaitingStatus.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Holds/RevertWaitingStatus.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17715 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org