[Bug 24322] New: National Library of Medicine (NLM) call number to XSLT Detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Bug ID: 24322 Summary: National Library of Medicine (NLM) call number to XSLT Detail Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: olli-antti.kivilahti@hypernova.fi QA Contact: testopia@bugs.koha-community.org NLM is missing from OPAC/Intra XSLTDetail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |olli-antti.kivilahti@hypern | |ova.fi --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- Created attachment 96701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96701&action=edit Bug 24322 - National Library of Medicine (NLM) call number to XSLT Detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala@helsinki.fi --- Comment #2 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Please include a test plan for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Also, format the commit title with "Bug 24322: XXX" instead of "Bug 24322 - XXX" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also spotted a small thing, it should have its own class: + <span class="results_summary ddc"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96701|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- Created attachment 96973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96973&action=edit Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail Thank you Joonas and Katrin for your excellent discoveries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- You didn't add the test plan still – you really should because 1) you will likely get more people signing off this because they don't need to delve into the code to check what this thing does and what is the feature (though a bit more verbose commit message would help also with this) 2) it gives a baseline for what things to test and others can do in addition other types of testing than what is just mentioned in the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- TEST PLAN: 1. Find a bib record 2. Add MARC21 field 060 3. Show the bib via the bib detail page (detail.pl) 4. Observe the field 060 as NLM next to the other call numbers for this bib. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #8 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Tried to test this on the Bywater Solutions sandboxes but despite it appearing to apply the patch I can't see any NLM output in the Normal view on cgi-bin/koha/catalogue/detail.pl after making a new dummy MARC record and adding a 060 field. This is even though can see LOC and DDC output (050 and 082) in the same output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Patch no longer applies: Applying: Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl). error: could not build fake ancestor Patch failed at 0001 Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24322-National-Library-of-Medicine-NLM-call-nu-kgmgi2.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Jon Knight from comment #8)
Tried to test this on the Bywater Solutions sandboxes but despite it appearing to apply the patch I can't see any NLM output in the Normal view on cgi-bin/koha/catalogue/detail.pl after making a new dummy MARC record and adding a 060 field. This is even though can see LOC and DDC output (050 and 082) in the same output.
Hi Jon. That would be because the patch wasn't actually applied. The way to tell it hasn't applied in ByWater's sandboxes: 1) Go to Logs > Koha Git log. The commit for the patch(es) with the bug number you are testing should show at the top of the page, e.g. Bug 24322: National.... 2) Create a sandbox without putting a bug number in the 'Bug number' field. You will then get the current master branch for Koha. Then go to Actions > Apply patches. It will then show you what it has done and that the patch failed. Have to admit that it's not very obvious to identify that the patch didn't apply! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96973|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110025&action=edit Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail This adds MARC21 060 - National Library of Medicine Call Number https://www.loc.gov/marc/bibliographic/bd060.html To test: - Catalog records using the 060, examples can be found in the LOC documentation. - Verify that the field displays on the detail pages in staff and OPAC Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> RRescued this patch by redoing the changes. Only change made was moving the section up before "Other classification". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110025|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 110096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110096&action=edit Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail This adds MARC21 060 - National Library of Medicine Call Number https://www.loc.gov/marc/bibliographic/bd060.html To test: - Catalog records using the 060, examples can be found in the LOC documentation. - Verify that the field displays on the detail pages in staff and OPAC Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> RRescued this patch by redoing the changes. Only change made was moving the section up before "Other classification". Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Taking the chance to count myself as QA here after David's sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110982&action=edit Bug 24322: Simplify condition to separate elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org