[Bug 11315] New: Add support for subfield deletion when doing authority merges.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Bug ID: 11315 Summary: Add support for subfield deletion when doing authority merges. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org Created attachment 23201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23201&action=edit Add the overwriteSubfieldsOnMerge preference. This patch adds the "overwriteSubfieldsOnMerge" preference. If it is activated, all of the biblio's subfields will be overwritten when doing an authority merge. This means that subfields that exist in the biblio, but not in the authority will be deleted in the biblio when doing the merge. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Frédérick, Why don't you check the pref overwriteSubfieldsOnMerge value in the merge routine? Could you provide a test plan please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #2 from Frédérick Capovilla <fcapovilla@live.ca> --- I checked in our codebase, and we have a special merge script which needs to forces the $overwrite parameter to 1 to do its job correctly. I guess this is why the check wasn't done in the merge routine. I agree there is room for improvement. We could do the pref check in the merge routine and allow a parameter which could overrides the system pref. Test plan : Preparation : * Create a test authority. For example, lets create a PERSON authority with this value : 100$a : "Bruce Wayne" * Rebuild the Zebra authority index. (rebuild_zebra.pl -a) * Create a new biblio record and link it to the newly created authority by clicking the icon right of the 600$a field and searching for the "Bruce Wayne" authority. * Add the "2014" value in the 600$d field of the biblio record before saving the biblio record. This is the value we will use to check the behavior of the new system preference. * Rebuild the Zebra biblio index. (rebuild_zebra.pl -b) Test 1 : * Set the "overwriteSubfieldsOnMerge" system preference to "Don't overwrite". * Edit the "Bruce Wayne" authority, change 100$a value to "Batman". * Save the authority and go check the test biblio record. The 600$a field should now be "Batman", and the 600$d should still be "2014". Test 2 : * Set the "overwriteSubfieldsOnMerge" system preference to "Overwrite". * Edit the "Batman" authority, change the 100$a value back to "Bruce Wayne". * Save the authority and go check the test biblio record. The 600$a field should now be "Bruce Wayne", and the 600$d should now be empty. The additional subfield was overwritten this time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23201|0 |1 is obsolete| | --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25377&action=edit New version of the patch adding the overwriteSubfieldsOnMerge preference. Here is a new version which checks for the preference in the merge subroutine. Also : For the test case to work, you need to also set the "dontmerge" system preference to "Do automatically update attached biblios...". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25377|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25404&action=edit Bug 11315 : Add the overwriteSubfieldsOnMerge preference. If it is activated, all of the biblio's subfields will be overwritten when doing an authority merge. This means that subfields that exist in the biblio, but not in the authority will be deleted in the biblio when doing the merge. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Test plan : Preparation : * Set dontmerge system preference to "Do automatically update attached biblios..." * Create a test authority. For example, lets create a PERSON authority with this value : 100$a : "Bruce Wayne" * Rebuild the Zebra authority index. (rebuild_zebra.pl -a) * Create a new biblio record and link it to the newly created authority by clicking the icon right of the 600$a field and searching for the "Bruce Wayne" authority. * Add the "2014" value in the 600$d field of the biblio record before saving the biblio record. This is the value we will use to check the behavior of the new system preference. * Rebuild the Zebra biblio index. (rebuild_zebra.pl -b) Test 1 : * Set the "overwriteSubfieldsOnMerge" system preference to "Don't overwrite". * Edit the "Bruce Wayne" authority, change 100$a value to "Batman". * Save the authority and go check the test biblio record. The 600$a field should now be "Batman", and the 600$d should still be "2014". Test 2 : * Set the "overwriteSubfieldsOnMerge" system preference to "Overwrite". * Edit the "Batman" authority, change the 100$a value back to "Bruce Wayne". * Save the authority and go check the test biblio record. The 600$a field should now be "Bruce Wayne", and the 600$d should now be empty. The additional subfield was overwritten this time. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |fcapovilla@live.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frederick, can you please provide unit tests? It also looks like the database update is not correct - it's using the wrong version check and the update message is missing the beginning and the bug number. Could you please provide a follow up? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #6 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30940&action=edit Bug 11315 - Fixed issues in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #7 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30941&action=edit Bug 11315 - Added unit tests for the modified sub in AuthoritiesMarc.pm new file: t/AuthoritiesMarc.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu@inlibro.com Assignee|fcapovilla@live.ca |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Ahmed Sfayhi <ahmed.sfayhi@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmed.sfayhi@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Looks like it is close to the purpose of Bug 5572 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14583 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15358 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 [Bug 15358] merge.pl does not populate values to merge -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org