[Bug 26158] New: Z3950 search button broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Bug ID: 26158 Summary: Z3950 search button broken for translations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 23885 This is similar to bug 23713 var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %]0[% END %]; become, once translated: var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %][% END %]; and a JS error appears in the console Uncaught SyntaxError: expected expression, got ';' search.pl:636:29 Caused by commit ef4306cc02e2f15aa2466ae65d0b4f9a1fd70ad9 Bug 23885: Move staff client search results JavaScript into separate file Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 [Bug 23885] Move staff client search results JavaScript into separate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107876&action=edit Bug 26158: Fix Z3950 search button broken for translations This is similar to bug 23713 var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %]0[% END %]; become, once translated: var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %][% END %]; and a JS error appears in the console Uncaught SyntaxError: expected expression, got ';' search.pl:636:29 Caused by commit ef4306cc02e2f15aa2466ae65d0b4f9a1fd70ad9 Bug 23885: Move staff client search results JavaScript into separate file Test plan: Use the staff interface in a translated language Search for a term that won't return any results Click the Z3950 button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107876|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107878&action=edit Bug 26158: Fix Z3950 search button broken for translations This is similar to bug 23713 var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %]0[% END %]; become, once translated: var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %][% END %]; and a JS error appears in the console Uncaught SyntaxError: expected expression, got ';' search.pl:636:29 Caused by commit ef4306cc02e2f15aa2466ae65d0b4f9a1fd70ad9 Bug 23885: Move staff client search results JavaScript into separate file Test plan: Use the staff interface in a translated language Search for a term that won't return any results Click the Z3950 button Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107878|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 107898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107898&action=edit Bug 26158: Fix Z3950 search button broken for translations This is similar to bug 23713 var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %]0[% END %]; become, once translated: var SEARCH_RESULTS = [% IF (SEARCH_RESULTS) %]1[% ELSE %][% END %]; and a JS error appears in the console Uncaught SyntaxError: expected expression, got ';' search.pl:636:29 Caused by commit ef4306cc02e2f15aa2466ae65d0b4f9a1fd70ad9 Bug 23885: Move staff client search results JavaScript into separate file Test plan: Use the staff interface in a translated language Search for a term that won't return any results Click the Z3950 button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org