[Bug 37901] New: Pseudonymized_transactions should include ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Bug ID: 37901 Summary: Pseudonymized_transactions should include ILL requests Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: andrew.auld@ptfs-europe.com, katrin.fischer@bsz-bw.de, magnus@libriotech.no, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com The pseudonymization process aims to duplicate the transactional circulation data from the statistics table in a way that does not allow borrowers to be identified. The statistics table also includes entries for payments and writeoffs that contain the borrowernumber of the impacted patron. We should also record ILL requests in pseudonymized_transactions when pseudonymization is enabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk, | |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 22513 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178356&action=edit Bug 37901: Add ILL pseudonymization 1) Apply patches 2) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 3) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 4) Enable ILLModule and Pseudonymization system preferences 5) Create an ILL request 6) Confirm the pseudonymized_transaction has been added: $ koha-mysql kohadev $ select * from pseudonymized_transactions; 7) Further testing with more data: Check all options from PseudonymizationPatronFields and PseudonymizationTransactionFields and repeat steps 5) and 6). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pseudonymized_transactions |Add ILL pseudonymization |should include ILL requests | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178956&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178957&action=edit Bug 37901: Preparation: db changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178958&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178959&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178960&action=edit Bug 37901: Preparation: Update tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178961&action=edit Bug 37901: Add 'illrequest_id' column to statistics -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178962&action=edit Bug 37901: [DONT PUSH] dbic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178963&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178964&action=edit Bug 37901: Consider illrequest_id when creating When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178965&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'ill_request' as an allowed type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178966&action=edit Bug 37901: UpdateStats when new ILL request is created -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178967&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178968&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --- Test plan: 1) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 2) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 3) Enable ILLModule and Pseudonymization system preferences 4) Check 'Keep for pseudonymization' at the only existing patron attribute type: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Save. Edit that attribute type for 'koha' patron: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 6) Scroll down, set a value for 'Show barcode on the summary screen items listings:'. Save. 7) Do a checkout for that 'koha' patron. 8) Confirm the pseudonymized_transaction has been added alongside its metadata (SHOW_BCODE), run report #3 from the examples listed above. This concludes the 'preparation' side of testing, ensuring that borrower_attributes are kept for pseudonymization 9) Create a new ILL request of type 'book'. 10) Run the report from 8) again. Verify the ILL pseudonymized transaction and its related pseudonymized metadata is there. Run tests: prove t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t prove t/db_dependent/Koha/PseudonymizedTransaction.t prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178959|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178961|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178963|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178967|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178968|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178980&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178981&action=edit Bug 37901: Preparation: db changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178982&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178983&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178984&action=edit Bug 37901: Preparation: Update tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178985&action=edit Bug 37901: Add 'illrequest_id' column to statistics -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178986&action=edit Bug 37901: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178987&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178988&action=edit Bug 37901: Consider illrequest_id when creating When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178989&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'ill_request' as an allowed type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178990&action=edit Bug 37901: UpdateStats after new ILL request is created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178991&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178992&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --- Test plan: 1) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 2) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 3) Enable ILLModule and Pseudonymization system preferences 4) Check 'Keep for pseudonymization' at the only existing patron attribute type: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Save. Edit that attribute type for 'koha' patron: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 6) Scroll down, set a value for 'Show barcode on the summary screen items listings:'. Save. 7) Do a checkout for that 'koha' patron. 8) Confirm the pseudonymized_transaction has been added alongside its metadata (SHOW_BCODE), run report #3 from the examples listed above. This concludes the 'preparation' side of testing, ensuring that borrower_attributes are kept for pseudonymization 9) Create a new ILL request of type 'book'. 10) Run the report from 8) again. Verify the ILL pseudonymized transaction and its related pseudonymized metadata is there. Run tests: prove t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t prove t/db_dependent/Koha/PseudonymizedTransaction.t prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #29 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Pedro, Is the test missing a step between 9 and 10? I created the ILL request for patron 42 and I still only have one entry (the one for the checkout) in the result for the report. Was I supposed to do something other than simply create the request? Also, the name of the file in step 1 is koha-conf.xml, not koha.conf.xml, if you want to correct it in the test plan. Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 [Bug 39652] Pseudonymized_borrower_attributes causes subsequent pseudonymized_transactions to not be added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178980|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181008&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178981|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181009&action=edit Bug 37901: Preparation: db changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178982|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181010&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178983|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181011&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178984|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181012&action=edit Bug 37901: Preparation: Update tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178985|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181013&action=edit Bug 37901: Add 'illrequest_id' column to statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178986|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181014&action=edit Bug 37901: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178987|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181015&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181016&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178989|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181017&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #40 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181018&action=edit Bug 37901: UpdateStats after new ILL request is created or completed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178991|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181019&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178992|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181020&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --- Test plan: 1) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 2) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 3) Enable ILLModule and Pseudonymization system preferences 4) Check 'Keep for pseudonymization' at the only existing patron attribute type: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Save. Edit that attribute type for 'koha' patron: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 6) Scroll down, set a value for 'Show barcode on the summary screen items listings:'. Save. 7) Do a checkout for that 'koha' patron. 8) Confirm the pseudonymized_transaction has been added alongside its metadata (SHOW_BCODE), run report #3 from the examples listed above. This concludes the 'preparation' side of testing, ensuring that borrower_attributes are kept for pseudonymization 9) Create a new ILL request of type 'book'. 10) Run the report from 8) again. Verify the ILL pseudonymized transaction and its related pseudonymized metadata is there. 11) Go back to that ILL request and click 'Confirm request'. After that click 'Mark completed'. 12) Repeat 10) Run tests: prove t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t prove t/db_dependent/Koha/PseudonymizedTransaction.t prove t/db_dependent/Koha/Pseudonymization.t Sponsored-by: UKHSA - UK Health Security Agency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181008|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181696&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181009|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181697&action=edit Bug 37901: Preparation: db changes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181010|0 |1 is obsolete| | --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181698&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181011|0 |1 is obsolete| | --- Comment #46 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181699&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181012|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181700&action=edit Bug 37901: Preparation: Update tests Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181013|0 |1 is obsolete| | --- Comment #48 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181701&action=edit Bug 37901: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181014|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181702&action=edit Bug 37901: [DONT PUSH] dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181015|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181703&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181016|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181704&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181017|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181705&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181018|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181706&action=edit Bug 37901: UpdateStats after new ILL request is created or completed Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181019|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181707&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181020|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181708&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --ILL specific pseudonymized transactions report-- SELECT pt.hashed_borrowernumber as 'borrower',pt.transaction_type as 'Transaction type', pt.datetime as 'Datetime', pt.branchcode as 'Patron branchcode', pt.categorycode as 'Patron category', (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt Sponsored-by: UKHSA - UK Health Security Agency Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181696|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184709&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181697|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184710&action=edit Bug 37901: Preparation: db changes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181698|0 |1 is obsolete| | --- Comment #58 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184711&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181699|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184712&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181700|0 |1 is obsolete| | --- Comment #60 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184713&action=edit Bug 37901: Preparation: Update tests Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181701|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184714&action=edit Bug 37901: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181702|0 |1 is obsolete| | --- Comment #62 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184715&action=edit Bug 37901: [DONT PUSH] dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181703|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184716&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181704|0 |1 is obsolete| | --- Comment #64 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184717&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181705|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184718&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181706|0 |1 is obsolete| | --- Comment #66 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184719&action=edit Bug 37901: UpdateStats after new ILL request is created or completed Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181707|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184720&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181708|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184721&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --ILL specific pseudonymized transactions report-- SELECT pt.hashed_borrowernumber as 'borrower',pt.transaction_type as 'Transaction type', pt.datetime as 'Datetime', pt.branchcode as 'Patron branchcode', pt.categorycode as 'Patron category', (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt Sponsored-by: UKHSA - UK Health Security Agency Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #69 from Lisette Scheer <lisette@bywatersolutions.com> --- Patch doesn't apply, but even with rebase: [SKIP] Koha/Schema/Result/PseudonymizedTransaction.pm SKIP pod_coverage No POD exists [SKIP] Koha/Schema/Result/Statistic.pm SKIP pod_coverage No POD exists Needs POD coverage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #70 from Lisette Scheer <lisette@bywatersolutions.com> --- It did work great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184709|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185495&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184710|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185496&action=edit Bug 37901: Preparation: db changes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184711|0 |1 is obsolete| | --- Comment #73 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185497&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184712|0 |1 is obsolete| | --- Comment #74 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185498&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184713|0 |1 is obsolete| | --- Comment #75 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185499&action=edit Bug 37901: Preparation: Update tests Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184714|0 |1 is obsolete| | --- Comment #76 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185500&action=edit Bug 37901: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184715|0 |1 is obsolete| | --- Comment #77 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185501&action=edit Bug 37901: [DONT PUSH] dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184716|0 |1 is obsolete| | --- Comment #78 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185502&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184717|0 |1 is obsolete| | --- Comment #79 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185503&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184718|0 |1 is obsolete| | --- Comment #80 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185504&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184719|0 |1 is obsolete| | --- Comment #81 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185505&action=edit Bug 37901: UpdateStats after new ILL request is created or completed Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184720|0 |1 is obsolete| | --- Comment #82 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185506&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184721|0 |1 is obsolete| | --- Comment #83 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185507&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --ILL specific pseudonymized transactions report-- SELECT pt.hashed_borrowernumber as 'borrower',pt.transaction_type as 'Transaction type', pt.datetime as 'Datetime', pt.branchcode as 'Patron branchcode', pt.categorycode as 'Patron category', (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt Sponsored-by: UKHSA - UK Health Security Agency Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #84 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Lisette Scheer from comment #69)
Patch doesn't apply, but even with rebase:
[SKIP] Koha/Schema/Result/PseudonymizedTransaction.pm SKIP pod_coverage No POD exists [SKIP] Koha/Schema/Result/Statistic.pm SKIP pod_coverage No POD exists
Needs POD coverage
Thank you Lisette, I've rebased the patches. I believe this 'Needs POD coverage' is a false positive that comes up every time for new Schema files and are safe to ignore though I'm happy to be corrected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185495|0 |1 is obsolete| | --- Comment #85 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185544&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic Worked great. You're correct that you don't need the POD coverage. Thanks! Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185496|0 |1 is obsolete| | --- Comment #86 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185545&action=edit Bug 37901: Preparation: db changes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185497|0 |1 is obsolete| | --- Comment #87 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185546&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185498|0 |1 is obsolete| | --- Comment #88 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185547&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185499|0 |1 is obsolete| | --- Comment #89 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185548&action=edit Bug 37901: Preparation: Update tests Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185500|0 |1 is obsolete| | --- Comment #90 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185549&action=edit Bug 37901: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185501|0 |1 is obsolete| | --- Comment #91 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185550&action=edit Bug 37901: [DONT PUSH] dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185502|0 |1 is obsolete| | --- Comment #92 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185551&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185503|0 |1 is obsolete| | --- Comment #93 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185552&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185504|0 |1 is obsolete| | --- Comment #94 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185553&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185505|0 |1 is obsolete| | --- Comment #95 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185554&action=edit Bug 37901: UpdateStats after new ILL request is created or completed Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185506|0 |1 is obsolete| | --- Comment #96 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185555&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185507|0 |1 is obsolete| | --- Comment #97 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185556&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --ILL specific pseudonymized transactions report-- SELECT pt.hashed_borrowernumber as 'borrower',pt.transaction_type as 'Transaction type', pt.datetime as 'Datetime', pt.branchcode as 'Patron branchcode', pt.categorycode as 'Patron category', (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt Sponsored-by: UKHSA - UK Health Security Agency Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #98 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #99 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds 2 new release notes| |types of statistics related | |to Interlibrary loans: ILL | |request created, and ILL | |request completed. | |Additionally, if | |Pseudonymization is | |enabled, pseudonymized | |transactions will be | |created from these | |statistics. | | | |Technical changes: | |- Database table | |'pseudonymized_borrower_att | |ributes' renamed to | |'pseudonymized_metadata_val | |ues'. Existing reports that | |reference this table should | |be updated accordingly on | |upgrade. | |- Adds 'illrequest_id' | |column to statistics table Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #100 from Victor Grousset/tuxayo <victor@tuxayo.net> --- If you run on main dbic --force You will get that file popping. Koha/Schema/Result/PseudonymizedMetadataValue.pm It's from here, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #101 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185629&action=edit Bug 37901: Fix schema files prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #102 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-ups pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #103 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We need an updated DBRev here, I think. It should check for the existence of the table before we do: $dbh->do(q{ DROP TABLE pseudonymized_borrower_attributes; }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #104 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I also pushed a commit to remove the now unnessesary schema file, PseudonymizedBorrowerAttribute.pm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #105 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #103)
We need an updated DBRev here, I think. It should check for the existence of the table before we do:
$dbh->do(q{ DROP TABLE pseudonymized_borrower_attributes; });
This is wrapped, so maybe the problem comes from Bug 36755? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #106 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- 12:19:39 koha-1 | [31mERROR: C4::Installer::foreign_key_exists(): DBI Exception: DBD::mysql::db selectrow_array failed: Table 'koha_kohadev.pseudonymized_borrower_attributes' doesn't exist at /kohadevbox/koha/installer/data/mysql/db_revs/231200053.pl line 11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40725 [Bug 40725] DBRev 23.12.00.053 should be made more resilient -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #107 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #106)
12:19:39 koha-1 | [31mERROR: C4::Installer::foreign_key_exists(): DBI Exception: DBD::mysql::db selectrow_array failed: Table 'koha_kohadev.pseudonymized_borrower_attributes' doesn't exist at /kohadevbox/koha/installer/data/mysql/db_revs/231200053.pl line 11
I followed-up here in a new bug report, Bug 40725. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #108 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha_Main_MariaDB_update is failing: https://jenkins.koha-community.org/job/Koha_Main_MariaDB_update/261/consoleF... 22:29:36 koha-1 | -foreign key from the illrequests table, links transaction to a specific illrequest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #109 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187585&action=edit Bug 37901: (follow-up) Adjust DBRev includes everything from the kohastructure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #110 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36033 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #111 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Will not backport to 25.05.x because it's an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Bug 37901 depends on bug 39652, which changed state. Bug 39652 Summary: Pseudonymized_borrower_attributes causes subsequent pseudonymized_transactions to not be added https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org