https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 22513 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178356&action=edit Bug 37901: Add ILL pseudonymization 1) Apply patches 2) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 3) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 4) Enable ILLModule and Pseudonymization system preferences 5) Create an ILL request 6) Confirm the pseudonymized_transaction has been added: $ koha-mysql kohadev $ select * from pseudonymized_transactions; 7) Further testing with more data: Check all options from PseudonymizationPatronFields and PseudonymizationTransactionFields and repeat steps 5) and 6). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178956&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178958&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178960&action=edit Bug 37901: Preparation: Update tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178962&action=edit Bug 37901: [DONT PUSH] dbic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178964&action=edit Bug 37901: Consider illrequest_id when creating When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178966&action=edit Bug 37901: UpdateStats when new ILL request is created -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178968&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --- Test plan: 1) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 2) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 3) Enable ILLModule and Pseudonymization system preferences 4) Check 'Keep for pseudonymization' at the only existing patron attribute type: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Save. Edit that attribute type for 'koha' patron: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 6) Scroll down, set a value for 'Show barcode on the summary screen items listings:'. Save. 7) Do a checkout for that 'koha' patron. 8) Confirm the pseudonymized_transaction has been added alongside its metadata (SHOW_BCODE), run report #3 from the examples listed above. This concludes the 'preparation' side of testing, ensuring that borrower_attributes are kept for pseudonymization 9) Create a new ILL request of type 'book'. 10) Run the report from 8) again. Verify the ILL pseudonymized transaction and its related pseudonymized metadata is there. Run tests: prove t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t prove t/db_dependent/Koha/PseudonymizedTransaction.t prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178959|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178961|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178963|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178967|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178980&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178982&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178984&action=edit Bug 37901: Preparation: Update tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178986&action=edit Bug 37901: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178988&action=edit Bug 37901: Consider illrequest_id when creating When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178990&action=edit Bug 37901: UpdateStats after new ILL request is created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178992&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --- Test plan: 1) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 2) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 3) Enable ILLModule and Pseudonymization system preferences 4) Check 'Keep for pseudonymization' at the only existing patron attribute type: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Save. Edit that attribute type for 'koha' patron: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 6) Scroll down, set a value for 'Show barcode on the summary screen items listings:'. Save. 7) Do a checkout for that 'koha' patron. 8) Confirm the pseudonymized_transaction has been added alongside its metadata (SHOW_BCODE), run report #3 from the examples listed above. This concludes the 'preparation' side of testing, ensuring that borrower_attributes are kept for pseudonymization 9) Create a new ILL request of type 'book'. 10) Run the report from 8) again. Verify the ILL pseudonymized transaction and its related pseudonymized metadata is there. Run tests: prove t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t prove t/db_dependent/Koha/PseudonymizedTransaction.t prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178980|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181008&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178982|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181010&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178984|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181012&action=edit Bug 37901: Preparation: Update tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178986|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181014&action=edit Bug 37901: [DONT PUSH] dbic -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181016&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #40 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181018&action=edit Bug 37901: UpdateStats after new ILL request is created or completed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178992|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181020&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --- Test plan: 1) Add a <bcrypt_settings> under <config> in /etc/koha/sites/kohadev/koha.conf.xml: $ <bcrypt_settings>$2a$08$9lmorEKnwQloheaCLFIfje</bcrypt_settings> <!-- taken from Pseudonymization.t --> 2) Restart plack & worker: $ koha-plack --restart kohadev && sudo koha-worker --restart kohadev 3) Enable ILLModule and Pseudonymization system preferences 4) Check 'Keep for pseudonymization' at the only existing patron attribute type: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE 5) Save. Edit that attribute type for 'koha' patron: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=51 6) Scroll down, set a value for 'Show barcode on the summary screen items listings:'. Save. 7) Do a checkout for that 'koha' patron. 8) Confirm the pseudonymized_transaction has been added alongside its metadata (SHOW_BCODE), run report #3 from the examples listed above. This concludes the 'preparation' side of testing, ensuring that borrower_attributes are kept for pseudonymization 9) Create a new ILL request of type 'book'. 10) Run the report from 8) again. Verify the ILL pseudonymized transaction and its related pseudonymized metadata is there. 11) Go back to that ILL request and click 'Confirm request'. After that click 'Mark completed'. 12) Repeat 10) Run tests: prove t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t prove t/db_dependent/Koha/PseudonymizedTransaction.t prove t/db_dependent/Koha/Pseudonymization.t Sponsored-by: UKHSA - UK Health Security Agency -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181008|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181696&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181010|0 |1 is obsolete| | --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181698&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181012|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181700&action=edit Bug 37901: Preparation: Update tests Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181014|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181702&action=edit Bug 37901: [DONT PUSH] dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181016|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181704&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181018|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181706&action=edit Bug 37901: UpdateStats after new ILL request is created or completed Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181020|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181708&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --ILL specific pseudonymized transactions report-- SELECT pt.hashed_borrowernumber as 'borrower',pt.transaction_type as 'Transaction type', pt.datetime as 'Datetime', pt.branchcode as 'Patron branchcode', pt.categorycode as 'Patron category', (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt Sponsored-by: UKHSA - UK Health Security Agency Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181697|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184710&action=edit Bug 37901: Preparation: db changes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181699|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184712&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181701|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184714&action=edit Bug 37901: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181703|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184716&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181705|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184718&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181707|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184720&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #70 from Lisette Scheer <lisette@bywatersolutions.com> --- It did work great! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184709|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185495&action=edit Bug 37901: Preparation: [DONT PUSH] automated dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184711|0 |1 is obsolete| | --- Comment #73 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185497&action=edit Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184713|0 |1 is obsolete| | --- Comment #75 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185499&action=edit Bug 37901: Preparation: Update tests Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184715|0 |1 is obsolete| | --- Comment #77 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185501&action=edit Bug 37901: [DONT PUSH] dbic Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184717|0 |1 is obsolete| | --- Comment #79 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185503&action=edit Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184719|0 |1 is obsolete| | --- Comment #81 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185505&action=edit Bug 37901: UpdateStats after new ILL request is created or completed Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184721|0 |1 is obsolete| | --- Comment #83 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185507&action=edit Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; --ILL specific pseudonymized transactions report-- SELECT pt.hashed_borrowernumber as 'borrower',pt.transaction_type as 'Transaction type', pt.datetime as 'Datetime', pt.branchcode as 'Patron branchcode', pt.categorycode as 'Patron category', (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt Sponsored-by: UKHSA - UK Health Security Agency Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185496|0 |1 is obsolete| | --- Comment #86 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185545&action=edit Bug 37901: Preparation: db changes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185498|0 |1 is obsolete| | --- Comment #88 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185547&action=edit Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185500|0 |1 is obsolete| | --- Comment #90 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185549&action=edit Bug 37901: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185502|0 |1 is obsolete| | --- Comment #92 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185551&action=edit Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185504|0 |1 is obsolete| | --- Comment #94 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185553&action=edit Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185506|0 |1 is obsolete| | --- Comment #96 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185555&action=edit Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #98 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds 2 new release notes| |types of statistics related | |to Interlibrary loans: ILL | |request created, and ILL | |request completed. | |Additionally, if | |Pseudonymization is | |enabled, pseudonymized | |transactions will be | |created from these | |statistics. | | | |Technical changes: | |- Database table | |'pseudonymized_borrower_att | |ributes' renamed to | |'pseudonymized_metadata_val | |ues'. Existing reports that | |reference this table should | |be updated accordingly on | |upgrade. | |- Adds 'illrequest_id' | |column to statistics table Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #101 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185629&action=edit Bug 37901: Fix schema files prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #102 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-ups pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #103 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We need an updated DBRev here, I think. It should check for the existence of the table before we do: $dbh->do(q{ DROP TABLE pseudonymized_borrower_attributes; }); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #105 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #103)

We need an updated DBRev here, I think. It should check for the existence of the table before we do:

$dbh->do(q{ DROP TABLE pseudonymized_borrower_attributes; });

This is wrapped, so maybe the problem comes from Bug 36755? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #107 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #106)

12:19:39 koha-1 | [31mERROR: C4::Installer::foreign_key_exists(): DBI Exception: DBD::mysql::db selectrow_array failed: Table 'koha_kohadev.pseudonymized_borrower_attributes' doesn't exist at /kohadevbox/koha/installer/data/mysql/db_revs/231200053.pl line 11

I followed-up here in a new bug report, Bug 40725. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 --- Comment #109 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187585&action=edit Bug 37901: (follow-up) Adjust DBRev includes everything from the kohastructure -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36033 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Bug 37901 depends on bug 39652, which changed state. Bug 39652 Summary: Pseudonymized_borrower_attributes causes subsequent pseudonymized_transactions to not be added https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1213 -- You are receiving this mail because: You are watching all bug changes.