[Bug 17432] New: Remove requirement to minify swagger.json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Bug ID: 17432 Summary: Remove requirement to minify swagger.json Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: benjamin.rokseth@kul.oslo.kommune.no, koha-bugs@lists.koha-community.org, lari.taskula@jns.fi, testopia@bugs.koha-community.org, tomascohen@gmail.com Depends on: 16212, 17102 This is an alternative to Bug #17102 Minification of the swagger.json file really serves no purpose. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102 [Bug 17102] Automatically minify swagger.json -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17102 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17102 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102 [Bug 17102] Automatically minify swagger.json -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56259&action=edit Bug 17432: Remove superflous minification The swagger specification file is currently superflously minified adding manual steps to release management and restful api route development. The minification is not required; The deferenced version of the specification is now internally validated at runtime and relavant errors output and the dereferenced schema has been made publically available at /api/v1/spec -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Removing this step should lower the onboarding time for developers wanting to work on RESTful api endpoints and also for those wishing to sign off and qa such bugs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56259|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56260&action=edit Bug 17432: Remove superflous minification The swagger specification file is currently superflously minified adding manual steps to release management and restful api route development. The minification is not required; The deferenced version of the specification is now internally validated at runtime and relavant errors output and the dereferenced schema has been made publically available at /api/v1/spec Test Plan 1) Apply patch 2) Ensure api routes still function (applying the /cities patch might be helpful) 3) Ensure /api/v1/spec page exists (it should be the de-referenced swagger.json file) -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56260|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 56265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56265&action=edit Bug 17432: Remove superflous minification The swagger specification file is currently superflously minified adding manual steps to release management and restful api route development. The minification is not required; The deferenced version of the specification is now internally validated at runtime and relavant errors output and the dereferenced schema has been made publically available at /api/v1/spec Test Plan 1) Apply patch 2) Ensure api routes still function (applying the /cities patch might be helpful) 3) Ensure /api/v1/spec page exists (it should be the de-referenced swagger.json file) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 --- Comment #5 from Lari Taskula <lari.taskula@jns.fi> --- This is amazing! I wasn't aware that "spec_path" alone can make that. It makes the minificator useless and life easier for everyone. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 56268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56268&action=edit Bug 17432: Remove minification The swagger specification file is currently being minified adding manual steps to release management and restful api route development. The minification is not required; The deferenced version of the specification is now internally validated at runtime and relavant errors output and the dereferenced schema has been made publically available at /api/v1/spec, so it can be copy&pasted into validation tools Test Plan 1) Apply patch 2) Ensure api routes still function (applying the /cities patch might be helpful) 3) Ensure /api/v1/spec page exists (it should be the de-referenced swagger.json file) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #56265|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 17102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17694 [Bug 17694] Add human friendly REST documentation -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17432 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The minification of release notes| |swagger.json is not more | |required; the deferenced | |version of the | |specification is now | |internally validated at | |runtime. | |Relavant errors | |output and the dereferenced | |schema has been made | |publically available at | |/api/v1/spec -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org