[Bug 21211] New: Add message details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Bug ID: 21211 Summary: Add message details Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: information@newcastle.gov.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, there is no description for this bug report and there is not enough information in the subject to see what it's about. Can you please add some more details? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 information@newcastle.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add message details |Patron messages/notes do | |not appear in all the tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #2 from information@newcastle.gov.uk --- (In reply to Katrin Fischer from comment #1)
Hi, there is no description for this bug report and there is not enough information in the subject to see what it's about. Can you please add some more details?
Hi, sorry we never meant to leave it that way! It's a case of clicking too quickly and then not having time to go back to it straightaway. In the process of adding the details now. Thanks, Aude -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #3 from information@newcastle.gov.uk --- Description: messages/notes on Patrons do not appear in a consistent way across all the Patron tabs, depending on how they are created. Add Message via button - only appears on the Checkout page. Add new message via link on checkout page - this also displays in the Circulation Note field in the Details page but is clear from Checkout page too. Could messages be made to appear on both the Details and the Checkout tabs, please, regardless of the way they are created? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to information from comment #3)
Add Message via button - only appears on the Checkout page.
This should not be the case. The button is in an include file which is used across all patron-specific pages. If you find otherwise it's a bug (which I don't see in our installation of 17.11).
Add new message via link on checkout page - this also displays in the Circulation Note field in the Details page but is clear from Checkout page too.
I don't really understand this comment, but I do see inconsistency between the way the "Add a new message" link appears on the circulation page versus the detail page: The link appears on Circulation when there are no messages and doesn't on the detail page. I consider it a bug that the link appears on circulation when there are no messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like purchase suggestions, ill requests and discharges are missing the patron toolbar. Also the modification logs - but as this template is used in 2 places, there might be a reason for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25188 Status|NEW |ASSIGNED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am going to use this bug to fix the toolbar, which will make the "Add message" show more consistently. For the different display of notes I have filed a new bug: Bug 25188 - Circulation notes only displays on checkouts tab, but not on details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron messages/notes do |Patron toolbar does not |not appear in all the tabs |appear on all tabs in | |patron account in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103209&action=edit Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103209|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103211&action=edit Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103211|0 |1 is obsolete| | --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 103218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103218&action=edit Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages Signed-off-by: David Roberts <david@koha-ptfs.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103218|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103258&action=edit Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org