[Bug 16769] New: Koha::Cache->set_in_cache calls need to be standardised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Bug ID: 16769 Summary: Koha::Cache->set_in_cache calls need to be standardised Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Koha::Cache->set_in_cache supports old calls to this method. It is better to standardise all of the calls and support only one version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52512&action=edit Bug 16769: Uniformise calls to Koha::Cache->set_in_cache
From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it
Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52512|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53751&action=edit Bug 16769: Uniformise calls to Koha::Cache->set_in_cache
From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it
Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53752&action=edit Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53753&action=edit Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53751|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56013&action=edit Bug 16769: Uniformise calls to Koha::Cache->set_in_cache
From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it
Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53752|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56014&action=edit Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53753|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56015&action=edit Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the november 16.11 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org