http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #1 from Melia Meggs <melia@bywatersolutions.com> --- Related to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I can't think of a situation a library wants to delete all holds (maybe not inventive enough today). I think normally you only want to cancel the expired holds - so it would make sense to me for the button to do that. Maybe the description could be more clear? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6039 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan: 1) Create two holds, and set them to waiting for two patrons. 2) Make the waitingdate for one of the holds longer than the value set in ReservesMaxPickUpDelay. 3) You should now see one reserve on each tab on waitingreserves.pl 4) Backup your database 5) On the "Holds over" tab, click 'Cancel all'. This should cancel both holds 6) Restore your database 7) Apply this patch 8) Repeat step 4, only the hold in the "Holds over" tab should be canceled. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #8 from Melia Meggs <melia@bywatersolutions.com> --- I applied this patch and followed the test plan above. Before the patch, when I clicked "cancel all" both my holds over and holds waiting were cancelled. After the patch, when I clicked "cancel all" only the holds over were cancelled. I think this patch is working, and I will add my sign-off. I am leaving the status as "needs sign-off" - we need a second sign-off from a non-ByWater staff member, please. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12837|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12875&action=edit Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * 2 signoffs, great * passes koha-qa.pl * no side effect risk I can imagine, script related only to waitingreserves.pl passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.