[Bug 16337] New: Remove the use of "onclick" from the stage MARC records template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Bug ID: 16337 Summary: Remove the use of "onclick" from the stage MARC records template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/stage-marc-import.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org, veron@veron.ch There are a couple of instances of "onclick" in stage-marc-import.tt which can be removed in favor of defining events in the JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50640&action=edit Bug 16337 - Remove the use of "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. Your upload should be processed correctly. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Cancel" button before the file has been uploaded. The upload should be cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50640|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50688&action=edit [SIGNED-OFF] Bug 16337 - Remove the use of "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. Your upload should be processed correctly. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Cancel" button before the file has been uploaded. The upload should be cancelled. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50688|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50789&action=edit [PASSED QA] Bug 16337 - Remove the use of "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. Your upload should be processed correctly. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Cancel" button before the file has been uploaded. The upload should be cancelled. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 [Bug 16468] Remove last "onclick" from the stage MARC records template -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org