[Bug 40364] New: Add permission for viewing patron holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Bug ID: 40364 Summary: Add permission for viewing patron holds history Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 32682 Bug 32682 is adding a permission for the ability to view patron checkout history. We also need a parallel permission for patron holds history. We should make it so when IntranetReadingHistoryHolds is enabled, users with this new permission can see patron hold history but users without the permission cannot. When IntranetReadingHistoryHolds is disabled, no users should be able to see patron hold history. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 [Bug 32682] Add permission for viewing patron reading history -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 trevor.diamond@mainlib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trevor.diamond@mainlib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Sounds good to me. I think these kinds of more granular permissions restricting access to patron information are increasingly invaluable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187065&action=edit Bug 40364: Atomicupdate to add permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187066&action=edit Bug 40364: Implement holds history permission To test: 1 - enable IntranetReadingHistoryHolds system preference 2 - make some holds for a patron, confirm you can see Holds History in the patron record when logged in as a superlibrarian 3 - log in as a non-superlibrarian with edit_borrowers permission, confirm you can see holds history in pthe patron record 4 - apply patch, updatedatabase, restat_all 5 - confirm you can see holds history as a superlibrarian 6 - confirm your non-superlibrarian from step 3 was given view_holds_history permission and can view holds history 7 - remove view_holds_history permission from your user, confirm you can no longer access holds history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187298&action=edit Bug 40364: Correct wording of permissions for hold history and checkout history These both said "Viewing" rather than "View" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187298|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187305&action=edit Bug 40364: Correct wording of permissions for checkout and holds history Changes "Viewing" to "View." In both relevant places! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187065|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187317&action=edit Bug 40364: Atomicupdate to add permission Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187066|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187318&action=edit Bug 40364: Implement holds history permission To test: 1 - enable IntranetReadingHistoryHolds system preference 2 - make some holds for a patron, confirm you can see Holds History in the patron record when logged in as a superlibrarian 3 - log in as a non-superlibrarian with edit_borrowers permission, confirm you can see holds history in pthe patron record 4 - apply patch, updatedatabase, restat_all 5 - confirm you can see holds history as a superlibrarian 6 - confirm your non-superlibrarian from step 3 was given view_holds_history permission and can view holds history 7 - remove view_holds_history permission from your user, confirm you can no longer access holds history Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187305|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187319&action=edit Bug 40364: Correct wording of permissions for checkout and holds history Changes "Viewing" to "View." In both relevant places! Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- I think the REST API route permission needs adjustments: api/v1/swagger/paths/patrons_holds.yaml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 188394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188394&action=edit Bug 40364: Correct system preference check in atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 188395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188395&action=edit Bug 40364: Update permissions for patron_holds API path -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@openfifth.c | |o.uk Status|Signed Off |Patch doesn't apply --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Applying: Bug 40364: Correct wording of permissions for checkout and holds history error: sha1 information is lacking or useless (installer/data/mysql/mandatory/userpermissions.sql). error: could not build fake ancestor Patch failed at 0001 Bug 40364: Correct wording of permissions for checkout and holds history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187319|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Comment on attachment 187319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187319 Bug 40364: Correct wording of permissions for checkout and holds history Obsoleting out the problem patch, which is just two tiny wording changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 191939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191939&action=edit Bug 40364: Correct wording in user permissions Changes the descriptions of the holds history and checkout history permissions to say "view" rather than "viewing" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187317|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191944&action=edit Bug 40364: Atomicupdate to add permission Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187318|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191945&action=edit Bug 40364: Implement holds history permission To test: 1 - enable IntranetReadingHistoryHolds system preference 2 - make some holds for a patron, confirm you can see Holds History in the patron record when logged in as a superlibrarian 3 - log in as a non-superlibrarian with edit_borrowers permission, confirm you can see holds history in pthe patron record 4 - apply patch, updatedatabase, restat_all 5 - confirm you can see holds history as a superlibrarian 6 - confirm your non-superlibrarian from step 3 was given view_holds_history permission and can view holds history 7 - remove view_holds_history permission from your user, confirm you can no longer access holds history Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188394|0 |1 is obsolete| | --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191946&action=edit Bug 40364: Correct system preference check in atomicupdate Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188395|0 |1 is obsolete| | --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191947&action=edit Bug 40364: Update permissions for patron_holds API path Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191939|0 |1 is obsolete| | --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191948&action=edit Bug 40364: Correct wording in user permissions Changes the descriptions of the holds history and checkout history permissions to say "view" rather than "viewing" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This breaks the yarn build process: bundling api/v1/swagger/swagger.yaml... [1] api/v1/swagger/paths/patrons_holds.yaml:80:9 Failed to parse: duplicated mapping key in "/kohadevbox/koha/api/v1/swagger/paths/patrons_holds.yaml" (80:9) 78 | permissions: 79 | borrowers: edit_borrowers 80 | borrowers: view_holds_history 81 | Error was generated by the bundler rule. [2] api/v1/swagger/swagger.yaml:511:5 at #/paths/~1patrons~1{patron_id}~1holds Can't resolve $ref: duplicated mapping key in "/kohadevbox/koha/api/v1/swagger/paths/patrons_holds.yaml" (80:9) 509 | $ref: "./paths/patrons_extended_attributes.yaml#/~1patrons~1{patron_id}~1extended_attributes~1{extended_attribute_id}" 510 | "/patrons/{patron_id}/holds": 511 | $ref: "./paths/patrons_holds.yaml#/~1patrons~1{patron_id}~1holds" 512 | "/patrons/{patron_id}/hold_groups": 513 | $ref: "./paths/patrons_hold_groups.yaml#/~1patrons~1{patron_id}~1hold_groups" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192257&action=edit Bug 40364: (follow-up) Fix duplicated mapping key issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192262&action=edit Bug 40364: Add new permission to t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |permission for viewing | |parton's hold history. ( | |view_holds_history ) | |Now when | |IntranetReadingHistoryHolds | |is enabled staff must also | |have the specific | |'view_holds_history' | |permission in order to view | |a patron's hold history. | |With | |IntranetReadingHistoryHolds | |turned off the no users are | |able to view patron's hold | |history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #24 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #25 from Aude Charillon <aude.charillon@openfifth.co.uk> --- *** Bug 42818 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Bug 40364 depends on bug 32682, which changed state. Bug 32682 Summary: Add permission for viewing patron reading history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 Laure <laure.roy@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laure.roy@inlibro.com Status|Needs documenting |RESOLVED Documentation| |Laure Roy contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1241 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org