https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- notice = record (French?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #5 from Michael Kuhn <mik@adminkuhn.ch> --- I applied the patch again. The following is as you describe: * Patch can be applied * The folder /koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport for intranet is there * The folder /koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport for opac is there * In the folder /koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport-samples there is the sample file "MARC21_simple_export.xsl" * This file can also be found in /koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport for intranet and in /koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport for opac * I open the Intranet interface, submit a search, click the title of a found item Then I click the button "Save", but I can only see formats BIBTEX, Dublin Core, MARCXML, three kinds of MARC, MODS and RIS - but no "Simple Export". In the OPAC interface it is almost the same. There I click the button "Save record" but there are only the formats already given above, plus one more (ISBD). But no "Simple Export". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #7 from Michael Kuhn <mik@adminkuhn.ch> --- I have set up a completely new kohadevbox. vagrant@kohadevbox:~$ cd kohaclone vagrant@kohadevbox:kohaclone(master)$ git pull Already up-to-date. vagrant@kohadevbox:kohaclone(master)$ git checkout -b 001 Switched to a new branch '001' Then I tried to apply patch 17385 again, but I was not able to do it: vagrant@kohadevbox:kohaclone(001)$ git bz apply 17385 Bug 17385 - Add custom export notices 55961 - Bug 17385 - Add custom export notices Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17385 - Add custom export notices fatal: sha1 information is lacking or useless (opac/opac-detail.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17385 - Add custom export notices The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17385---Add-custom-export-notices-0lLL49.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #9 from Bouzid <bouzid.fergani@inlibro.com> --- Rebase patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58308|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64033&action=edit [SIGNED-OFF] Bug 17385 - Add custom export notices test case: - Apply patch - Open intranet or opac interface and submit any search. - Click title of found item - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. - The name 'Simple Export' it's extract in the xslt file, curently the name is MARC21_simple_export.xsl. for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64033|0 |1 is obsolete| | Attachment #64034|0 |1 is obsolete| | --- Comment #14 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67357&action=edit Bug 17385 - Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mik@adminkuhn.ch | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thx for your adjustments! Looks good to me. Final comments: This is not a blocker for me, but OpacExportOptions controls the options listed by detail sidebar. Your custom exports are listed no matter what. It might be better to let OpacExportOptions also control if the custom exports should be added to the list somehow. Maybe not one by one, but just on directory level (show them all or not)? But do not make big adjustments here. It could be handled on a new report or we could simply state: remove the xsl files from biblioexport. XSLTParse4Display is not yet tested, but your change should officially be tested ;) Also I recommend to remove the opac parameter. It is not consistent with the approach followed in the sub. Not changing the parameters could help you here. Please send XSLTCustomExport and OPACXSLTCustomExport to the routine; this is consistent and does the same thing. Since your change only deals with the $xslfilename, I could live without a test script (but I am not sure about the RM). CustomXSLTExportList is new and should really have its own test (should not be hard) Mock opachtdocs and create the dir in a tempdir. Check on returned title and method. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67579|0 |1 is obsolete| | --- Comment #17 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 74660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74660&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> https://bugs.koha-community.org/show_bug.cgi?id=17835 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com Assignee|bouzid.fergani@inlibro.com |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74660|0 |1 is obsolete| | --- Comment #22 from Blou <philippe.blouin@inlibro.com> --- Created attachment 79055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79055&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> https://bugs.koha-community.org/show_bug.cgi?id=17835 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #23 from Blou <philippe.blouin@inlibro.com> --- Created attachment 79056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79056&action=edit Bug 17385: Add tests for CustomXSLTExportList + Added tests for CustomXSLTExportList to C4::XSLT + Added an eval block in CustomXSLTExportList to handle invalid XML. * Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent + Added "Custom" option to OPACExportOptions preference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've attached rebased patches and added Cori Lynn's sign-off to the first patch as well. 1) Can you please add POD to CustomXSLTExportList (see comment #19) 2) There is lots of minor (fast to fix) fails in the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc FAIL filters wrong_html_filter at line 100 ( <li><a href="/cgi-bin/koha/catalogue/export.pl?format=[% filesOption.format %]&op=exportxsl&file=[% filesOption.value %]&bib=[% biblionumber | html %]">[% filesOption.filename %]</a></li>) missing_filter at line 100 ( <li><a href="/cgi-bin/koha/catalogue/export.pl?format=[% filesOption.format %]&op=exportxsl&file=[% filesOption.value %]&bib=[% biblionumber | html %]">[% filesOption.filename %]</a></li>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc FAIL filters wrong_html_filter at line 27 ( <li><a href="/cgi-bin/koha/virtualshelves/downloadshelf.pl?format=xsl.[% xsl_export.value %]&shelfid=[% shelf.shelfnumber %]">XSL - [% xsl_export.filename %]</a></li>) missing_filter at line 27 ( <li><a href="/cgi-bin/koha/virtualshelves/downloadshelf.pl?format=xsl.[% xsl_export.value %]&shelfid=[% shelf.shelfnumber %]">XSL - [% xsl_export.filename %]</a></li>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt FAIL filters missing_filter at line 60 ( <li><a href="/cgi-bin/koha/basket/downloadcart.pl?format=xsl.[% xsl_export.value %]&bib_list=[% bib_list %]">XSL - [% xsl_export.filename %]</a></li>) wrong_html_filter at line 60 ( <li><a href="/cgi-bin/koha/basket/downloadcart.pl?format=xsl.[% xsl_export.value %]&bib_list=[% bib_list %]">XSL - [% xsl_export.filename %]</a></li>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 860 ( <option value="[% filesOption.value %]">[% filesOption.filename %]</option>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt FAIL filters missing_filter at line 40 ( <option value="xsl.[% xsl_export.value %]">XSL - [% xsl_export.filename %]</option>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl OK git manipulation OK xml_valid FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc FAIL filters missing_filter at line 71 ( <li><a role="menuitem" href="/cgi-bin/koha/opac-export.pl?format=[% filesOption.format %]&op=exportxsl&file=[% filesOption.value %]&bib=[% biblionumber %]">[% filesOption.filename %]</a></li>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt FAIL filters missing_filter at line 24 ( <option value="xsl.[% xsl_export.value %]">XSL - [% xsl_export.filename %]</option>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt FAIL filters missing_filter at line 63 ( <option value="xsl.[% xsl_export.value %]">XSL - [% xsl_export.filename %]</option>) OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template 3) t/XSLT.t passes, but there is a warning that should be fixed: t/XSLT.t .. 2/12 Use of uninitialized value $outputformat in string eq at /home/vagrant/kohaclone/C4/XSLT.pm line 404. 4) I think we should leave the example out of production. You only provide an example for MARC21 that will not work for UNIMARC and NORMARC users and that can't be removed from display unless you delete the file (and will come back on each update using packages). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79055|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81385&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- comment#25! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84388|0 |1 is obsolete| | --- Comment #30 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84389&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |mikael.olangcay-brisebois@i | |nLibro.com --- Comment #32 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Rebased on current master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84389|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 86875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86875&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 86877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86877&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Thanks for your perseverance, guys. This took quite some time. Since the Custom option is not checked by default, I do not see a problem pushing this in its current form. [1] We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. => See follow-up. [2] We should add caching in CustomXSLTExportList. => See second follow-up. [3] The example xslt perhaps should be renamed (as mentioned before earlier). If you would only check for the .xsl extension, we could add a README and rename the extension of the simple export sample. Since it is pref controlled now, this may be done later imo. No blocker for me. [4] t/XSLT.t depends on a pref, so on the database. Should imo be moved to dependent. Removing Test::DBIx::Class :) No blocker, maybe later ? [5] I personally do not like using LibXML to parse the filename and format from the xsl file. And was just thinking about adding a small json or yaml file to do the same? No blocker, maybe later.. Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86877|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 86879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86879&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Obviously, we needed two cache keys. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #44 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 97076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97076&action=edit Bug 17385: QA ctrics fixed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86875|0 |1 is obsolete| | --- Comment #46 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 97101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97101&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86879|0 |1 is obsolete| | --- Comment #48 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 97103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97103&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #50 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 97105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97105&action=edit Bug 17385: QA Critics Fixed and added Missing Filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #51 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Remove merge conflicts. Fixed qa script failures - missing filters and a critic complaint on XSLT. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97101|0 |1 is obsolete| | --- Comment #53 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 100289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100289&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97103|0 |1 is obsolete| | --- Comment #55 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 100291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100291&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97105|0 |1 is obsolete| | --- Comment #57 from Gabriel DeCarufel <gabriel.decarufel@inlibro.com> --- Created attachment 100293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100293&action=edit Bug 17385: QA Critics Fixed and added Missing Filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from David Nind <david@davidnind.com> --- Thanks Gabriel, the patch now applies! I've changed the status to Failed QA as: - The test plan indicates it should be available for carts and lists: carts work, for lists there is no option to download (only shows RIS, BibTeX, ISBD, MARC as options). - The tests don't pass for me. root@ffb0d824040d:koha(bz17385)$ prove t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 28. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 77. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 85. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 95. Execution of t/db_dependent/XSLT.t aborted due to compilation errors. # Looks like your test exited with 255 before it could output anything. t/db_dependent/XSLT.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.87 cusr 0.09 csys = 0.99 CPU) Result: FAIL root@ffb0d824040d:koha(bz17385)$ prove t/XSLT.t t/XSLT.t .. 2/12 # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report ------------------- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.63 cusr 0.14 csys = 3.79 CPU) Result: FAIL Notes from testing: - Need to enable 'Custom' option for OpacExportOptions system preference. - Naming: . For cart shows as: XSL - Simple Export . System preference OpacExportOptions shows as: Custom . Staff interface save shows as: Simple Export (from the sample .xsl file) . OPAC save record shows as: Simple Export (from the sample .xsl file) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel <gabriel.decarufel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100289|0 |1 is obsolete| | --- Comment #60 from David Nind <david@davidnind.com> --- Created attachment 100670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100670&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Enable XSL - Simple Export option for system preference OpacExportOptions - Visit an item's detail page in the OPAC or the staff interface - Click save and you found XSL - Simple Export. - Click XSL - Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100291|0 |1 is obsolete| | --- Comment #62 from David Nind <david@davidnind.com> --- Created attachment 100672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100672&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100293|0 |1 is obsolete| | --- Comment #64 from David Nind <david@davidnind.com> --- Created attachment 100674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100674&action=edit Bug 17385: QA Critics Fixed and added Missing Filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The tests are failing for me: t/XSLT.t ............... 1..12 ok 1 - use C4::XSLT; ok 2 - Found test/en ok 3 - Found test/es-ES ok 4 - Found test/en ok 5 - Found test/es-ES ok 6 - Fell back to test/en for test/fr-FR ok 7 - Fell back to prog/es-ES for nope/es-ES ok 8 - Fell back to prog/en for nope/fr-FR ok 9 - singleBranchMode has a value of 0 Use of uninitialized value in pattern match (m//) at /home/vagrant/kohaclone/C4/XSLT.pm line 422. not ok 10 - CustomXSLTExportList finds custom XSLTs # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. Use of uninitialized value in string eq at t/XSLT.t line 108. not ok 11 - Title is specified in root node # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. not ok 12 - Title is filename if not specified # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report ------------------- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100670|0 |1 is obsolete| | --- Comment #68 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 112671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112671&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100672|0 |1 is obsolete| | --- Comment #70 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 112673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112673&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100674|0 |1 is obsolete| | --- Comment #72 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 112675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112675&action=edit Bug 17385: QA Critics Fixed and added Missing Filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|charles.farmer@inlibro.com |ivan.dziuba@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112673|0 |1 is obsolete| | --- Comment #76 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 112678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112678&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112675|0 |1 is obsolete| | --- Comment #78 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 112680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112680&action=edit Bug 17385: QA Critics Fixed and added Missing Filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #80 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 112682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112682&action=edit Changes to be committed: modified: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc modified: t/XSLT.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112678|0 |1 is obsolete| | --- Comment #82 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 112957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112957&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112677|0 |1 is obsolete| | Attachment #112680|0 |1 is obsolete| | Attachment #112681|0 |1 is obsolete| | Attachment #112682|0 |1 is obsolete| | --- Comment #84 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 112959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112959&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #86 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 130284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130284&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #88 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 130286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130286&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |the-minh.luong@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130283|0 |1 is obsolete| | Attachment #130284|0 |1 is obsolete| | Attachment #130285|0 |1 is obsolete| | Attachment #130286|0 |1 is obsolete| | Attachment #130287|0 |1 is obsolete| | --- Comment #91 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 130691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130691&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #93 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 130693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130693&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #95 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 130695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130695&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #97 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 131492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131492&action=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130691|0 |1 is obsolete| | Attachment #130692|0 |1 is obsolete| | Attachment #130693|0 |1 is obsolete| | Attachment #130694|0 |1 is obsolete| | Attachment #130695|0 |1 is obsolete| | Attachment #131492|0 |1 is obsolete| | --- Comment #98 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 132488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132488&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #100 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 132490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132490&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #102 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 132492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132492&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #104 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 132581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132581&action=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132489|0 |1 is obsolete| | --- Comment #106 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 133499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133499&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132491|0 |1 is obsolete| | --- Comment #108 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 133501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133501&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132493|0 |1 is obsolete| | --- Comment #110 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 133503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133503&action=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133498|0 |1 is obsolete| | --- Comment #112 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138031&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133500|0 |1 is obsolete| | --- Comment #114 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138033&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133502|0 |1 is obsolete| | --- Comment #116 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138035&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133504|0 |1 is obsolete| | --- Comment #118 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138037&action=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138031|0 |1 is obsolete| | --- Comment #120 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138082&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138033|0 |1 is obsolete| | --- Comment #122 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138084&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138035|0 |1 is obsolete| | --- Comment #124 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138086&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138037|0 |1 is obsolete| | --- Comment #126 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 138088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138088&action=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #128 from David Nind <david@davidnind.com> --- Thanks Shi Yao, the patches now apply! However, I've changed the status to Failed QA as there are: 1. Error traces after the patches are applied: a. See error traces for the staff interface - see [1], [2], and [3] (occurs if the 'XSL - Simple Export' option for OpacExportOptions is either selected or not selected). b. See error traces for the OPAC - see [4]. 2. If the 'XSL - Simple Export' option for OpacExportOptions is not selected, it still appears in the staff interface record details page as a save option. 3. The t/XSLT.t tests fail - see [5]. There is no option in the OPAC cart and lists to download as 'XSL - Simple Export' - I'm not sure whether there should be or not... Consolidated test plan so far: 1. Before applying the patches run the tests - these should pass: a. prove -l t/XSLT.t b. prove -l t/db_dependent/XSLT.t 2. Check current download and save options: a. OpacExportOptions system preference: all options selected, note that there is no 'XSL - Simple Export' option. b. for both the OPAC and the staff interface: (i) search and add some selected items to the cart: check the download options - there is no 'XSL - Simple Export' option (ii) search and add some items to a new list: check the download lists options - there is no 'XSL - Simple Export' option (iii) from the details page for a record in the OPAC: check the save record options in the right sidebar, there is no 'XSL - Simple Export' option (iv) from the details page for a record in the staff interface: check the save record options from the menu bar, there is no 'XSL - Simple Export' option 4. Apply the patches and reload everything (flush_memcached, restart_all, clear your browser cache (or use an incognito/private window)). 5. For the OpacExportOptions system preference, select the new option 'XSL - Simple Export'. 6. Repeat step 2 - there should now be an 'XSL - Simple Export' option available for download or saving. 7. Select the 'XSL - Simple Export' in all the paces it appears in the OPAC and staff interface - an HTML file should be downloaded. 8. Open the HTML file - you should see the record's information. 9. Run the tests - they should pass: a. prove -l t/XSLT.t b. prove -l t/db_dependent/XSLT.t [1] Error trace after clicking on the cart in the staff interface: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_basket_basket_2epl::CustomXSLTExportList called at /kohadevbox/koha/basket/basket.pl line 120 .... [2] Error trace when accessing the lists from the staff interface: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_shelves_2epl::CustomXSLTExportList called at /kohadevbox/koha/virtualshelves/shelves.pl line 381 .... [3] Error trace when selecting Save > XSL - Simple Export from a record's details page in the staff interface: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_catalogue_export_2epl::GetMarcBiblio called at /kohadevbox/koha/catalogue/export.pl line 95 .... [4] Error trace when selecting Save record > XSL - Simple Export from a record's details page in the OPAC: Undefined subroutine &C4::Biblio::GetMarcBiblio called at /kohadevbox/koha/opac/opac-export.pl line 145 .... [5] Failed tests for t/XSLT.t prove -l t/XSLT.t t/XSLT.t .. 2/12 # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report ------------------- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.01 sys + 3.46 cusr 0.19 csys = 3.68 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #130 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to David Nind from comment #128)

Thanks Shi Yao, the patches now apply!

However, I've changed the status to Failed QA as there are:

1. Error traces after the patches are applied:

a. See error traces for the staff interface - see [1], [2], and [3] (occurs if the 'XSL - Simple Export' option for OpacExportOptions is either selected or not selected).

b. See error traces for the OPAC - see [4].

2. If the 'XSL - Simple Export' option for OpacExportOptions is not selected, it still appears in the staff interface record details page as a save option.

3. The t/XSLT.t tests fail - see [5].

1. There shouldn't be any errors now 2. The system preference has the word "Opac" in it so I assume it only affects OPAC interface and not the staff interface 3. Couldn't run the test on my machine because I have trouble installing Test::DBIx::Class. Hope it works -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138082|0 |1 is obsolete| | --- Comment #131 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139277&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138084|0 |1 is obsolete| | --- Comment #133 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139279&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138086|0 |1 is obsolete| | --- Comment #135 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139281&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138088|0 |1 is obsolete| | --- Comment #137 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139283&action=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #139 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139278|0 |1 is obsolete| | --- Comment #141 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 141158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141158&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139280|0 |1 is obsolete| | --- Comment #143 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 141160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141160&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139282|0 |1 is obsolete| | --- Comment #145 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 141162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141162&action=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139284|0 |1 is obsolete| | --- Comment #147 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 141164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141164&action=edit Bug 17385: Add missing imports and equivalent code for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141157|0 |1 is obsolete| | --- Comment #149 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144335&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144336|0 |1 is obsolete| | --- Comment #151 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144380&action=edit This patch adds 'XSL-Simple Export' when saving a bibliographic record To test: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. 3) Notice that 'XSL- Simple Export' is not in the menu. 4) Apply the patch. 5) In System preferences search for OpacExportOptions and enable XSL 6) Repeat the steps 1 and 2. 7) Notice that 'XSL - Simple Export' is in the menu. 8) Click on 'XSL - Simple Export'. A .html file should be downloaded. 9) Open the .html file. You should see the record's informations. 10) Add some items to your Cart 11) Open the Cart 12) Click on the 'Download' button and observe the dropdown menu. 13) Notice that 'XSL - Simple Export' is in the menu. 14) Click on 'XSL - Simple Export'. A .html file should be downloaded. 15) Open the .html file. You should see the record's informations. 16) Add some items to a List 17) Open the List 18) Click on the 'Download' button and observe the dropdown menu. 19) Notice that 'XSL - Simple Export' is in the menu. 20) Click on 'XSL - Simple Export'. A .html file should be downloaded. 21) Open the .html file. You should see the record's informations. 22) Do the same steps in OPAC 23) In System preferences search for OpacExportOptions and disable XSL 24) Repeat all steps 25) Notice that 'XSL - Simple Export' is no more in the menus. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144380|0 |1 is obsolete| | --- Comment #152 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144384&action=edit This patch adds 'XSL-Simple Export' when saving a bibliographic record To test: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. 3) Notice that 'XSL- Simple Export' is not in the menu. 4) Apply the patch. 5) In System preferences search for OpacExportOptions and enable XSL 6) Repeat the steps 1 and 2. 7) Notice that 'XSL - Simple Export' is in the menu. 8) Click on 'XSL - Simple Export'. A .html file should be downloaded. 9) Open the .html file. You should see the record's informations. 10) Add some items to your Cart 11) Open the Cart 12) Click on the 'Download' button and observe the dropdown menu. 13) Notice that 'XSL - Simple Export' is in the menu. 14) Click on 'XSL - Simple Export'. A .html file should be downloaded. 15) Open the .html file. You should see the record's informations. 16) Add some items to a List 17) Open the List 18) Click on the 'Download' button and observe the dropdown menu. 19) Notice that 'XSL - Simple Export' is in the menu. 20) Click on 'XSL - Simple Export'. A .html file should be downloaded. 21) Open the .html file. You should see the record's informations. 22) Do the same steps in OPAC 23) In System preferences search for OpacExportOptions and disable XSL 24) Repeat all steps 25) Notice that 'XSL - Simple Export' is no more in the menus. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144384|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141160|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141163|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141157|0 |1 is obsolete| | --- Comment #153 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151095&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141159|0 |1 is obsolete| | --- Comment #155 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151097&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #157 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151099&action=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151096|0 |1 is obsolete| | --- Comment #159 from David Nind <david@davidnind.com> --- Created attachment 151103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151103&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151098|0 |1 is obsolete| | --- Comment #161 from David Nind <david@davidnind.com> --- Created attachment 151105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151105&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151102|0 |1 is obsolete| | --- Comment #163 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151377&action=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151104|0 |1 is obsolete| | --- Comment #165 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151379&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151106|0 |1 is obsolete| | --- Comment #167 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 151381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151381&action=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151377|0 |1 is obsolete| | --- Comment #168 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 154379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154379&action=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151379|0 |1 is obsolete| | --- Comment #170 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 154381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154381&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.