[Bug 16825] New: Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Bug ID: 16825 Summary: Add API route for getting an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: larit@student.uef.fi QA Contact: testopia@bugs.koha-community.org Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST API: Use newer version of Swagger2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 [Bug 16826] Add API routes for getting item availability and holdability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #1 from Lari Taskula <larit@student.uef.fi> --- Created attachment 52943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52943&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52943|0 |1 is obsolete| | --- Comment #2 from Lari Taskula <larit@student.uef.fi> --- Created attachment 52947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52947&action=edit Bug 16825: Add API route for getting an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52947|0 |1 is obsolete| | --- Comment #3 from Lari Taskula <larit@student.uef.fi> --- Created attachment 53035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53035&action=edit Bug 16825: Add API route for getting an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53035|0 |1 is obsolete| | --- Comment #4 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 53108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53108&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53108|0 |1 is obsolete| | --- Comment #5 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 53111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53111&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav <mail@jkozlovsky.cz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53111|0 |1 is obsolete| | --- Comment #6 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 53222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53222&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17007 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #7 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 53837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53837&action=edit Bug 16825: (followup) Add API route for getting an item Added on top of last patch the OpacHiddenItems syspref restriction for users who are not staff. They see "Item Not Found" when trying to view item hidden from OPAC. Only staff can see those GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com, | |mail@jkozlovsky.cz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- items.new_status is missing in the swagger file. Please have a look at bug 15126 comment 53. We need a way to keep this file up-to-date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #9 from Lari Taskula <larit@student.uef.fi> --- Created attachment 53921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53921&action=edit Bug 16826: [QA Follow-up] Add 'new_status' to Swagger definition Adds missing "new_status" to item's Swagger definition. Also, to avoid forgotten columns in definitions, adds a test to compare item-definition to database's items-table. To test: 1. Run t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #10 from Lari Taskula <larit@student.uef.fi> --- I created Bug 17032 to add similar tests for what's already in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #11 from Jiri Kozlovsky <mail@jkozlovsky.cz> --- Created attachment 53923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53923&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Adds missing "new_status" to item's Swagger definition. Also, to avoid forgotten columns in definitions, adds a test to compare item-definition to database's items-table. To test: 1. Run t/db_dependent/api/v1/items.t Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Lari: You have probably changed in your comment bug ID for 16826 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825#c9 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jiri Kozlovsky <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lari Taskula from comment #9)
Also, to avoid forgotten columns in definitions, adds a test to compare item-definition to database's items-table.
Lari, thanks for that! Do you think you could provide a global check? It would look at the api/v1/definitions/*.json files and compare the columns with Koha::Objects->columns (added by bug 16889). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #13 from Lari Taskula <larit@student.uef.fi> --- (In reply to Jiri Kozlovsky from comment #11)
Lari: You have probably changed in your comment bug ID for 16826 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825#c9
Indeed. Sorry about that! (In reply to Jonathan Druart from comment #12)
(In reply to Lari Taskula from comment #9)
Also, to avoid forgotten columns in definitions, adds a test to compare item-definition to database's items-table.
Lari, thanks for that! Do you think you could provide a global check? It would look at the api/v1/definitions/*.json files and compare the columns with Koha::Objects->columns (added by bug 16889).
As discussed on IRC, I have provided a test that does this, in Bug 17032. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53923|0 |1 is obsolete| | --- Comment #14 from Lari Taskula <larit@student.uef.fi> --- Created attachment 54052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54052&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Adds missing "new_status" to item's Swagger definition. Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Removed test for missing properties. It should be done in a separate context. See Bug 17032. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17032 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53837|0 |1 is obsolete| | --- Comment #15 from Lari Taskula <larit@student.uef.fi> --- Created attachment 54686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54686&action=edit Bug 16825: (followup) Add API route for getting an item Fixed tab-character. Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit@student.uef.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54052|0 |1 is obsolete| | --- Comment #16 from Lari Taskula <larit@student.uef.fi> --- Created attachment 54687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54687&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Adds missing "new_status" to item's Swagger definition. Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add API route for getting |REST API: Add API route for |an item |getting an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Bug 16825 depends on bug 15126, which changed state. Bug 15126 Summary: REST API: Use newer version of Swagger2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53222|0 |1 is obsolete| | --- Comment #17 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56122&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56122|0 |1 is obsolete| | --- Comment #18 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56123&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Apply patch and run minifySwagger.pl perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d api/v1/swagger/swagger.min.json 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54686|0 |1 is obsolete| | --- Comment #19 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56124&action=edit Bug 16825: (followup) Add API route for getting an item Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit@student.uef.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54687|0 |1 is obsolete| | --- Comment #20 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56125&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Adds missing "new_status" to item's Swagger definition. To test: 1. Run t/db_dependent/api/v1/swagger/definitions.t 2. Observe that test fails because of missing new_status. 3. Apply patch and test again 4. Observe that test no longer complains about new_status. (minify swagger) perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d api/v1/swagger Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #21 from Lari Taskula <lari.taskula@jns.fi> --- Rebased on top of master and added Swagger-minifying into test plan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56125|0 |1 is obsolete| | --- Comment #22 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56131&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56131|0 |1 is obsolete| | --- Comment #23 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56133&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Adds missing "new_status" to item's Swagger definition. To test: 1. Run t/db_dependent/api/v1/swagger/definitions.t 2. Observe that test fails because of missing new_status. 3. Apply patch and test again 4. Observe that test no longer complains about new_status. (minify swagger) perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d api/v1/swagger/swagger.min.json Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Fixed a typo in minifying command. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56123|0 |1 is obsolete| | --- Comment #24 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56290&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56124|0 |1 is obsolete| | --- Comment #25 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56292&action=edit Bug 16825: (followup) Add API route for getting an item Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit@student.uef.fi> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56133|0 |1 is obsolete| | --- Comment #26 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 56293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56293&action=edit Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition Signed-off-by: Jiri Kozlovsky <mail@jkozlovsky.cz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #27 from Lari Taskula <lari.taskula@jns.fi> --- Removed minifying step from test plan after Bug 17432. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Depends on|15126 |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST API: Use newer version of Swagger2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56290|0 |1 is obsolete| | --- Comment #28 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 61176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61176&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. The OpacHiddenItems syspref restriction is considered for users who are not staff. They see "Item Not Found" when trying to view item hidden from OPAC. Only staff can see those items. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56293|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #29 from Lari Taskula <lari.taskula@jns.fi> --- Rewritten, now Mojolicious::Plugin::OpenAPI compatible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #30 from Lari Taskula <lari.taskula@jns.fi> --- (In reply to Lari Taskula from comment #29)
Rewritten, now Mojolicious::Plugin::OpenAPI compatible.
Forgot to include this in the previous comment - Additional note for testers: requires JSON::Validator version 0.96, otherwise tests fail for the following reason: GET /api/v1/items/340856 [{"message":"Does not match date-time format.","path":"\/timestamp"},{"message":"anyOf failed: Does not match date-time format.","path":"\/itemlost_on"},{"message":"anyOf failed: Does not match date-time format.","path":"\/withdrawn_on"}]. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61176|0 |1 is obsolete| | --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64275&action=edit [SIGNED-OFF] Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. The OpacHiddenItems syspref restriction is considered for users who are not staff. They see "Item Not Found" when trying to view item hidden from OPAC. Only staff can see those items. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Excluding itemnotes_nonpublic is good thinking, but what about other fields that are set to not display in the OPAC in the frameworks? I know we got some libraries using more_subfields_xml to store additional information that is not for thought to be seen by normal users. I think those should only show if you have catalogue permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #33 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65007&action=edit Bug 16825: (squashable) Fix test cleanup issues Roll back failed at the end of the test. Apply this patch to fix the issue. To test: 1. prove t/db_dependent/api/v1/items.t 2. Check your database to make sure nothing persists after the test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web services |REST api QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Lari, the second patch doens't apply. Please rebase/fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64275|0 |1 is obsolete| | Attachment #65007|0 |1 is obsolete| | --- Comment #35 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 67865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67865&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. The OpacHiddenItems syspref restriction is considered for users who are not staff. They see "Item Not Found" when trying to view item hidden from OPAC. Only staff can see those items. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Bug 16825 depends on bug 18137, which changed state. Bug 18137 Summary: REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: Add API route for |Add API route for getting |getting an item |an item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Running the test fails with me. # Subtest: Confirm effectiveness of OpacHiddenItems 1..7 ok 1 - GET /api/v1/items/21 not ok 2 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/items.t line 85. # got: '500' # expected: '200' not ok 3 - exact match for JSON Pointer "/itemnumber" # Failed test 'exact match for JSON Pointer "/itemnumber"' # at t/db_dependent/api/v1/items.t line 85. # got: undef # expected: '21' not ok 4 - exact match for JSON Pointer "/biblionumber" # Failed test 'exact match for JSON Pointer "/biblionumber"' # at t/db_dependent/api/v1/items.t line 85. # got: undef # expected: '32' ok 5 - exact match for JSON Pointer "/itemnotes_nonpublic" ok 6 - GET /api/v1/items/21 ok 7 - 404 Not Found # Looks like you failed 3 tests of 7. not ok 3 - Confirm effectiveness of OpacHiddenItems # Failed test 'Confirm effectiveness of OpacHiddenItems' # at t/db_dependent/api/v1/items.t line 96. ok 4 - GET /api/v1/items/21 not ok 5 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/items.t line 100. # got: '500' # expected: '200' not ok 6 - exact match for JSON Pointer "/itemnumber" # Failed test 'exact match for JSON Pointer "/itemnumber"' # at t/db_dependent/api/v1/items.t line 100. # got: undef # expected: '21' not ok 7 - exact match for JSON Pointer "/biblionumber" # Failed test 'exact match for JSON Pointer "/biblionumber"' # at t/db_dependent/api/v1/items.t line 100. # got: undef # expected: '32' not ok 8 - exact match for JSON Pointer "/itemnotes_nonpublic" # Failed test 'exact match for JSON Pointer "/itemnotes_nonpublic"' # at t/db_dependent/api/v1/items.t line 100. # got: undef # expected: 'Wb_gNO' # Looks like you failed 5 tests of 8. not ok 2 - get() tests # Failed test 'get() tests' # at t/db_dependent/api/v1/items.t line 107. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Items_endpoint_RF | |C Keywords| |needs_rfc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18191 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] Add endpoint to list valid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67865|0 |1 is obsolete| | CC| |johanna.raisa@koha-suomi.fi --- Comment #37 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 91051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91051&action=edit Bug 16825: Add API route for getting an item I modified swagger and functions to be similar to other REST work. Also fixed the tests to pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lari.taskula@hypernova.fi |johanna.raisa@koha-suomi.fi Change sponsored?|--- |Sponsored Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #38 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. The OpacHiddenItems syspref restriction is considered for users who are not staff. They see "Item Not Found" when trying to view item hidden from OPAC. Only staff can see those items. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com Status|Needs Signoff |Failed QA --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, Johanna. This work has been initiated before a few agreements were reached about how to write endpoints for the API. I've got a few remarks on this regard: - There's a problem with the attribute mappings. There's an RFC for this endpoint's spec [1]. The attribute mappings should respect the RFC (I'm not sure its been voted, but you should follow it, given the people involved on writing and discussing it). - We don't mix privileged users/non-privileged users use cases on the same endpoint anymore. An endpoint that requires admin privileges belongs to /items. An endpoint that doesn't require admin privileges goes to /public/items. This comment related to the check for OpacHiddenItems and the patron status. Non privileged users should get a 403 on this endpoint. If you need general unprivileged access, then add an endpoint to /public/items/{item_id} - Don't add to x-primitives, that went too far in my opinion. Just put the definition in the path spec. - For the tests, take t/db_dependent/api/v1/libraries.t as an example. I like it that you added stub tests for unimplemented routes, but try to clean it up by setting Basic authentication as libraries.t I can help on any doubts you might have or even coding. Just ping me (tcohen on IRC) [1] https://wiki.koha-community.org/wiki/Items_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #40 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Hi, Tomas. Thanks for the points! I looked that this bug was stuck on test passing. Just took Lari's work and mainly fixed those problems. I will look into those points and let's see again. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91051|0 |1 is obsolete| | --- Comment #41 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 91061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91061&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{item_id} Gets one Item This patch adds route to get one item from koha.items table. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Johanna Räisä from comment #41)
Created attachment 91061 [details] [review] Bug 16825: Add API route for getting an item
Very efficient Johanna! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91061|0 |1 is obsolete| | --- Comment #43 from Michal Denar <black23@gmail.com> --- Created attachment 91124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91124&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{item_id} Gets one Item This patch adds route to get one item from koha.items table. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com --- Comment #44 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Hi, Thanks to rebase this patch. Bug 16825 - Add API route for getting an item 91124 - Bug 16825: Add API route for getting an item Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16825: Add API route for getting an item Using index info to reconstruct a base tree... M api/v1/swagger/definitions.json M api/v1/swagger/paths.json Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths.json CONFLICT (content): Merge conflict in api/v1/swagger/paths.json Auto-merging api/v1/swagger/definitions.json error: Failed to merge in the changes. Patch failed at 0001 Bug 16825: Add API route for getting an item The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16825-Add-API-route-for-getting-an-item-uUF0c9.patch Bouzid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #45 from Michal Denar <black23@gmail.com> --- Johanna, can You rebase it on master? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91124|0 |1 is obsolete| | --- Comment #46 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 91399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91399&action=edit Bug 16825: Add API route for getting an item Fixed the merge conflict. Patch should apply now to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91399|0 |1 is obsolete| | --- Comment #47 from Michal Denar <black23@gmail.com> --- Created attachment 91401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91401&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{item_id} Gets one Item This patch adds route to get one item from koha.items table. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91401|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92639&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{item_id} Gets one Item This patch adds route to get one item from koha.items table. To test: 1. Apply patch 2. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 3. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 4. Make sure the returned data is correct. 5. Run unit tests in t/db_dependent/api/v1/items.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not unhappy to see this moving at all! But it looks like it hasn't been voted on: https://wiki.koha-community.org/wiki/REST_api_RFCs https://wiki.koha-community.org/wiki/Items_endpoint_RFC Could we do a quick terminology check befor pushing/releasing and update the wiki? On first glance it looks quite good to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #50 from Magnus Enger <magnus@libriotech.no> --- Added to the agenda of the 11 September 2019 de meeting: https://wiki.koha-community.org/wiki/Development_IRC_meeting_11_September_20... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_rfc | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Agreed the terms seem sane.. not enough people present at meeting to hold a vote so I've taken the approach of asking key parties involved in the API design directly for comments.. all have agreed so I'm going to push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #53 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I choose to backport this enhancement on API. Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #54 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enhancement to 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 [Bug 24229] /items API tests fail on Ubuntu 18.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29107 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107 [Bug 29107] item_type should be item_type_id on item response object -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org