[Bug 39219] New: Error when issuing a refund from the transaction table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Bug ID: 39219 Summary: Error when issuing a refund from the transaction table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: - Create a manual invoice: $10.00 - Pay using the pay button in the transactions table: $1.00 - Now issuing a refund explodes into: Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Amount to payout (3.00) is higher than amountoutstanding (0)' at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Fines and fees -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error when issuing a refund |Error when issuing a refund |from the transaction table |on a partial payment from | |the transaction table --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- To me the 'Issue refund' button feels like it is on the wrong accountline after recreating the steps here. - -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think the apply() routine ( Koha/Account/Line.pm ) is incorrectly modifying the amountoutstanding when issuing refunds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178872&action=edit Bug 39219: Do not apply amountoutstanding when credit type is REFUND -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Leaving a patch here because it fixes the problem. -Still needs an updated test to cover -Also with partial payments -> refunds the payment gets set to 'REFUNDED' so you can not issue further refunds of the payment. Test by making $100 manual credit, playing $10, and issuing $1 in refunds. I'm not sure how this is supposed to work becuase this bug seems to go back as far as at least 23.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #1)
To me the 'Issue refund' button feels like it is on the wrong accountline after recreating the steps here.
-
I didn't finish my thought here. It feels like the 'Issue refund' button is on the wrong accountline. -Add a manual invoice -Partial pay it -The issue refund is now on the original invoice accountline Shouldn't it be on the partial pay accountline? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Eric Swenson <eric@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@bywatersolutions.com --- Comment #6 from Eric Swenson <eric@bywatersolutions.com> --- I agree. I think that the refund should be on the partial payment line for clarity. Since that is the money you are wanting to return to the patron it makes sense to have the button be there instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org