[Bug 6943] New: Create new budget from a copy of a previous budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Bug #: 6943 Summary: Create new budget from a copy of a previous budget Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: pelletiermaxime@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 5648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5648 Screenshot of the new Add budget page This new feature adds a list of budgets in the Add budget page to create a budget based on a previous. An exemple use case for this is if you want to create a 2010-2011 budget and want the same funds as the 2009-2010 budget, with the same amounts. It also has an option called "transfer the order acquisitions" that transfers all the orders not received in the new budget copy. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #1 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-29 17:41:44 UTC --- Created attachment 5649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5649 Patch to add feature -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-29 17:42:59 UTC --- oh, and once again this was sponsored by our client, http://www.ccsr.qc.ca/. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |pelletiermaxime@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5649|0 |1 is obsolete| | --- Comment #3 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-10-06 17:06:21 UTC --- Comment on attachment 5649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5649 Patch to add feature I'm afraid that this was not meant to be sent yet. I will update this bug once we can really share it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5649|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-13 06:07:40 UTC --- Maxime, can you clarify? The status is 'Needs Signoff' but from your comment I am not sure if this can be included into Koha at this point in time or not. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #5 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-10-13 13:03:52 UTC --- (In reply to comment #4)
Maxime, can you clarify? The status is 'Needs Signoff' but from your comment I am not sure if this can be included into Koha at this point in time or not.
Yes it can now be included. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 21:15:43 UTC --- Patch applies without conflicts, but I get a 404 error when trying to go to /cgi-bin/koha/admin/aqbudgetperiods.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 07:28:20 UTC --- End of year is near and I think it's the right time to give this a little push :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 15:34:20 UTC --- This feature is being worked by catalyst, (sub-contracted by BibLibre, sponsored by french library). Code being validated atm. (I missed this bugzilla entry, too bad -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 16:07:59 UTC --- As there is already code for that by Maxime now - perhaps some of it can be reused? I am not sure if the spec biblibre/catalyst have covers all of the functionality or more than described here. Could this made available? There is no RFC on the wiki I think? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #10 from Chris Hall <chrish@catalyst.net.nz> 2012-01-05 01:44:27 UTC --- Created attachment 7043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7043 Patch to allow duplication of budgets This is the work from Catalyst that Paul mentioned. Patch allows for a user to duplicate a budget from the edit drop down menu while viewing a budget. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-05 06:17:06 UTC --- Hi Chris, does the work from Catalyst also include an option to move the not received orders to the new funds? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #12 from Chris Hall <chrish@catalyst.net.nz> 2012-01-05 19:31:21 UTC --- (In reply to comment #11) Hey Katrin No sorry, the patch only allows for a budget and all its funds to be duplicated (as if you created a new budget with all the same funds and allocated money). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7043|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-16 06:49:33 UTC --- Created attachment 7168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7168 [SIGNED-OFF] Bug 6943: Added ability to duplicate a budget tree (from the edit sub menu) bug 6953 http://bugs.koha-community.org/show_bug.cgi?id=6943 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - all new javascript alerts have translations markers _() - hierarchies and permissions were copied correctly Possible enhancements: - make it possible to move orders from old to new funds - make it possible to change description while copying, saving 1 additional step -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-16 06:54:03 UTC --- I looked at Maxime's patch too. It still applies but /cgi-bin/koha/admin/aqbudgetperiods.pl gives me a 404. [Mon Jan 16 07:51:05 2012] [error] [client 127.0.0.1] script not found or unable to stat: /home/katrin/kohaclone/admin/aqbudgetperiods.pl, referer: http://localhost:8080/cgi-bin/koha/acqui/acqui-home.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-18 15:53:16 UTC --- QA comment: Looking at your patch chris_h, I see that you've used 2 spaces for indentation. We use 4 spaces in Koha. I checked http://wiki.koha-community.org/wiki/Coding_Guidelines and saw it was not explicit (it was still in the "discussed"), so I updated the guidelines. Marking failed QA, please resubmit with 4 tabs I don't see any other problem -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5649|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7168|0 |1 is obsolete| | Status|Failed QA |Needs Signoff AssignedTo|pelletiermaxime@gmail.com |chrish@catalyst.net.nz --- Comment #16 from Chris Hall <chrish@catalyst.net.nz> 2012-01-24 03:12:38 UTC --- Created attachment 7309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7309 Added ability to duplicate a budget Sorry about that paul, indentation spacing was something I was worrying about but i've seen both 2 and 4 used so I just used 2. Fixed editor settings so it won't happen again. Reattached patch, I modified my original patch and marked the singed off patch obsolete as I think my patch needs to be singed off again, I hope this is correct. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7309|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-25 06:25:36 UTC --- Created attachment 7330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7330 [SIGNED-OFF] Bug 6943: Added ability to duplicate a budget tree (from the edit sub menu) http://bugs.koha-community.org/show_bug.cgi?id=6943 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - all new javascript alerts have translations markers _() - hierarchies and permissions were copied correctly Possible enhancements: - make it possible to move orders from old to new funds - make it possible to change description while copying, saving 1 additional step -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |paul.poulain@biblibre.com |ity.org | --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-02 10:14:16 UTC --- QA comment: #2 The code does not respect the HTML3 coding guideline. however, it was submitted before the inclusion of this new behaviour, and there are also many dates managed elsewhere in the script, so maybe it's more consistent #1 the cloning does not let the user updating the description of the budget. Thus, the cloned budget has exactly the same name as the previous one, only the dates differ. As there is a form to enter the dates of the new budget, why not add the description of the budget ? (pre-filled with the previous value). Would you agree to add this feature to your patch ? Katrin, as you've signed-off, your opinion is welcomed ! Not marking failed QA, #2 is more a question. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-02 11:23:23 UTC --- Hi Paul, see comment 13 ;) I noted there that an option to edit the description while copying would be good. Still this feature works as advertised and it is useful - so didn't want to scope creep it. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_8 --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 16:55:40 UTC --- OK, i'm convinced, also because duplicating a budget is something you do once a year, so it's not a big deal. I'll open a new bug for the enhancement -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7498 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7580 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #19)
Possible enhancements: - make it possible to change description while copying, saving 1 additional step
I have created Bug 9155 for this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org