[Bug 11173] New: Carriage returns are missing in email notification when content type is html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Bug ID: 11173 Summary: Carriage returns are missing in email notification when content type is html Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org Notifications by email lacks carriage returns if content type is HTML Test plan : - Define one letter template for overdues for example - Check "HTML Message" - Define some overdue rules that are using this letter - Find one borrower that has overdues triggering this notification. - Run misc/cronjobs/overdue_notices.pl to generate the message and change to_address to give your email Without patch : - run misc/cronjobs/process_messsage_queue.pl => email content is all on one line With the patch : - change message status to 'pending' so that it could be sent once again - run misc/cronjobs/process_message_queue.pl => email content is displaid correctly with carriage returns as defined in template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |sophie.meynieux@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 22611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22611&action=edit Bug 11173 : Notifications by email lacks carriage returns if content type is HTML Test plan : - Define one letter template for overdues for example - Check "HTML Message" - Define some overdue rules that are using this letter - Find one borrower that has overdues triggering this notification. - Run misc/cronjobs/overdue_notices.pl to generate the message and change to_address to give your email Without patch : - run misc/cronjobs/process_messsage_queue.pl => email content is all on one line With the patch : - change message status to 'pending' so that it could be sent once again - run misc/cronjobs/process_message_queue.pl => email content is displaid correctly with carriage returns as defined in template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure, but would we not be using <br/> and HTML block elements to create line breaks in HTML overdues? If I am using HTML I might make line breaks for better and easier readable display and wouldn't want those interpreted as new lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm that last sentence didn't make sense: make line breaks for an easier readable template, but don't want them to appear in my notice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22611|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22631&action=edit Bug 11173 : Notifications by email lacks carriage returns if content type is HTML Test plan : - Define one letter template for overdues for example - Check "HTML Message" - Define some overdue rules that are using this letter - Find one borrower that has overdues triggering this notification. - Run misc/cronjobs/overdue_notices.pl to generate the message and change to_address to give your email Without patch : - run misc/cronjobs/process_messsage_queue.pl => email content is all on one line With the patch : - change message status to 'pending' so that it could be sent once again - run misc/cronjobs/process_message_queue.pl => email content is displaid correctly with carriage returns as defined in template Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #2)
Hm, not sure, but would we not be using <br/> and HTML block elements to create line breaks in HTML overdues? If I am using HTML I might make line breaks for better and easier readable display and wouldn't want those interpreted as new lines.
I guess that you would be formally right. But I think that most users (not limited by extensive html knowledge..) would enjoy to get the line breaks as they do now. Looking forward to your QA remarks on that, Katrin. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Well, I disagree. If I work with HTML, I want it to behave like HTML, else I will have to write insanely long lines to avoid accidental line breaks - which doesn't seem right to me. And I lose the ability that HTML gives me - to control the layout more exactly that I can do with plain text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #7 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Katrin, Librarian use HTML in template only to add some specific display (add a div to right align address for exemple), but they are not writing full html templates. And they are very suprised to see their carriage returns vanished in sent messages. I'm not sure to ask them to write full HTML is a good point -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we can have another checkbox to indicate 'parial HTML'? I am still not persuaded that mixing up things is the way to go. There is some information on the wiki about HTML emails, and it looks like writing HTML for emails is a bit different than writing HTML for websites: http://wiki.koha-community.org/wiki/Customising_Notices_and_Slips But we also have the slips - those are 'normal HTML. I am adding Galen to this discussion - I think more opinions on this would be good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- The HTML option has been available since 3.8, so we must presume that some libraries have crafted HTML-formatted notices to their liking, including adding the necessary explicit <br> tags or whatever. If we add automatic insertion of <br> for line breaks those existing notices then they will suddenly have broken formatting. To me the obvious solution is to offer a WYSIWYG interface for notices like we have for News: Checking the "HTML" checkbox would trigger the TinyMCE editor on the textarea. If we did that then it would be quite clear where line breaks would fall. The tricky part, I imagine, would be making the field chooser play nicely with the WYSIWYG editor. That makes this idea non-trivial, I think. In short: I don't think this patch is a good idea, but I don't have an easy alternative to offer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Why don't we write templates completely in HTML, with <br />? And if we check to send notices in plain text, Koha could stripe out all HTML tags, and replace BR with new lines. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mathieu, we have a checkbox for HTML - so you can choose, how you want to format. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9372 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12294 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org