https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159531&action=edit Bug 35407: Correct terminology: Show fewer collections In the OPAC, the "Show more" and "Show less" links have aria-labels to make their function clearer to screen readers. The collection and item type controls need corrected terminology, and the links also need to have their template filter corrected (html, not uri). To test, apply the patch and perform a catalog search in the OPAC. - Test that the "Show more" and "Show less" links in the facets sidebar work correctly to expand and collapse the lists of facets. - It's not necessary to test with a screen reader. You can view the source to confirm the markup on the "Show more collections" and "Show more item types" links. Before: <a href="#" aria-label="%0A%20%20%20%20Show%20more%20collection%20codes%0A"><strong>Show more</strong></a> After: <a href="#" aria-label="Show more collections"><strong>Show more</strong></a> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159531|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159543&action=edit Bug 35407: Correct terminology: Show fewer collections In the OPAC, the "Show more" and "Show less" links have aria-labels to make their function clearer to screen readers. The collection and item type controls need corrected terminology, and the links also need to have their template filter corrected (html, not uri). To test, apply the patch and perform a catalog search in the OPAC. - Test that the "Show more" and "Show less" links in the facets sidebar work correctly to expand and collapse the lists of facets. - It's not necessary to test with a screen reader. You can view the source to confirm the markup on the "Show more collections" and "Show more item types" links. Before: <a href="#" aria-label="%0A%20%20%20%20Show%20more%20collection%20codes%0A"><strong>Show more</strong></a> After: <a href="#" aria-label="Show more collections"><strong>Show more</strong></a> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer@bsz-bw.de |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Merge conflicts with 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.