[Bug 13115] New: Holidays.t will fail some unit tests on Sundays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Bug ID: 13115 Summary: Holidays.t will fail some unit tests on Sundays Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Due to the fact that Sunday is a repeating holiday in the example data which is used for part but not all of Holidays.t, the last test will fail on Sundays. The test is to see if today is *not* a special holiday for MPL, but since it's already a repeating holiday, is_holiday will return true rather than false. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32530&action=edit Bug 13115 - Holidays.t will fail some unit tests on Sundays Due to the fact that Sunday is a repeating holiday in the example data which is used for part but not all of Holidays.t, the last test will fail on Sundays. The test is to see if today is *not* a special holiday for MPL, but since it's already a repeating holiday, is_holiday will return true rather than false. Test Plan: 1) Wait until Sunday 2) prove t/db_dependent/Holidays.t 3) Note the failure 4) Apply this patch 5) Repeat step 2 6) Note there is no longer a failure -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32530|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 32532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32532&action=edit Bug 13115 - Holidays.t will fail some unit tests on Sundays Due to the fact that Sunday is a repeating holiday in the example data which is used for part but not all of Holidays.t, the last test will fail on Sundays. The test is to see if today is *not* a special holiday for MPL, but since it's already a repeating holiday, is_holiday will return true rather than false. Test Plan: 1) Wait until Sunday 2) prove t/db_dependent/Holidays.t 3) Note the failure 4) Apply this patch 5) Repeat step 2 6) Note there is no longer a failure Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32532|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32567&action=edit [PASSED QA] Bug 13115 - Holidays.t will fail some unit tests on Sundays Due to the fact that Sunday is a repeating holiday in the example data which is used for part but not all of Holidays.t, the last test will fail on Sundays. The test is to see if today is *not* a special holiday for MPL, but since it's already a repeating holiday, is_holiday will return true rather than false. Test Plan: 1) Wait until Sunday 2) prove t/db_dependent/Holidays.t 3) Note the failure 4) Apply this patch 5) Repeat step 2 6) Note there is no longer a failure Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Used my time machine... :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org