[Bug 21132] New: Highlight active filters on saved report page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Bug ID: 21132 Summary: Highlight active filters on saved report page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 77325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77325&action=edit Screenshot showing the search term highlighting I propose to add a more obvious view of which terms have been submitted to filter the saved reports page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77326&action=edit Bug 21132: Highlight active filters on saved report page This patch adds a more obvious way of see which search terms have been submitted to filter the table of saved reports. The patch also moves embedded CSS into a separate file. To test you should have multiple saved reports. - Apply the patch and go to Reports -> Use saved. - Filter the table of reports by submitting one or more terms in the sidebar "Filter" form. - Confirm that the terms you submit are shown at the top of the table of results. - Confirm that clicking the "Clear" link clears the search filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77326|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 77482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77482&action=edit Bug 21132: Highlight active filters on saved report page This patch adds a more obvious way of see which search terms have been submitted to filter the table of saved reports. The patch also moves embedded CSS into a separate file. To test you should have multiple saved reports. - Apply the patch and go to Reports -> Use saved. - Filter the table of reports by submitting one or more terms in the sidebar "Filter" form. - Confirm that the terms you submit are shown at the top of the table of results. - Confirm that clicking the "Clear" link clears the search filter. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77482|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77495&action=edit Bug 21132: Highlight active filters on saved report page This patch adds a more obvious way of see which search terms have been submitted to filter the table of saved reports. The patch also moves embedded CSS into a separate file. To test you should have multiple saved reports. - Apply the patch and go to Reports -> Use saved. - Filter the table of reports by submitting one or more terms in the sidebar "Filter" form. - Confirm that the terms you submit are shown at the top of the table of results. - Confirm that clicking the "Clear" link clears the search filter. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not backport to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org