[Bug 38020] New: Fix 'delete list' button to have same formatting as 'edit list'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Bug ID: 38020 Summary: Fix 'delete list' button to have same formatting as 'edit list' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In the staff interface, the edit and delete list buttons in the 'edit' dropdown look different. To recreate: 1. Create a list in the staff interface 2. Go to lists 3. View the list 4. Click the Edit dropdown 5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yanjun.li@bywatersolutions. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #1 from Yanjun Li <yanjun.li@bywatersolutions.com> --- Created attachment 173307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173307&action=edit Bug 38020: Change form to submit link To test: 1. Create a list in the staff interface 2. Go to lists 3. View the list 4. Click the Edit dropdown 5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different 6. Apply patch 7. Try steps 1 through 4 again 8. The delete list button form looks right, and delete function works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |yanjun.li@bywatersolutions. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246 [Bug 36246] Have a centralized method for submitting a form via a link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173307|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 173311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173311&action=edit Bug 38020: Change form to submit link To test: 1. Create a list in the staff interface 2. Go to lists 3. View the list 4. Click the Edit dropdown 5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different 6. Apply patch 7. Try steps 1 through 4 again 8. The delete list button form looks right, and delete function works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the items in the release notes| |'Edit' menu for lists in | |the staff interface so that | |the options (Edit list, | |Delete list) are correctly | |left aligned. Previously, | |'Delete list' was indented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- FYI for anyone trying to solve similar problems: A control in a dropdown menu that looks like this: <button type="submit" class="btn btn-default delete-list">Delete list</button> ...will look wrong because of the "btn btn-default" class. If you change it to "dropdown-item" it looks fine without making other markup changes. <button type="submit" class="dropdown-item delete-list">Delete list</button> There's no guideline saying one is better than the other so it makes no difference for this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I don't think this is PQA ready but don't think the reasons below are enough to FQA either, so I'm only leaving comments here in case they make sense: 1) The following code: $(".delete-list").click(function(e){ return confirm(_("Are you sure you want to delete this list?")); }); in virtualshelves/shelves.tt is no longer used after this patch, because the confirmation message is now part of the anchor link. If this is true, it should be removed. 2) Not related to this patch directly, but related to the previous point, virtualshelves/tables/shelves_results.tt has 'class="delete-list' for the delete button on the list view, but the JS code in 1) is only used on the 'view' op, not the 'list' op, thus deleting a list from the detail page has a confirmation dialog, but deleting a list from the list view does not have a confirmation dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't be scared to set Failed QA for questions and clarification - it's not a bad thing and the status change helps to get attention as it will show on the personal dashboard for example, while an email is easy to miss. We need to make that less scary maybe :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #5)
Don't be scared to set Failed QA for questions and clarification - it's not a bad thing and the status change helps to get attention as it will show on the personal dashboard for example, while an email is easy to miss. We need to make that less scary maybe :)
Agreed. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Yanjun Li <yanjun.li@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173311|0 |1 is obsolete| | --- Comment #7 from Yanjun Li <yanjun.li@bywatersolutions.com> --- Created attachment 173724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173724&action=edit Bug 38020: Change form to submit link To test: 1. Create a list in the staff interface 2. Go to lists 3. View the list 4. Click the Edit dropdown 5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different 6. Apply patch 7. Try steps 1 through 4 again 8. The delete list button form looks right, and delete function works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #8 from Yanjun Li <yanjun.li@bywatersolutions.com> --- Created attachment 173725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173725&action=edit Bug 38020: (follow-up) Remove unused delete confirmation code This follow-up patch removes the unused delete list confirmation dialog in virtualshelves/shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #9 from Yanjun Li <yanjun.li@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #4)
1) The following code:
$(".delete-list").click(function(e){ return confirm(_("Are you sure you want to delete this list?")); });
in virtualshelves/shelves.tt is no longer used after this patch, because the confirmation message is now part of the anchor link. If this is true, it should be removed.
2) Not related to this patch directly, but related to the previous point, virtualshelves/tables/shelves_results.tt has 'class="delete-list' for the delete button on the list view, but the JS code in 1) is only used on the 'view' op, not the 'list' op, thus deleting a list from the detail page has a confirmation dialog, but deleting a list from the list view does not have a confirmation dialog.
Thank you for your comment! I added a follow-up for 1) also opened a ticket for 2) Bug 38302 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173724|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173747&action=edit Bug 38020: Change form to submit link To test: 1. Create a list in the staff interface 2. Go to lists 3. View the list 4. Click the Edit dropdown 5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different 6. Apply patch 7. Try steps 1 through 4 again 8. The delete list button form looks right, and delete function works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173725|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173748&action=edit Bug 38020: (follow-up) Remove unused delete confirmation code This follow-up patch removes the unused delete list confirmation dialog in virtualshelves/shelves.tt Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173749&action=edit Bug 38020: (QA follow-up) Decapitilise 'list' Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36246 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org